usmanjafri/pyconchat

A Python console chat application featuring group conversations, file sharing and offline messaging.

pyconchat's Issues

Client crashes if file to send does not exist

add client by another computer to connect the group

Server needs multi-threaded handshake to ensure multiple clients can simultaneously join

Server crashes when waiting-to-be-approved client disconnects

Possible fix: Missing break at /waitDisconnect condition in server.py

Password ?

i think ( i you can do this ) you can add password or group/user stockage because, it's easy to say "i'm the admin" just by use his username.

Unnecessary exchange of username and group name

The exchange of username and group name for every message from the client is inefficient and unnecessary.

Possible fix: Store the username and group name in variables in the pyconChat function at the server.

Will you be adding to this code again?

Will you be adding offline messaging and password auth?

Thread safety

Thread-safety violation: The group map is being accessed by multiple threads concurrently in an unsafe manner.