uwrobotics/uwrt_mars_rover_hw_bridge

payload structs and related convenience functions

uwrt_mars_rover_hw_bridge's Issues

Add CI pipeline to hw bridge repo

We need some ci pipeline integrated into the hw bridge repo so that people can merge without an admin needing to force merge. Currently, both fw and sw repos are pinned to a certain commit on the bridge repo.

Extra care needs to be put into this pipeline. I think that whenever there's a pr to the bridge repo, there should be pipelines run to build it against master of sw and fw. This way, we guard against backwards compatibility breaking changes.

Sometimes, things need to break backwards compatibility, and for good reason. A github admin would be able to force merge, but I think that two things need to happen:

• There should be a way of logging which commits break backwards compatiblity
• On MRs with backward-compatibility breaking changes, we should have a way to run CI against a special commit of both SW and FW to prove that the fixes to the breaking changes are implemented and working. These should be commits that are in a PR stage and have passing pipelines in their respective repos.

The idea behind the second point, is that if we ever have a breaking change, we have synced prs to sw, fw, and bridge at the same time.

Add ODrive CAN Messages to 2022 yaml file

Add the ODrive CAN messages to the 2022 YAML file. Test out ODrive CAN control.

Refactor can generation scripts to avoid shell=True

ok i looked a little into it. I think its because of your shell config and cause @cindyli-13 wrote the generate_can script to use the shell=True option. just manually delete this diff for this file for now imo.

TBH, the script should be fixed not to use shell=True to fix this issue (also because shell=True should just almost always be avoided because of performance and potential security vulnerability reasons), but that sounds like it should probs be addressed seperately

Originally posted by @wmmc88 in #30 (comment)

Switch enums to enum classes

enum classes are preferred for many reasons: https://www.geeksforgeeks.org/enum-classes-in-c-and-their-advantage-over-enum-datatype/

you'd also have to make sure this chnage doesnt break sw and fw

So for some reason this garbage string gets generated each time we run the CAN autogen script. Manually deleting it every time isn't a good solution, will investigate into this later

So for some reason this garbage string gets generated each time we run the CAN autogen script. Manually deleting it every time isn't a good solution, will investigate into this later

Originally posted by @cindyli-13 in #33 (comment)

Add CANID CSV here

Improve CAN yaml structure and autogen suite - hexadecimal representation for CAN IDs

• Have hexadecimal representation in the yaml file for CAN IDs