vaadin/addressbook

Simple Addressbook example application

Vaadin web components

This package contains all Vaadin web components (free and commercial).

See https://github.com/vaadin/web-components for more details.

addressbook's Issues

wrong url for git repo

git://github.com/vaadin/addressbook.git is not the right url! It needs to be https://github.com/vaadin/addressbook.git

Form is not closed when pressing cancel for new contact

1. Press "new contact"
2. Press "cancel"

Expected: Back at the original view
Actual: Notification shown that the edit has been cancelled but the form is still shown

Eclipse has problem "failOnMissingWebXml" with fresh opened Project

we've unpacked the zip
start Eclipse
Import Existing Maven Projects

and see the Error
"web.xml is missing and is set to true"
in pom.xml (Textedit mode) on line 7

a little Google search:
the problem is solved with adding the following plugin-sequence to pom.xml

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-war-plugin</artifactId>
    <version>2.2</version>
    <configuration>
        <failOnMissingWebXml>false</failOnMissingWebXml>
    </configuration>
</plugin>

Since Eclipse is from Vaadin the recommended platform and addressbook is a project for beginners, this issue is set.

Eclipse Java EE IDE for Web Developers
Version: Mars Release (4.5.0)
Buld id: 20150621-1200

WAS Liberty 8.8.5.7 is not liking commons-logging 1.1.1 jar; use commons-logging 1.2 instead

Environment : WebSphere Application Server 8.5.5.7/wlp-1.0.10.cl50720150827-0437) on Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_66-b17 (en_US)

I get this error when launching the application
[ERROR ] CWWKM0101E: The system could not process archive data for C:\Research\GitHub\Vaadin\addressbook\target\addressbook-2.0\WEB-INF\lib\commons-logging-1.1.1.jar.

commons-logging 1.1.1 jar is loaded as part of commons-beanutils 1.9.2 dependency.
Adding common-logging 1.2 dependency fixed this issue

commons-logging
commons-logging
1.2

Possible NPE in ContactService

The following comparator may throw NPE in cases when Contact's ID hasn't been set:

    Collections.sort(arrayList, new Comparator<Contact>() {
        @Override
        public int compare(Contact o1, Contact o2) {
            return (int) (o2.getId() - o1.getId());
        }
    });

mavan+jetty

I pulled the project from github but I got this error:
Failed to execute goal org.eclipse.jetty:jetty-maven-plugin:9.2.3.v20140905
Im using intelliJ.

Unfortunately, I didnt find a solution to the problem, help? :)