vaadin / bookstore-starter-flow Goto Github PK

[DEPRECATED* A simple example web application built with Vaadin 10 using Java. Replaced with https://github.com/vaadin/bookstore-example

Home Page: https://vaadin.com/start

Java 94.50% JavaScript 1.79% CSS 3.72%

bookstore-starter-flow's Introduction

Vaadin web components

This package contains all Vaadin web components (free and commercial).

See https://github.com/vaadin/web-components for more details.

bookstore-starter-flow's People

Contributors

Stargazers

Watchers

Forkers

jmgsquared214 tulioag johannesh2 ujoni pks-os appsamples lovrofrece benwilsoni alvarezguille preciousonyekwere pradnyadevops0112

bookstore-starter-flow's Issues

Use theme variants for nicer formatting in product form

Put the € symbol as a suffix in the price field instead of formatting it into the value, and use the “align-right” theme variant
Use “align-right” for the “In stock” field as well

Application is broken

Build and run application as readme says
open http://localhost:8080/

Result: you are redirected immediately to http://localhost:8080/Inventory/ without asking login first.
Since there is no auth info the page shows nothing except a need to login.

Navigating with empty parameter should close the form

When saving a new product, the url is updated to /inventory/, but the editor form is left open.
The situation is the same when clicking the cancel-button when adding a new product. This makes it really hard to exit the form when creating a new product.

Step six: production mode changes in pom.xml files

Do not allow delete for product that doesn't exist yet

Click “New product”, click “Delete” → Internal error

Delete probably shouldn't be possible at this point, canceling only.

v10/v11 version generates listener class in com.vaadin.BookstoreInitListener

Probably #56 which is only in master

Jetty?

mvn jetty:run

No plugin found for prefix 'jetty'

Migrate the app to use the theming variants API in Flow 1.1

Once there is a platform release (even prerelease), that is using Flow 1.1 or newer, the app should be migrated to using the theming variant API, instead of the low-level element API.

Consider changing the project to single module

The FW7/FW8 version was a multi module project to be able to handle the widget set properly if memory serves me right. In this version there is no widget set and no need for a separate production module so having a multi module project with the complexity that comes with it seems unnecessary.

Once Select component is available, use it

Use dropdown menu instead of combo box for Availability (no need for the required validation then either)

Rename MainScreen to MainLayout

MainScreen is really weird naming now for V10 (it was even for V8 IMO) and should be renamed to MainLayout instead

Modifying book doesn't enable save button

The UI just feels broken as save button isn't enabled when changes are made to the book

Step two for migration: LoginScreen

Migrate the login screen to V10.

Add an IT test to check the AdminView

The pull request #120 has an AdminView page not working due to vaadin/flow#5509 but its IT tests are passing.

Need to add another test that will detect the issue and won't allow to merge such PRs.

App works very slowly in MS Edge

On Win10, MS Edge 42 (Microsoft EdgeHTML 17.17134)

Using eg. master branch and V12 snapshot,

the Grid on the Inventory view opens very slowly, in two steps
- first N rows, you see white space for a while, then rest of the rows are loaded
- Is there some size miscalculation happening ?
Scrolling the grid is so slow it is basically broken
the Grid is quite unresponsive for clicks after loading it the first time
- opening the editor first time or after navigating to the inventory page from /about page
- after opening the editor it becomes a lot faster

Theme the app according to designs

Designs pending

Remove the button from the menu tabs

We shound't have the button there just to be able to place the icon on the left of the text - the menu doesn't have to look 1-1 with the older version.

Zip packaging doesn't work in the website

Since the project is split into multiple modules, the zip packaging for the start page download is not working. It should be fixed so that it can also work with multimodule Maven projects.

Technically it can either detect multimodule projects automatically, or there can be some additional metadata for this.

Login view contains "admin" as input prompt for user name

It looks like it is a pre-filled value for the user. As a placeholder I'd expect there to be something like "username", but even that is obsolete as there is a label on top of the field.

Pressing enter key on login screen should login

Migrate the product form to be Java only without template

Remove the work around after form-layout got fixed

after the form-layout regression got fixed
https://github.com/vaadin/vaadin-form-layout/issues/108

please remove the workaround from master and V13 branch
https://github.com/vaadin/bookstore-starter-flow/pull/106/files#diff-f30a559cec9f41f4a9033de934f17960R69

Proper capitalization of text

Use “Sentence case” for UI text (vs “Title Case”)
- F.e. “Product name” instead of “Product Name”

Reset the repository to be ready for migration

Reset the master branch to be empty (no code commits, just .gitignore)
Make the master branch protected, add validation build
Make a PR for adding the whole FW 8 version of the starter
Make the repository public

Opening ProductForm via New Product button and then clicking Logout causes StackOverflowError

Steps to reproduce:

Login in as Admin
Close PWA popup
Click "New product" button
Click "Logout" button

Expected:

Application logs out the user

Actual:

Application crashes with StackOverflowError

This can also be replicated by refreshing the page while New product form is open.

Add V10 dependency
Change the UI to use Flow version
- remove Navigator stuff
Add a temporary route mapped for "" url to be able to verify that the V10 part works

run "mvn -Pproduction package" in the ui module or in the parent module