Giter Site home page Giter Site logo

Comments (7)

jouni avatar jouni commented on August 14, 2024

I don’t see the issue. The content behaves just as the CSS says it should work. If you want the content to take all the available space, you should use height: 100%, right?

Edit: well, height: 100% doesn’t work because part="content" does not have explicit height defined. So you’d need to use flex for the content area or absolute positioning.

from vaadin-app-layout.

jouni avatar jouni commented on August 14, 2024

I agree that it should be possible to be able to make the content (user-defined) use the available space. But we should not force that by default.

from vaadin-app-layout.

DiegoCardoso avatar DiegoCardoso commented on August 14, 2024

Take a look at this example where the div.page is set to height: 100%, but still it doesn't grow to take the full height even though when you inspect the content part it will show as using it.

from vaadin-app-layout.

DiegoCardoso avatar DiegoCardoso commented on August 14, 2024

The current way to do that is by styling [part="content"]

from vaadin-app-layout.

jouni avatar jouni commented on August 14, 2024

Yeah, I edited my previous comment and added another one. Hope those clarify my concern.

from vaadin-app-layout.

tmattsso avatar tmattsso commented on August 14, 2024

What would the expectation of a developer be? can we make it easier for them then having to define a separate bit of boilerplate css? This is after all a very basic use case.

from vaadin-app-layout.

jouni avatar jouni commented on August 14, 2024

This is after all a very basic use case.

Yes, agreed. And I would expect the expectation of a developer to be that they only need to define the height of the content they provide as 100% to make it stretch. For example:

<vaadin-app-layout>
  <div class="my-content"></div>
</vaadin-app-layout>

<style>
  .my-content {
    height: 100%;
  }
</style>

from vaadin-app-layout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.