vaarun-c/ki

ki's Issues

Function crashes if it can't find Pokemon

If no automated account has any better Pokemon to trade, the replace_better_pokemon() function crashes instead of cancelling the trade.

Error:
An exception has occurred while executing command trading: Traceback (most recent call last): File "E:\Projects\Ki\venv\lib\site-packages\discord_slash\client.py", line 1352, in invoke_command await func.invoke(ctx, **args) File "E:\Projects\Ki\venv\lib\site-packages\discord_slash\model.py", line 209, in invoke return await self.func(self.cog, *args, **kwargs) File "E:\Projects\Ki\cogs\trading.py", line 91, in trading await self.replace_better_pokemon(ctx.author) File "E:\Projects\Ki\cogs\trading.py", line 207, in replace_better_pokemon self.pokemon_to_return = await self.get_best_pokemon() File "E:\Projects\Ki\cogs\trading.py", line 349, in get_best_pokemon max_iv = best_pokemon[self.client.available_slaves[0]["name"]][1] KeyError: 'Winston'

Improvement for filtering wares

While viewing all the wares the user has to type "all" as an argument. Instead of this if there is no argument it should be defaulted to all. Similar situation while viewing info of traded Pokemon.

Automated account doesn't update data in database for shiny hunted pokemon

If an automated account catches its shiny hunted Pokemon it doesn't update both its list and its streak on database after catching it.

Error:
Ignoring exception in on_message Traceback (most recent call last): File "E:\Projects\Ki\venv\lib\site-packages\discord\client.py", line 343, in _run_event await coro(*args, **kwargs) File "E:\Projects\Ki\Ki.py", line 89, in on_message poke = await client.catch.who_catches() File "E:\Projects\Ki\cogs\catching.py", line 121, in who_catches await self.shiny_hunt.update_streak(master["slave"]["id"], True) File "E:\Projects\Ki\cogs\shinyhunt.py", line 122, in update_streak if(int(slave["id"]) == user_id): KeyError: 'id'

Account stuck taking hints for "Sobble", "Starly"

Ki asks you to confirm trade incessently

Ki keeps asking you to confirm the trade after the Pokemon to be traded is shown. Even if you click the view info button the bot mentions the user and asks to confirm trade for each subsequent message before confirming the trade even before the info page is opened.

Automated accounts catch pokemon regardless of whether users have them or not

:(


instead it says that the user hasn't made a list

Bot doesn't know what to do with "Type: Null"

Ki doesn't know what to do when a "Type: Null" spawns.

Not storing pokemon correctly in database

The algorithm to store the list of Pokemon with an automated account is not storing Pokemon data from the last page of Pokemon.

When only one pokemon is added the automated account still tries to go the next page

Even if there is only one page in the trade the automated account tries going to the next page before retrieving information from the page and executing the rest of the function.

Sometimes the automated accounts don't catch pokemon

I don't know if this is an issue with code or my hardware.

Ki unnecesarily asks user to move to next page while making a list

Ki asks the user to go to the next page even when on last page when the number of Pokemon is exactly divisible by 20

Ineffiecient way of sending automated messages

Currently for each message that an automated account needs to send, it changes to the needed channel first.

This greatly decreases the speed at which the account can send messages and react to events.

Storing the current channel in which the account is active in and switching only when necessary might improve the speed

Pokemon data doesn't update on Database after trade

Once traded the data doesn't update on the database. So the automated account uses the previous list which still contains the Pokemon already traded

Spam allows mentioning players

Need to remove this because it will be annoying.

Account status not updating fast enough

Ki checks what accounts are online by their respective master bot's discord status. Discord takes a while to update this status and hence if you close an account and immediately check what accounts are online it treats the closed account as an online one. Maybe this could be improved by checking the status of the accounts themselves as those seem to update faster.

Nidoran images aren't downloaded

Error
Exception in callback Loop.restart.<locals>.restart_when_over(<Task cancell...init__.py:88>>) at E:\Projects\Ki\venv\lib\site-packages\discord\ext\tasks\__init__.py:261 handle: <Handle Loop.restart.<locals>.restart_when_over(<Task cancell...init__.py:88>>) at E:\Projects\Ki\venv\lib\site-packages\discord\ext\tasks\__init__.py:261> Traceback (most recent call last): File "C:\Users\IB\AppData\Local\Programs\Python\Python39\lib\asyncio\events.py", line 80, in _run self._context.run(self._callback, *self._args) File "E:\Projects\Ki\venv\lib\site-packages\discord\ext\tasks\__init__.py", line 263, in restart_when_over self.start(*args, **kwargs) File "E:\Projects\Ki\venv\lib\site-packages\discord\ext\tasks\__init__.py", line 205, in start raise RuntimeError('Task is already launched and is not completed.') RuntimeError: Task is already launched and is not completed. E:/Projects/Ki/Images/Nidoran??/1.png: Invalid argument

While checking who caught the pokemon, if the user has has specified Poketwo not to mention them the bot can't get user id

If PokeTwo doesn't mention the user Ki is unable to get the user id