vadimonus/moodle-local_purgequestioncategory

moodle-local_purgequestioncategory's Issues

questions disappear

in "Confirm question category purge" the first prompt specifies "Please choose another category to move them to". So it's expected that questions are moved to the chosen category. Instead, all questions simply disappear

Plugins guardians - capability checking needs to be added.

I believe you should be testing the capability 'local/purgequestioncategory:purgecategory' in all of your main level scripts, such as "category.php". While you check for them in the library functions that add the links to the navigation menus, the scripts could be called directly from the web URL. Therefore I think you need to check that capability there as well.
As a test, I added the capability "moodle/question:managecategory" to a student at a course level, and accessed "/local/purgequestioncategory/category.php?cmid=xx" direct. Instead of getting a permissions error, the function through a coding error. Testing for the "purgecategory" capability at the top of this script would resolve that.
Since this is a top-level callable script, you should also check for login.
These comments also apply to "confirm.php".

Usability: "Top" is not a valid category

When selecting a category to move questions to, I can't select the "Top" category.

Plugins guardians - undefined variable

With the plugin installed, if I access a non-quiz activity, I get an undefined variable warning thrown (with developer debugging on) as follows:
"Notice: Undefined variable: questionbank in /[moodleroot]/local/purgequestioncategory/lib.php on line 86"

Usability: Better handle edge case when there is no question to be moved

As @mchurchward noticed on the plugin page, when there is no question in the question banks, the UI does not give any hint to the user on what to do. It would be nice to display something like "There is no question to be purged" or so.

Usability: Why do I have to select another category?

Use case: I just imported dozens of questions by mistake. I have not added them to any quiz yet. When attempting to purge the imported category, I am forced to select another category to move questions to:

The category 'GCSE Computing categories' contains 141 questions (some of them may be old, hidden,
questions that are still in use in some existing quizzes). Please choose another category to move them
to.

This is confusing because I do not want to move the questions. I want to delete them.

I understand that the tool can not delete used questions. But I would expect it detects such a need and asks for the target category only if needed.

Typo: unerstand

The "unerstand" should read "understand".