Giter Site home page Giter Site logo

Comments (5)

valin4tor avatar valin4tor commented on May 21, 2024 1

Try this: https://api.cirrus-ci.com/v1/artifact/task/6146237603774464/deb/out/debs/notionenhanced_2.0.11-8_amd64.deb (and uninstall notion-enhanced)

from notion-linux.

trustin avatar trustin commented on May 21, 2024 1

Thank you so much!

from notion-linux.

valin4tor avatar valin4tor commented on May 21, 2024

Thanks for the report, this seems to occur for the notion-desktop package as well so isn't related to Notion Enhancer.

Based on my research, this issue seems to be caused by a bug in xdg-settings which runs when Electron registers the notion: protocol, which allows you to login with Google or Apple via a web browser and return to the app.

I've found these two issues which are relevant: electron/electron#20382 and signalapp/Signal-Desktop#3602

Signal has worked around the xdg-settings bug by removing the dash in their app name, so similarly I would need to change notion-desktop to notiondesktop ... however this would probably break people's settings due to the folder name changing.

Right now I'm not really prioritising development of this app so I'm not sure I can fix this for now, but I think you can do the following to make a custom build which is fixed:

  • open scripts/enhance.sh and scripts/_variables-2.sh
  • replace every notion-enhanced with notionenhanced in those files
  • run the following:
    scripts/build.sh
    scripts/enhance.sh
    scripts/package-deb.sh -n notionenhanced
    

from notion-linux.

trustin avatar trustin commented on May 21, 2024

By the way, I ended up fixing all Electron-based apps by putting this script (~/.local/bin/xdg-settings) in my PATH:

#!/bin/bash
if [[ "$1 $2" == "set default-url-scheme-handler" ]]; then
  DEFAULT_BROWSER="$(xdg-mime query default text/html)"
  /usr/bin/xdg-settings "$@"
  if [[ "$(xdg-mime query default text/html)" != "$DEFAULT_BROWSER" ]]; then
    echo "Reverting the default web browser to $DEFAULT_BROWSER"
    xdg-mime default "$DEFAULT_BROWSER" text/html
  fi
  exit 0
fi

exec /usr/bin/xdg-settings "$@"

from notion-linux.

valin4tor avatar valin4tor commented on May 21, 2024

I'm afraid I am no longer supporting this project, so I will not be looking into this issue. Please see the updated README for more information. I will leave the issue open, in case of a new maintainer who is able to look into it.

from notion-linux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.