vanossj/tab-pair-header-source

tab-pair-header-source's Issues

Uncaught TypeError: tab.parentElement.getTabs is not a function

1. Click on an open tab which should be part of a pair.

Atom: 1.15.0 x64
Electron: 1.3.13
OS: Ubuntu 16.04.2
Thrown From: tab-pair-header-source package 0.3.3

Stack Trace

Uncaught TypeError: tab.parentElement.getTabs is not a function

At /home/nicholaswalton/.atom/packages/tab-pair-header-source/lib/tab-pair-header-source.js:324

TypeError: tab.parentElement.getTabs is not a function
    at Object.setTabTitle (/packages/tab-pair-header-source/lib/tab-pair-header-source.js:324:38)
    at /packages/tab-pair-header-source/lib/tab-pair-header-source.js:214:47
    at Array.forEach (native)
    at Object.compressGroups (/packages/tab-pair-header-source/lib/tab-pair-header-source.js:212:12)
    at /packages/tab-pair-header-source/lib/tab-pair-header-source.js:267:12
    at Array.forEach (native)
    at Object.checkPanes (/packages/tab-pair-header-source/lib/tab-pair-header-source.js:259:11)
    at Object.changedActiveItem (/packages/tab-pair-header-source/lib/tab-pair-header-source.js:382:10)
    at /packages/tab-pair-header-source/lib/tab-pair-header-source.js:60:81
    at Function.module.exports.Emitter.simpleDispatch (/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at /app.asar/src/pane-container.js:348:27
    at Function.module.exports.Emitter.simpleDispatch (/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at Pane.module.exports.Pane.setActiveItem (/app.asar/src/pane.js:300:22)
    at Pane.module.exports.Pane.activateItem (/app.asar/src/pane.js:452:21)
    at TabBarView.module.exports.TabBarView.onMouseDown (/app.asar/node_modules/tabs/lib/tab-bar-view.js:678:19)

Commands

Non-Core Packages

aligner 0.22.3 
aligner-python 1.0.1 
alignment 1.1.5 
antialiased 0.1.0 
atom-alignment 0.12.1 
atom-auto-prettier 0.1.1 
atom-beautify 0.29.17 
atom-clang-expand 0.1.3 
atom-fuzzy-grep 0.16.0 
atom-make 0.5.0 
atom-terminal 0.8.0 
autocomplete-clang 0.10.1 
autocomplete-python 1.8.63 
block-selection-mode 0.3.0 
build 0.67.0 
build-make 0.13.0 
build-tools-make 0.2.1 
busy 0.7.0 
busy-signal 1.3.0 
chrome-color-picker 0.8.0 
clang-tools-extra 0.0.2 
close-bracket-hint 0.0.0 
code-peek 1.4.18 
color-picker 2.2.5 
copy-with-syntax 0.0.3 
cparts 0.4.0 
dbg 1.4.1 
dbg-gdb 1.6.2 
fold-navigator 0.0.618 
fonts 2.0.0 
gcc-make-run 0.2.9 
git-blame 0.4.12 
git-diff-details 1.4.0 
git-log 0.4.1 
git-plus 7.3.3 
git-status 0.3.4 
git-time-machine 1.5.9 
greppen-grok 0.2.1 
guess-indent 0.1.0 
hey-pane 0.2.2 
intentions 1.1.2 
language-cpp14 0.6.2 
language-protobuf 0.7.1 
language-vhdl 0.7.2 
linter 2.1.2 
linter-cppcheck 0.2.3 
linter-gcc 0.7.1 
linter-just-say-no 0.7.3 
linter-less 2.6.0 
linter-lesshint 3.0.1 
linter-protocol-buffer 0.2.0 
linter-python 3.1.1 
linter-spell-html 0.6.1 
linter-ui-default 1.2.2 
linter-write-good 0.9.0 
make-runner-panel 1.7.0 
minimap 4.27.0 
minimap-pigments 0.2.2 
nav-panel 0.0.11 
navigation-history 0.1.8 
nms-color-bracket 0.1.0 
output-panel 0.1.4 
pigments 0.39.1 
polymorph 2.1.4 
prettier-atom 0.26.0 
python-debugger 0.2.0 
python-tools 0.6.9 
rectangle-selection 0.2.0 
sort-lines 0.14.0 
split-selection-into-cursors 0.2.0 
Sublime-Style-Column-Selection 1.7.4 
switch-header-source 0.22.0 
symbol-gen 1.3.1 
symbols-list 2.4.0 
symbols-tree-view 0.14.0 
tab-pair-header-source 0.3.3 
terminal-fusion 2.4.4 
terminal-plus 0.14.5 
tree-sitter-syntax 0.0.0 
tree-view-git-status 1.3.1 

Tab too small, only file extension

Copied from issue 1

It could be my theme, but I'm noticing that the tabs are far too small. They aren't big enough for the .spec.js (perhaps because you hard-coded the width of the tab to accomodate for 1 or 2 letter file extensions?)

Do the tabs resize to fit their text or do the change size to hard-coded dimensions? Also note the fading effect (which could just be my theme not playing nicely).

This is my theme settings:

Uncaught SyntaxError: Invalid regular expression: /^(. ?)(?:\/(?:src|test\/unit)\/)(. ?)(?:\.js|\...

While typing in a new regex string for advanced mode, the editor will throw an error if the Regex is invalid. I don't know how much control you have over the settings UI but it would be nice if you could catch the error and instead make the input text red or something and show a message below saying that the regex is invalid until it becomes valid again.

Atom Version: 1.11.1
Electron Version: 0.37.8
System: Mac OS X 10.11.6
Thrown From: tab-pair-header-source package, v0.3.0

Stack Trace

Uncaught SyntaxError: Invalid regular expression: /^(. ?)(?:/(?:src|test/unit)/)(. ?)(?:.js|.spec.jsa/: \ at end of pattern

At /Users/dsofer/.atom/packages/tab-pair-header-source/lib/tab-pair-header-source.js:91

SyntaxError: Invalid regular expression: /^(. ?)(?:\/(?:src|test\/unit)\/)(. ?)(?:\.js|\.spec\.jsa\/: \ at end of pattern
    at RegExp (native)
    at Object.updateConfig (/Users/dsofer/.atom/packages/tab-pair-header-source/lib/tab-pair-header-source.js:91:31)
    at /Users/dsofer/.atom/packages/tab-pair-header-source/lib/tab-pair-header-source.js:57:86
    at /Applications/Atom.app/Contents/Resources/app.asar/src/config.js:618:16
    at /Applications/Atom.app/Contents/Resources/app.asar/src/config.js:635:20
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at Config.module.exports.Config.emitChangeEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:827:29)
    at Config.module.exports.Config.setRawValue (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:612:19)
    at Config.module.exports.Config.set (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:227:14)
    at SettingsPanel.module.exports.SettingsPanel.set (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/settings-panel.js:196:28)
    at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/settings-panel.js:254:26
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1427:25

Commands

  2x -3:33 core:backspace (atom-text-editor#tab-pair-header-source.advancedMode.matchRegExp.editor.mini.is-focused)
  2x -1:14.5.0 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)
  2x -0:42.3.0 core:backspace (atom-text-editor#tab-pair-header-source.advancedMode.matchRegExp.editor.mini.is-focused)

Group tabs together based on path rules

This package is cool in concept and doesn't have to be limited to just C type projects.

If there was some sort of regex expression or conditional rules that I could specify to group tabs together, this would be really cool. Hopefully with the option of having tokens that represent the filename, extension and path.

For instance, it'd be cool if we could automatically group these situations together:

// Grouping by filename (in same folder)
module/
  projects/
    projects.html
    projects.js
    projects.css
// becomes:
// [ projects.html | .js | .css ]
// [ .html | projects.js | .js ]

// Grouping by folder path
component1/
  feature1/
     a.js
     b.js
     c.js
  feature2/
     a.js
     b.js
     c.js
component2/
  feature1/
     a.js
     b.js
     c.js
// becomes:
// [ component1/feature1/a.js | b.js | c.js ]
// [ a.js | component1/feature2/b.js | c.js ]

// Grouping src and tests
src/
  app/
    plugins/
      feature1.js
      feature1.spec.js
// becomes:
// [ feature1.js | .spec.js ]
// [ feature1.spec.js | .js ]

// Grouping src and tests (across trees)
src/
  app/
    plugins/
      feature1.js
test/
  app/
    plugins/
      feature1.spec.js
// becomes:
// [ src/../feature1.js | test/.. ]
// [ src/.. | test/../feature1.spec.js ]

You would use the duplicate information as the primary label for the group, and the discrepencies would be how you specify each tab in the group