vantage-sh/helm-charts

Helm chart for deploying the Vantage Kubernetes Agent.

helm-charts's Issues

Vantage Agent is crashing

I did installed the vantage agent using helm. But I don't know it's crashing. You can see the logs in the SS.

nodeSelector missing

nodeSelector: {} from the values.yaml has no effect on the statefulset.

Please fix.

agent.nodeAddressTypes value should have default explicitly in values.yaml.

helm-charts/charts/vantage-kubernetes-agent/values.yaml

Line 28 in 2097e02

nodeAddressTypes: ""

It's typically, a helm convention to have the defaults be explicitly placed into the vaules.yaml.

I could easily have made this a PR, but I wanted to open a discussion about what should be the default, since this is a new type of integration.

It seems that Hostname is the implied default. I've have mixed success with this.

• Didn't work in my GKE clusters
• Inconsistently worked in my EKS clusters.
  • Not a regional thing.
  • All had the same Corefile
  • Some had the EC2 domain suffix in /etc/resolv.conf ; some didn't. One host worked without the domain suffix in /etc/resolv/conf.

I seem to have success with the value set to InternalIP across my entire multi-region, multi-cloud (EKS, GKE) fleet. IMO, this should work universally and that's my reason for lobbying for it as the default. I've set it my values.yaml for my parent chart, so I'm good. But I just wanted to see if this proposed change would help others.

I don't think it would affect any clusters with a service mesh or HTTP(S) proxy involved.

Thanks!

pod crashing every now and then

We have multiple clusters, all running the vantage agent. Every now and then a pod on any of them crashes. The helm deployment needs to be destroyed and recreated to fix this issue. We are now missing a week of data for some clusters.

{"time":"2023-12-30T11:30:17.665406711Z","level":"INFO","msg":"restoring pod data from backup"}                                                                                                                       
{"time":"2023-12-30T11:30:18.469158454Z","level":"ERROR","msg":"failed to setup data store","err":"unexpected EOF"}

How can we solve this issue?

- persistS3.bucket: Invalid type. Expected: null, given: string

schema is misleading
there's no env option so it's impossible to use this chart as is with persistS3

    error: values don't meet the specifications of the schema(s) in the following chart(s):
    vantage-kubernetes-agent:
    - persistS3.bucket: Invalid type. Expected: null, given: string