vasishtashastry / sara Goto Github PK
View Code? Open in Web Editor NEWSARA - Single Alien Registry App
SARA - Single Alien Registry App
The Alien
and ExportAlienDetails
classes are both handling console input. This is not so good in two ways -
Generally the convention is to use class names as the name of the file too. Eg., a class Person
should be in a file called person.py
I saw that the convert
method in the plugin classes is an instance method. But the methods in InputHandler
are class methods. I would like to know what is the rationale behind choosing between making something an instance method and making it a class method.
I had a feeling that there are far too many comments than acceptable. The code should be readable enough so that comments are not required :)
While I agree that adding new formats is as easy as adding a line of code, with a language like Python, even that is unnecessary :)
I see that FORMATS_AVAILABLE is a global variable. As a good practice using global variables should be avoided. Why can't fetch_plugins
return the formats?
The Conversions
class is dependent on the Alien
class. Let's say we want to add another attribute to the aliens - Number of hands (I know this is getting funnier ๐). This should ideally require changes in one place only (the Alien
class). But currently even the Conversions
class requires changing.
This is a low priority issue, but I would appreciate it if this is taken care of as well :)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.