Giter Site home page Giter Site logo

Comments (5)

vasturiano avatar vasturiano commented on August 22, 2024

@marconett thanks for reaching out.

This certainly looks related to the color space used inside ThreeJS. It's typical of color mismatches with values in the middle (between 00 and FF), as the transfer function changes.

https://threejs.org/docs/#manual/en/introduction/Color-management

However, I cannot reproduce your case with the latest version of both this lib and ThreeJS itself.
I know ThreeJS has changed their internal color space logic a few versions back, which prompts me to ask which version of ThreeJS are you using, as this may play a factor.

from three-globe.

marconett avatar marconett commented on August 22, 2024

My project is currently on three 0.150.1

from three-globe.

vasturiano avatar vasturiano commented on August 22, 2024

@marconett that would be the reason why then. In a following version the color spaces were updated. 153 if I'm not mistaken.

mrdoob/three.js#26162

from three-globe.

marconett avatar marconett commented on August 22, 2024

Thanks! For now I'm going to release with the older version but will keep in mind updating threejs later on.

I'd suggest updating the threejs peer dependency version.

from three-globe.

vasturiano avatar vasturiano commented on August 22, 2024

@marconett yeah I thought about updating the peer dep version. But the fact is that the lib is actually fully compatible with older versions of ThreeJS, so it seemed to me it would be overly restrictive to do so. These are internal changes to the ThreeJS behaviour, which I would rather assume consumers are aware of.

But thanks for the good suggestion in any case. πŸ‘

from three-globe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.