vazkiimods/musketeer

The Experimental "Vanilla Minus" Minecraft Modpack

musketeer's Issues

"We Can't Go Deeper" advancement is unobtainable

Despite the description, the "We Can't Go Deeper" advancement actually does require the user to enter the nether.

To replicate, first build a nether portal and observe the advancement is not given when the portal is "lit" and the frame fills with netherrack.

To receive the advancement, one can teleport to the nether with the command /execute in minecraft:the_nether run tp @s ~ ~ ~

Modpack version:
1.0.4

Smooth stone stairs break slowly. They have no tool assigned.

Smooth stone stairs break slower than expected and can drop without using a pickaxe.

Storage Vaults can go inside Bundles

Versions

Minecraft: 1.19.2
Forge: 43.3.2
Quark: 3.4-418
Musketeer 1.0.3

Issues

Storage Vaults can be put inside of Bundles, and the vault takes 1/64 slots. This can be used to store a ludicrous amount of items inside of bundles.

Box information that should not be displayed

The Stained Shulker Box is displayed in Info, even if them have been disabled. In Musketeer 1.0.3.

Sheild functions on minimum durability

The shield works when on the final durability and is prevented from breaking, making it effectively have infinite durability.

Steps to reproduce:

1. Obtain shield.
2. Wear down durability until it displays that it is broken.
3. Observe that it still blocks attacks.

Iron EMI Usage typo

Hello, I just found a small typo in the EMI usage of Iron. It says "Iron Golems no longer drop Iron Ingots, try Toretoises instaed". That's all.

Great modpack btw

Supplementaries ash still appears despite being disabled in EMI

Description: Basically what title states.

Steps for reproduction:

1. Get any type of log & flint and steel
2. Place the log and ignite
3. Log should turn into an ash pile

Additional comments:
The supplementaries-common config had ash_from_fire still enabled. Disabling it fixes this issue

Musketeer client joining server critical error

Versions

Minecraft: 1.19.2
Forge: 43.3.2
Musketeer 1.0.4

Issue

I updated my Musketeer client and server from 1.0.3 to 1.0.4 using PrismLauncher.
Upon joining my own server, it says my client and server has a mod mismatch.
Windswept is version 2.2.2 on the server, but 2.2.3 on my client.
Changing either the client or server mod to match versions produces the same error.

This error log is from me changing my client's Windswept version to 2.2.2.

https://gist.github.com/GameGuruGreenGryphon/961a27fa7a7a0c711a3569c1c65c6500

Map markers are not available on the map atlas

Versions
Minecraft: 1.19.2
Forge: 43.3.2
Musketeer 1.0.3

Issues
When exiting and re-entering the world, existing map markers in the atlas will not be visible and new markers cannot be added to the atlas.
Sometimes the map was completely invisible in the atlas.

Windswept roses cannot be bone mealed into respective rose bushes

Versions

Minecraft: 1.19.2
Forge: 43.3.2
Quark: 3.4-418
This is the Musketeer modpack, I can't tell which version

Issues

All info pages on rose bushes and roses from the Windswept mod state that rose bushes can be obtained using bone meal on their respective rose, but this results in another rose being grown.

"101" no longer shows items with EMI Info

As the title suggests, the "101" search feature is no longer functional as of now, here is a screenshot of it in action:

Thank you and sorry to bother with more issues

Enchantments aren't preserved on broken tools

If a tool reaches broken durability and has enchants, trying to repair it (e.g. on an anvil) wipes the enchants. This makes the whole tools-don't-break thing a bit pointless.

Slice map becomes regular map after clearing, and Campfire not clearing map

(Pack version: 1.0.4, no other additions)
I was able to clear one slice map using a campfire, but subsequent attempts to clear maps only results in the campfire being marked. Neither right clicking nor shift+right clicking work. Breaking and replacing the campfire also didn't solve it, nor did breaking and replacing the hay bale underneath (both with another hay bale or with another block). Additionally, clearing the slice map resulted in it being turned into a regular map.
Sorry if these should be two separate issues but I don't know if one caused the other or if they're related at all.
I've attached a video showing the issue (the second map was previously a slice map for reference) -

musketeermapsnotclearing.mp4

multiplayer is broken

pastebin of errors https://pastebin.com/vtyDbRRF

Release Modpack on Modrinth

Hi!
Is there any way this modpack could be published on Modrinth? Many people nowadays prefer Modrinth over Curse.

Durability of Fishing Rod, Shears, and Flint and Steel not increased

Versions

Minecraft: 1.19.2
Forge: 43.3.2
Quark: 3.4-418
This is the Musketeer modpack, I can't tell which version

Issues

The basic tools, such as pickaxes and swords got a durability increase in this modpack (Iron 250 -> 515, Diamond 1561 -> 2048)
The Fishing Rod, Shears, and Flint and Steel did not get durability increases.
Fishing Rod has 64 durability, whereas on Bedrock edition it has 384 durability
Flint and Steel has 64 durability
Shears has 384 durability

Also, I have no clue why only 1/3rd of these can be enchanted... They're all useful tools

Ancient City Loot Table Improvement

Currently, the Ancient City Loot Table:

• Doesn't have Ancient Saplings, making them impossible to obtain
• The only Netherite (ancient) items in the loot table are the hoe and leggings, making them seem to be very common and makes it not very worth it to loot ancient cities.

Additionally, making Ancient Debris part of the Ancient City Loot table makes it so that one player can't steal all the ancient debris in an area

Here's the loot table with ancient saplings and all netherite tools added, uploading as a txt because github doesn't allow me to upload json files directly. Ancient sapling weight is same as in quark normally, netherite tools same as the netherite hoe. Netherite armour not added. The Ancient Debris change also isn't in this file as I was unsure of what weight and count to put
ancient_city.txt

Suggestion: Buff Horse breeding more

In the promo image for the pack, it is claimed that horse breeding receives a "huge buff". However, the actual buff is quite tame in game. Horse Stonks, the mod that modifies horse breeding behavior, simply prevents a stat from being reduced below the worse parent. For example, breeding a 0.2 and 0.23 speed horse will never result in a horse slower than 0.2. It does this by first running the vanilla horse breeding code, then imposing the lower bound.

This does not fix the biggest issue with vanilla horse breeding, which is the third random horse that makes all breeding attempts tend towards the average horse. This issue was fixed in vanilla in 1.19.4, but obviously does not impact the modpack in 1.192.

As it stands in the Musketeer modpack, it's easy to get a horse that is similar to the ones you already have, but it is still just as difficult as in vanilla to improve the horse. For an example, if you are breeding a 0.3 speed and a 0.31 speed, in vanilla you are very likely to get a useless 0.27 speed horse. That horse would become a 0.3 speed horse in Musketeer, which is still just as useless because you already have a better 0.31 speed horse. In either case, the newly bred horse would be useless.

I propose a backport of the vanilla breeding behavior implemented in 1.19.4, or otherwise buffing horse breeding so that one can consistently improve the stats of their horse without hundreds of breeding attempts.

Glass item frame is unobtainable

As glass panes are unobtainable as an item, so are glass item frames. Recipe should be altered to use glass blocks, potentially with a reduction in cost.

VazkiiMods/Quark#4401

forge:rope tag contains only two items, one of which is diabled. This tag is used in one recipe.

The forge:rope tag is useless, as it only contains two items and one of them is disabled. The tag is used in the recipe for Rope and Nail from Comforts. This causes confusion, especially because the image for the forge:rope tag is the unused quark Rope Coil.

Cannot create Hardcore world

When creating a Hardcore world, it just creates a normal world upon entering the world.

EMI lying about how Netherite equipment can only be repaired with Netherite

Versions

Minecraft: 1.19.2
Forge: 43.3.2
Quark: 3.4-418
This is the Musketeer modpack, I can't tell which version

Issues

EMI states that the Netherite equipment can only be repaired with Netherite ingots, contrary to Quark's Diamond Repair setting being set to true.

However, actually trying to repair it with a Netherite ingot does not work, and can only repaired with a diamond.