Giter Site home page Giter Site logo

charset's People

Contributors

asiekierka avatar bence98 avatar blaytheninth avatar girafistudios avatar palaster avatar rubensworks avatar soniex2 avatar vazkii avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

charset's Issues

Some redstone gates don't work

Neither the RS Latch nor the Pulse Generator seem to work at all. On the Pulse Generator, when I toggle the input, the torches on it change, but the output never comes on. On the RS Latch, it seems to be impossible to toggle the outputs.

Software versions:
Minecraft 1.10.2
Forge 12.18.1.2026
MCMultiPart 1.2.0
Charset 0.3.0-pre12
No other mods

JEI search usability

This isn't a bug, but it is an issue. JEI doesn't have mod search drop downs like NEI, so you have to rely on typing. This makes it difficult to search for charset specif items since some of the mod names to look up use non-standard characters.

In other words, it would be much more user friendly if a simple "@charset" type thing would work to search up this mods items.

[Suggestion] Double door operation for Forestry doors

Hi,

I hope this is the right place. Is Charset the mod in FTB Unstable responsible for double door operations with vanilla doors?

If so, it would be great if the operation could be extended to include Forestry doors in addition to vanilla doors.

Thanks!

Redstone cable doesn't update

Used in combination with Extra Utilities 2 scanner blocks, the cable will not update based on the scanner output, only when placed. This may apply to other things besides the scanner, but it's where I noticed it.

Possibly related to #23

edit: To clarify, my setup was this: Scanner with a dirt block below it with a single dot of wire on the side. The dot is correctly on/off when placed, but once the scanner changes, the dot doesn't. When directly on the scanner, it does change.

So now that I think about it, this might be an EU2 issue.

[1.10.2] Backpack Render Broken on other players in SMP

Just a visual glitch - I'm not sure what causes it, but at any time (there's no event that triggers it), backpacks render flying all over the place on other players on servers.

It's been a bug since 1.8.9, but I'm not sure what's up - maybe there's some packet info that needs to be added so that the player's pos and yaw are sent to other players via the server, so that way other clients know how to render it?

Not at all a critical bug, just something that I know BetterStorage never had an issue with.

x-mod rendering issue with double doors

Issue: With just Charset and Malisis Doors installed, the doors open but won't close again (despite playing the sound).

Background:
I recently logged a conflict between Quark and Malisis Doors that was affecting the rendering of vanilla double doors. VazkiiMods/Quark#217 The solution implemented was to disable the double-door functionality in Quark if Malisis Doors is present.

It would appear that Charset also implements double-door functionality but possibly in a slightly different way. With just Quark (prior to the issue 217 change) and Malisis doors loaded, the open/close would function but not render, leaving a pair of doors that were visually open, regardless of their actual open or closed state.

With just Charset and Malisis installed, the doors open but won't close again (despite playing the sound). That is, once open, they're permanently open.

Desired outcome:
I have tested all three mods by themselves (plus Forestry) and found that only Quark provides double-door functionality for non-vanilla doors, such as those provided by Forestry. I would appreciate it if changes could be made where necessary to preserve the double-door functionality of Quark even if other mods are present that might conflict over vanilla doors.

Cheers!

charset-0.3.0-pre15
malisiscore-1.10.2-4.2.7
malisisdoors-1.10.2-5.1.4

Making the RS Latch Great Again.

I have been trying to think of a way to fix the RS Latch, but I have come to a standstill. My first issue being that the RS Latch here isn't a true RS Latch to begin with. A true RS Latch should have 3 inputs and a output. One input being Q, another being R, and a third being S. The output being Q'. And then depending on Q, R, and S. Q' will change based on the table below. So my solution is just to convert this RS Latch to a true RS Latch.

RS Latch Truth Table :
image

Also my knowledge of a RS Latch is not from Minecraft, but from Computer Engineering, so if the Minecraft redstone versions of a RS Latch is different. Then disregard this entire issue.

My pull request, #19, is based on this idea.

Backpack turns Chestplate slot texture into Leggings slot texture

ItemBackpack replaces the chestplate slot in onUpdate: https://github.com/Vazkii/Charset/blob/1.10/src/main/java/pl/asie/charset/storage/backpack/ItemBackpack.java#L90

The SlotBackpack has an incorrect slot texture though: https://github.com/Vazkii/Charset/blob/1.10/src/main/java/pl/asie/charset/storage/backpack/SlotBackpack.java#L61

ItemArmor.EMPTY_SLOT_NAMES[1] is "minecraft:items/empty_armor_slot_leggings", not "minecraft:items/empty_armor_slot_chestplate". Needs to be ItemArmor.EMPTY_SLOT_NAMES[2].

See MinecraftForge/MinecraftForge#3102

Languages

Charset can't be translated at the moment since you rely on the original Charset language repo. I'd recommend merging it with this repo; separating code and language repos is, in my unprofessional opinion, an overrated fad that doesn't do much more then complicate things.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.