vetlewi/tdr2tree

Tool for converting TDR files to ROOT trees

tdr2tree's Issues

New bug

There is a very subtle bug here:

TDR2tree/Containers/Event.cpp

Lines 448 to 455 in 3fe0410

	for (i = 0 ; i < raw_data.size() ; ++i){
	std::vector<word_t> event;
	for (j = i ; j < raw_data.size() - 1 ; ++j){
	timediff = abs(raw_data[j + 1].timestamp - raw_data[j].timestamp);
	event.push_back(raw_data[j]);
	if (timediff > coins_time) {
	i = j + 1;
	break;

As we update the variable i=j+1 in line 454 and then break, we finish the iteration of the outer loop and i is again updated. Then we start the next iteration of the outer loop and i is now equal to j+2, but in reality it should be j+1.

The fix will be to change i=j+1 in line 454 to i=j.