viabtc/viabtc_mining_server

A high-performance distributed Bitcoin mining pool server.

viabtc_mining_server's Issues

Disclosure: bitpeer module and SPV mining implementation vulnerable to DoS attacks

Improper Input Validation in the SPV mining module of the ViaBTC mining server allows a remote attacker to waste the pools hashrate by letting it mine on an old block (i.e. DoS) by sending a modified, old block via the P2P network.

The process_block() function only checks the blocks proof-of-work, but does not check that the header's merkle-tree root matches the transactions in the block. This allows modifications to the transactions in the block. As the BIP-34 coinbase height is used to determine if the block is new, and the coinbase height can be trivially changed, the pool can be tricked into SPV mining on an old block. This is essentially a DoS. If sustained and undetected, this might result in substantial financial loss for the pool operator.

To anyone that's using this pool software: I'd recommend to not use the bitpeer module (as it's half-broken anyway: https://b10c.me/observations/10-viabtc-blocks-without-witness-data/), and generally, to consider using maintained and up-to-date pool software.

More details about the vulnerability can be found here: https://b10c.me/blog/012-viabtc-spv-vulnerability-disclosure/

requirements details cannot be opened in [Compile and Install]

Thanks open source for such a great project.

Could you describe the installation more detail?

I can not open the requirements link as the follow in README:

See requirements. Install the mentioned system or library.

安装部署配置

大神，能出一个详细的部署安装文档吗？看了下Compile and Install模块，不知如何下手。不胜感激

Empty job with out nbits

The bitpeer and poolbench modules, After finding a new block, do not update nbits when initializing empty job, could there be a problem here?

viabtc_mining_server/jobmaster/jm_job.c

Lines 1272 to 1276 in 4891c9c

	if (nbits) {
	outer.nbits = nbits;
	} else {
	outer.nbits = curr_job->nbits;
	}

If the new block require a change in nbits.

Ourev

Missing http server

Hi,

I am trying to setup this pool server for my home miner and I can't manage to get it working. I am missing "blockmaster_url": "http://127.0.0.1/blockmaster".

Is it jsonrpc exposed from bitcoind?

bitcoin-cli help
== Blockchain ==

Or maybe a service I did not find in this project?

Thank you and I hope you can help with this.

Is there detailed installation instruction?

Is there detailed deployment and installation document? I don't know how to start.
thanks

BITCOIN CASH

Will this pool work with BCH?