Devise’s authenticate block breaks previews

[nicieja]

Devise’s authenticate block breaks previews

[allmarkedup]

(@nicieja as an aside, Changepack looks very interesting! I'm keen to dig in a bit more when I get a chance 😊)

[nicieja]

@allmarkedup Didn’t look at GitHub yesterday but I can confirm that the fix works for me too. Thanks!

(as an aside, Changepack looks very interesting! I'm keen to dig in a bit more when I get a chance 😊)

Glad you like it! 🙏

[guillaumebriday-pa]

I got the exact same issue

[allmarkedup]

@nicieja thanks for bringing this to my attention - I don't use Devise personally so I haven't run into this before, but I can replicate it with the repo you provided so just looking into it now. Will hopefully have a fix up soon 👍

[allmarkedup]

Hey @nicieja @guillaumebriday-pa - I believe I have a fix for this now in PR #450.

It works for me in the changepack/changepack app now but it would be great to get confirmation if you have a chance to give it a try by bundling Lookbook from the devise-preview-fix branch.

It is a bit of a hack to be honest - the issue you are seeing is actually being caused by a workaround for another bug. But if this works for now then I'll ship it for now and hopefully spend a bit of time on unpicking the actual root cause of the problem when I have a little more time.

I'm going to go a little more testing but once I'm happy (and unless I hear back that it is still causing issues for either of you) I'll merge it in and get it out in the next release (which will be v1.0.1).

[guillaumebriday-pa]

The fix actually works for me as well!

Thank you for your reactivity! 🙏

[allmarkedup]

@guillaumebriday-pa great, thanks for letting me know - I'll merge that in now 👍

[guillaumebriday-pa]

Awesome 🙏 , can you release the 2.0.1?

[allmarkedup]

@guillaumebriday-pa @nicieja 2.0.1 is now out that includes the fix for this. Thanks for your help!