Comments (4)
Ah thank you @DRBragg, very kind :-) I hope to be able to take you up on that offer at some point!
from lookbook.
Hey @DRBragg! Good to hear from you, apologies for the slow reply but I'm currently moving house at the moment and things are all a bit hectic...
I'm super glad that you are on the path to upgrading to Lookbook v2 - mostly to help assuage my guilt that I haven't found time to work on the older-Rails compatibility PR or your other bug report (even though it's still the bug report ever).
Looks like you've updgraded to Rails 6.1 now - I'm assuming that was quite the large job?! Congratulations anyway :-)
I'm not quite sure why you are seeing this behaviour but it might well be a classic autoloader vs Zeitwerk thing, that would make sense. Regardless, I've just fixed it on main
and will get another release out with this included shortly.
I've been through the app and I can't see anywhere else obvious where a similar namespacing issue might occur but please do let me know if you run into anything else.
from lookbook.
@DRBragg I've just release v2.0.4 with the fix for this so I'll close this down now, but any other issues just let me know. Thanks again for the bug report and all the detail in there too!
from lookbook.
Thanks @allmarkedup! You rock. If I ever make it to Brighton, or you come to the US I owe you a beer.
from lookbook.
Related Issues (20)
- Why does the preview filter ignore the path/folder structure? HOT 4
- Add the ability to hide a nested within a group. HOT 3
- Cannot choose display options in an embedded preview HOT 4
- Support better errors / web console instead of rescuing errors in Lookbook HOT 2
- undefined method `strftime' for nil:NilClass with nil datetime HOT 1
- Hidden scenarios within groups are not accessible via their URL
- Swap the order of Previews and Pages sections HOT 4
- Ability to search within pages section HOT 3
- X-Frame-Options always set to deny HOT 8
- Can't draw templates that require instance variables HOT 5
- Lookbook overrides ViewComponent `show_previews` config depending on load order HOT 3
- ActionView::Template::Error occurs when trying to render a template file with a partial HOT 5
- FEA: Support for Mailer Previews HOT 1
- Support configurable frame ancestors for embeds HOT 2
- Documentation request: mention support for Phlex in the README HOT 5
- Previews not rendering nested components HOT 2
- Better integration with Phlex HOT 1
- Version requirement for listen gem is not specified, and wrong version error is suppressed HOT 1
- Syntax error reporting in Lookbook HOT 2
- Sharing View Component Previews Across Multiple Projects Without Duplicating Files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lookbook.