Giter Site home page Giter Site logo

Comments (4)

allmarkedup avatar allmarkedup commented on May 25, 2024 1

Ah thank you @DRBragg, very kind :-) I hope to be able to take you up on that offer at some point!

from lookbook.

allmarkedup avatar allmarkedup commented on May 25, 2024

Hey @DRBragg! Good to hear from you, apologies for the slow reply but I'm currently moving house at the moment and things are all a bit hectic...

I'm super glad that you are on the path to upgrading to Lookbook v2 - mostly to help assuage my guilt that I haven't found time to work on the older-Rails compatibility PR or your other bug report (even though it's still the bug report ever).

Looks like you've updgraded to Rails 6.1 now - I'm assuming that was quite the large job?! Congratulations anyway :-)

I'm not quite sure why you are seeing this behaviour but it might well be a classic autoloader vs Zeitwerk thing, that would make sense. Regardless, I've just fixed it on main and will get another release out with this included shortly.

I've been through the app and I can't see anywhere else obvious where a similar namespacing issue might occur but please do let me know if you run into anything else.

from lookbook.

allmarkedup avatar allmarkedup commented on May 25, 2024

@DRBragg I've just release v2.0.4 with the fix for this so I'll close this down now, but any other issues just let me know. Thanks again for the bug report and all the detail in there too!

from lookbook.

DRBragg avatar DRBragg commented on May 25, 2024

Thanks @allmarkedup! You rock. If I ever make it to Brighton, or you come to the US I owe you a beer.

from lookbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.