Comments (5)
allmarkedup
commented on May 12, 2024
@Spone is this in v0.4.1? I can't replicate this myself at the moment so just wanted to double check. Are you using a custom preview controller as well as a custom layout?
I did make some changes in 0.4.1 to help make grouped layouts more robust (and there are a few tests around it now) but I'll try to dig into it a bit more.
from lookbook.
Spone
commented on May 12, 2024
Sorry I did not mention the version. I had the bug in 0.4.0.beta.2 and it's still there with 0.4.1.
I'm not using a custom preview controller.
from lookbook.
allmarkedup
commented on May 12, 2024
Ok thanks! I think I've tracked down the issue. Could you see if the fix on the group-layout-fix branch solves the problem for you? If so I'll push up a new release with it in.
gem 'lookbook', git: 'git://github.com/allmarkedup/lookbook.git', branch: 'group-layout-fix'
from lookbook.
Spone
commented on May 12, 2024
Yes it does! Thanks a lot ❤️
from lookbook.
allmarkedup
commented on May 12, 2024
Excellent! Will get a patch release out now, thank you :-)
from lookbook.
Related Issues (20)
- Why does the preview filter ignore the path/folder structure? HOT 4
- Add the ability to hide a nested within a group. HOT 3
- Cannot choose display options in an embedded preview HOT 4
- Support better errors / web console instead of rescuing errors in Lookbook HOT 2
- undefined method `strftime' for nil:NilClass with nil datetime HOT 1
- Hidden scenarios within groups are not accessible via their URL
- Swap the order of Previews and Pages sections HOT 4
- Ability to search within pages section HOT 3
- X-Frame-Options always set to deny HOT 8
- Can't draw templates that require instance variables HOT 5
- Lookbook overrides ViewComponent `show_previews` config depending on load order HOT 3
- ActionView::Template::Error occurs when trying to render a template file with a partial HOT 5
- FEA: Support for Mailer Previews HOT 1
- Support configurable frame ancestors for embeds HOT 2
- Documentation request: mention support for Phlex in the README HOT 5
- Previews not rendering nested components HOT 2
- Better integration with Phlex HOT 1
- Version requirement for listen gem is not specified, and wrong version error is suppressed HOT 1
- Syntax error reporting in Lookbook HOT 2
- Sharing View Component Previews Across Multiple Projects Without Duplicating Files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lookbook.