viki-org/dnscache

A DNS Cache for Go

dnscache's Issues

FetchString undefined.

Hello, I find that there is a mistake in your Readme
.

dnscache.FetchString undefined. Maybe dnscache.FetchOneString ?

Suggested to random ip in FetchOne.

Hello. I think your FetchOne function always return the first ip in cache is not perfect.Because we can use dns to do some load-balance.

So, i think you can random your ip in return. Or create another function to return a random Ip.

Improvement: allow to use custom LookupIP function

Sometimes we need to use other LookupIP() func then default net.LookupIP() func. This is typical, when we need to use custom DNS resolver - e.g. hashicorps consul, etc.
It should be very helpfull to be able to setup cutom function here

func (r *Resolver) Lookup(address string) ([]net.IP, error) {
  ips, err := net.LookupIP(address)

IP6 isn't quoted correctly

I'm running into errors using the default cache like listed in the readme. Might just need https://godoc.org/net#JoinHostPort to be used correctly.

Get http://www.appforpcshub.com: dial tcp: too many colons in address 2400:cb00:2048:1::681b:963a:80

Correct way to set timeouts for net.Dialer?

client := &http.Client{
	Transport: &http.Transport{
		Dial: (&net.Dialer{
			Timeout:   20 * time.Second,
			KeepAlive: 20 * time.Second,
		}).Dial,
		TLSHandshakeTimeout:   10 * time.Second,
	},
	Timeout: 30 * time.Second,
}

How can I set these timeouts using the DNS cache example?

client := &http.Client{
	Transport: &http.Transport {
	  MaxIdleConnsPerHost: 64,
	  Dial: func(network string, address string) (net.Conn, error) {
	    separator := strings.LastIndex(address, ":")
	    ip, _ := dnscache.FetchString(address[:separator])
	    return net.Dial("tcp", ip + address[separator:])
	  },
	  TLSHandshakeTimeout:   10 * time.Second,
	}
	Timeout: 30 * time.Second,
}

Do I need to create my own Dailer so I can set properties net.Dailer has?

type Dialer struct {
	net.Dialer
}

func (d *Dailer) Dial(network string, address string) (net.Conn, error) {
	separator := strings.LastIndex(address, ":")
	ip, _ := dnscache.FetchString(address[:separator])
	return net.Dial("tcp", ip + address[separator:])
}