vilya/miniply

A fast and easy-to-use PLY parsing library in a single c++11 header and cpp file

miniply's Issues

Bug in convert_list_fo_fixed_size

Line 651 of convert_list_to_fixed_size should have nameBufSize as the second arg of snprintf, in place of the present sizeof(nameBuf) [which is sizeof(char *)].

PLYReader::find_color - support for 'red' 'green' and 'blue' as well as 'r', 'g', and 'b'?

Just doing some work with some LIDAR files, and by default they seem to have 'red', 'green' and 'blue' as the property names for colour rather than 'r', 'g', and 'b'.

I'm not really sure if this is an issue with the scanning software or not, but would it be possible to get an alternative function here, or to make the base find_color more robust? I've added the following to my own code, which works fine.

bool PLYReader::find_color_full_names(uint32_t propIdxs[3]) const
  {
    return find_properties(propIdxs, 3, "red", "green", "blue");
  }

Cheers,

-Ed

Slower on mac OS

Could be that it is slower on macos?
I run same simple read and it jumps from 23~ms to 125ms

the pc computing power, is relativly similar, i would expect jump of +-10 to 20 ms or am i doing something wrong?

find_indices() returns kInvalidIndex when file contains `vertex_index` instead of `vertex_indices`

This issue is similar to the following:

PointCloudLibrary/pcl#968

miniply currently looks for the "vertex_indices" property, but some PLY files have this under "vertex_index" instead. This returns kInvalidIndex in propIdxs and results in a failure to parse.

bool PLYReader::find_indices(uint32_t propIdxs[1]) const
{
  return find_properties(propIdxs, 1, "vertex_indices");
}

http://paulbourke.net/dataformats/ply/ uses vertex_index in their examples, so it would be a good idea to check for both.

Bug in readme's example

The example code fix done in 48b37d4 is still missing from the readme documnt.

miniply - parse a memory buffer`

Current it requires a file handle and must read from disk. - so it's not very useful for parsing data transferred over a network - , can it also parse a memory buffer? -

Tristrips ?

Hi, very impressed with quality of code and performance, I have it working for basic meshes, and would like to know more about is how to support tristrips ?

From ply I have it's files with "element tristrips 1" but with vertex_indices with no fixed size (or to be deduced from vertex num ?

In current code I cannot get far as here "load_variable_size_element" fails because it thinks there is 1 row/count.
(https://github.com/cnr-isti-vclab/vcglib/blob/a8e87662b63ee9f4ded5d4699b28d74183040803/wrap/io_trimesh/import_ply.h#L869 )