vinted/actioncable-client-kotlin

Ruby WebSockets implementation (Action Cable) client library for Kotlin.

actioncable-client-kotlin's Issues

Support for headers like Sec-WebSocket-Protocol and Sec-WebSocket-Extensions

My ruby server's ActionCable requires this header. Will the library support them in the future?

Add webSocketFactory to Connection.Options

I see that it's possible to provide a preconfigured OkHttpClient via Connection.Options.okHttpClientFactory. However, I need to provide a dedicated OkHttp WebSocket.Factory. (Note an important detail: although OkHttpClient is open and implements WebSocket.Factory, calling newBuilder() means that it is not actually possible to override behaviour, see discussion here square/okhttp#6242).

This is an easy change I think, so I can make a PR. Just checking to see if someone is available to review it, since it's fairly quiet around here. Thanks!

Forbid to create channel with the same id

E.g. it is possible to add a channel with the same id more than single time:

val channel = Channel(channel = "foo", params = mapOf())
val subscription = consumer.subscriptions.create(channel)
val subscription2 = consumer.subscriptions.create(channel)

Investigation needed of having a check inside Subscriptions.create().

Please distribute sources as well

Config could be ported from: https://github.com/vinted/preferx/blob/master/prefeRx/build.gradle#L52-L67

Use builder for building options

Currently we can set options like that:

val uri = URI("ws://cable.example.com")

val options = Consumer.Options()
options.connection.reconnection = true

val consumer = ActionCable.createConsumer(uri, options)

We could change it to something like:

val uri = URI("ws://cable.example.com")

val options = Consumer.Options() 
                   .withReconnection(true)
                   .build()

val consumer = ActionCable.createConsumer(uri, options)

Benefits:

• Imutable options object
• More stable library ABI
• Cleaner options setup API

Add a possibility to clear all Consumer subscriptions

At the moment there is a possibility to remove single subscription:

consumer.subscriptions.remove(subscription)

Would be nice to have something like this:

consumer.clearAllSubscriptions()

Failed to resolve: com.vinted:actioncable-client-kotlin:0.5.4

Hello I'm getting this error, and can't use any of the classes, the same happens to me with the original project actioncable-client-java
I'm using
Android Gradle Plugin Version 7.0.4
Gradle Version 7.0.2

build.gradle(project)
buildscript {
repositories {
google()
mavenCentral()
maven { url "https://jitpack.io" }
}
dependencies {
classpath "com.android.tools.build:gradle:7.0.4"
classpath "com.google.android.libraries.mapsplatform.secrets-gradle-plugin:secrets-gradle-plugin:2.0.0"
classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10'

    // NOTE: Do not place your application dependencies here; they belong
    // in the individual module build.gradle files
}

}

task clean(type: Delete) {
delete rootProject.buildDir
}

Impossible to subscribe to the new channel after consumer.connect()

Currently supported way to subscribe to the channel:

val subscription = consumer.subscriptions.create(channel)
consumer.connect()

But subscription callbacks won't work in this scenario:

consumer.connect()
val subscription = consumer.subscriptions.create(channel)

Therefore, it is impossible to subscribe to the channel after initial web socket connection instantiation.

LinkedTreeMap instead of JsonObject

In my subscription.onReceived I am getting a LinkedTreeMap instead of JsonObject.

JCenter returning 400

Hi, can this library be migrated to mavencentral?