The vinyldns-java's discuss from vinyldns

create/get batch change has already been added (see https://github.com/vinyldns/vinyldns-java/tree/master/src/main/java/io/vinyldns/java/model/batch). We need to add some tests in https://github.com/vinyldns/vinyldns-java/blob/master/src/test/java/io/vinyldns/java/VinylDNSClientTest.java to create a basic batch change (make a batchChange with just one singleChange within it), get the batch change back and validate the fields.

Add ownerGroupId to BatchRecordChanges create method

In support of the new shared zones feature coming to VinylDNS we need to add the optional ownerGroupId field to the BatchRecordChanges create method. Refer to the VinylDNS documentation for more information.

API doc: https://www.vinyldns.io/api/create-batchchange.html

Example Request:

{
    "comments": "this is optional",
    "ownerGroupId": "f42385e4-5675-38c0-b42f-64105e743bfe"
    "changes": [
        {
            "inputName": "example.com.",
            "changeType": "Add",
            "type": "A",  
            "ttl": 3600, 
            "record": {
                "address": "1.1.1.1"
            } 
        }, 
        {
            "inputName": "192.0.2.195",
            "changeType": "Add",
            "type": "PTR", 
            "ttl": 3600,
            "record": {
                "ptrdname": "ptrdata.data."
            }
        }, 
        {
            "inputName": "cname.example.com.",
            "changeType": "DeleteRecordSet",
            "type": "CNAME"
        }, 
        {
            "inputName": "update.another.example.com.",
            "changeType": "DeleteRecordSet",
            "type": "AAAA"
        }, 
        {
            "inputName": "update.another.example.com.",
            "changeType": "Add",
            "type": "AAAA", 
            "ttl": 4000,
            "record": {
                "address": "1:2:3:4:5:6:7:8"
            }
        }
    ]
}

Additional Information

If no ownerGroupId is provided the attribute should not be included in the request.
we expect changes in CreateBatchRequest and BatchResponse (added ownerGroupId) at https://github.com/vinyldns/vinyldns-java/tree/master/src/main/java/io/vinyldns/java/model/batch
we do not currently have a batch change test - see #22 for that, there should be a test where we create a batch with an ownerGroupId, and then get the batch to validate the ownerGroupId was saved

Zone: List Zone Changes

https://www.vinyldns.io/api/list-zone-changes.html

Change groupId to `io.vinyldns`

Recently got our sonatype / maven central setup complete. We can only publish under the io.vinyldns groupId.

Change the pom to this.

Zone: Create Zone

https://www.vinyldns.io/api/create-zone.html

Note: Zone model will need to be updated to include an isTest flag.

Add support for batch changes

Batch changes allow users to submit multiple changes across zones.

The API documentation can be found here - https://www.vinyldns.io/api/batchchange-model.html

We dont print the error message for a VinylDNSFailureResponse

We use the parent VinylDNSResponse toString which does not include message body

Zone: Delete Zone

https://www.vinyldns.io/api/delete-zone.html

RecordSet: Get RecordSet Change

https://www.vinyldns.io/api/get-recordset-change.html

Add ownerGroupId to RecordSet update method

In support of the new shared zones feature coming to VinylDNS we need to add the optional ownerGroupId field to the RecordSet update method.

Example Request

{
  "id": "dd9c1120-0594-4e61-982e-8ddcbc8b2d21",
  "name": "already-exists",
  "type": "A",
  "ttl": 38400,
  "records": [
    {
      "address": "6.5.4.3"
    }
  ],
  "zoneId": "2467dc05-68eb-4498-a9d5-78d24bb0893c",
  "ownerGroupId": "f42385e4-5675-38c0-b42f-64105e743bfe"
}

Additional Information

See #45 for more info. Create blocks update as they both share the RecordSetBase changes

DeleteRecordSetSingleChange has improper recordType field

The field in the model is named typ, it must be type or else will not serialize correctly. So currently the client does not know record types of delete requests

I'd recommend looking at the PRs #42 (getGroup) and #38 (createGroup). Update group is very similar to create group, so should require a similar update.

Please also add an update group test:

create a group with email "[email protected]"
update the email to "[email protected]"
get the group, validate that email == "[email protected]"

Membership: Delete Group

https://www.vinyldns.io/api/delete-group.html

Remove unnecessary dependencies & update existing ones

According to this report, there are two vulnerable dependencies and several outdated once.

Also, the library has compile dependencies on Maven Plug-in API. There is zero evidence that any on the Java code uses Maven code:
https://github.com/search?q=repo%3Avinyldns%2Fvinyldns-java+%28maven+OR+plexus%29&type=code

It should be removed because it brings unnecessary transitive dependencies into any runtime use of the library.

It seems to have been brought in with the very first commit:
7f38e12

RecordSet: Get RecordSet

https://www.vinyldns.io/api/get-recordset.html

Setup in Travis CI

We use Travis CI for building and testing our main repo and tools.

Membership: List Group Activity

https://www.vinyldns.io/api/list-group-activity.html

ownerGroupId should be optional for record set operations

Currently, there is nothing that explicitly allows null for create+update record set. It is possible for owned zones for the ownerGroupId to be omitted.

Update the different models to allow for null for ownerGroupId

Zone: Update Zone

https://www.vinyldns.io/api/update-zone.html

Add RecordSet search support

Description

The VinylDNS API has been updated to include a new global recordset search endpoint at /recordsets. This client should be updated to support this new endpoint.

Add ownerGroupId to CreateRecordSet endpoint

In support of the new shared zones feature coming to VinylDNS we need to add the optional ownerGroupId field to the RecordSet create method.

Example Request:

{
  "name": "foo",
  "type": "A",
  "ttl": 300,
  "records": [
    {
      "address": "10.10.10.10"
    }
  ],
  "zoneId": "2467dc05-68eb-4498-a9d5-78d24bb0893c",
  "ownerGroupId": "f42385e4-5675-38c0-b42f-64105e743bfe"
}

See api docs at https://www.vinyldns.io/api/create-recordset.html

Expected Changes

Add ownerGroupId to the recordset model at https://github.com/vinyldns/vinyldns-java/blob/master/src/main/java/io/vinyldns/java/model/record/set/RecordSet.java#L42. Note this field can be null.
Update RecordSetBase to accept an ownerGroupId https://github.com/vinyldns/vinyldns-java/blob/master/src/main/java/io/vinyldns/java/model/record/set/RecordSetBase.java
Update CreateRecordSetRequest to accept ownerGroupId https://github.com/vinyldns/vinyldns-java/blob/master/src/main/java/io/vinyldns/java/model/record/set/CreateRecordSetRequest.java
add a createRecordset test that validates a create with a valid ownerGroupId passes. See https://github.com/vinyldns/vinyldns-java/blob/master/src/test/java/io/vinyldns/java/VinylDNSClientTest.java#L320 for an example. Note that the user must be in the group in order for the create to pass. Once created, get the recordset and validate that it has ownerGroupId = [id]. Note that you may need to add a mocked RecordSet for this (mocks are at the bottom of the test file, see https://github.com/vinyldns/vinyldns-java/blob/master/src/test/java/io/vinyldns/java/VinylDNSClientTest.java#L755)

VINYLDNS_API_URL
VINYLDNS_ACCESS_KEY_ID
VINYLDNS_SECRET_ACCESS_KEY

Note: A combination of EnvironmentVariableCredentialsProvider for AWS credentials and System.env can be used to implement this.

vinyldns / vinyldns-java Goto Github PK

vinyldns-java's Issues

Example Request:

Additional Information

Example Request

Additional Information

Description

Example Request:

Expected Changes

Recommend Projects

Recommend Topics

Recommend Org