Giter Site home page Giter Site logo

jdownloader-2-dark-theme's People

Contributors

georgeto avatar vinylwalk3r avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

jdownloader-2-dark-theme's Issues

White Window Outline

After Enabling the LAF Settings: Window Decoration, the Window title is dark, but there is weird white/silver outline when JD2 is windowed.
image
Is there a way to fix this ?

[Windows] Terminal command not working >> top bar to show up with the dark theme, you'll also need to run this in terminal: ```defaults write org.jdownloader.launcher NSRequiresAquaSystemAppearance 0```

One note, to get the top bar to show up with the dark theme, you'll also need to run this in terminal: defaults write org.jdownloader.launcher NSRequiresAquaSystemAppearance 0

Originally posted by @elliotttate in #9 (comment)

#9


On windows, what is the equivalent command?

I have a Windows 10 PC.

Also, my bars are not green. They are 'blue'. is this expected?

image


With an active download

Am I missing anything? (other than the blue progress bars?)

image


Thanks for the awesome theme! My eyes already feel better <3

Text color 'Linkgrabber - Views'

Not really sure if this is an issue but maybe someone can help me anyway.

I tried to change all the red colors I could find in 'Advanced Settings' but still couldn't manage to change this red text...
Untitled-1
...to something a bit less demanding for my eyes like a bit darker than the other text next to it.

Is it possible?

Folder line and light blue frame

I think I install everything correctly and I love how this theme looks. Thanks for sharing.

I just noticed a couple of rare things, one of them I don't know if it's a bug or I just don't like it, in both cases it would be good at least to know the name of the file to be able to modify or change the color, I would appreciate it.

I remember that the line of a folder had a different color to differentiate them more easily between the files (I don't speak of the color interspersed between each file, it seems better if that isn't that, although I don't know if the error is due to that)
For example something like that
image

Now with the unopened folders it looks normal
image

If I open the first, the third loses the color and has the same as the other files.
image

If I open the first and also the second, the third recovers its color that differentiates it (the same happens if I open the 3 folders)
image

If I open only the second, this folder and the third have the same color as the files, and well I think my problem was already understood. Sometimes have a color and sometimes another.
image

And the other that maybe noticed is that light blue frame that appears when I click on the download box or the LinkGrabber box (that line that looks in the images). I don't understand what a function it complies and is quite ugly.

Window bar doesn't turn dark

Thanks, nice theme. Not sure if Windows or JD, but after dark theme installed, the window bar still remains on "default" theme.

image

Kind Regards.

main part still white

Hi, thanks for making such great theme, but when I apply to JDownloader using both method I got this result. Is there something I missed or it's a bug?

screenshot from 2019-01-21 03-04-56

Backup Preferences loaded

The look is AMAZING!! Congrats dude!! I love it.
But there is a problem, loading the backup, not just loads the colours but all the rest of the preferences, for example it points in several places a johannes directory (C:\Users\Johannes\Documents\GitHub\Jdownloader-2-Dark-Theme)...
And there are other several setting which are not the default for jdownloader, like menus and so on.
You could start just sharing what are the setting to change just the colours and sharing here. Unless there is a way to create a backup just for the colours, and not for the rest of it.
Should be great to be as agnostic as possible of anything, just changing the colours.
As the backup is binary, there is a problem trying to see what is happening underneath.
Please help us.
Thanks and greetings!! Great work!!

Feature Request for Dark Theme

so i LOVE what you did with the dark theme , finally jd2 easy on the eyes, only issue i have with jd2 is i use a fontsize of 160 in its advanced settings instead of the default 100 and most gui elements cut off fonts , would appreciate if someone would have a hack for this , since i dont use dpi scaling from windows since it blurs everything as known , thanks in advance

[HOWTO] EventScripter Script to Re-Apply Dark Theme After Updates

Why this exists

After installing the rather excellent dark theme, I was frustrated that updates temporarily broke the theme until JDownloader 2 was restarted again. So, I looked up the API calls, and created a script for the Event Scripter plugin to work around the bug. This Event Scripter script will check for updates periodically, apply them if JDownloader 2 if it is idle, and then automatically restart JDownloader2 again to fix the dark theme.

To use this, enable Event Scripter from Settings -> Plugins. Then, add a new script with an Interval trigger. Set the trigger to a much longer delay, enable synchronous execution by checking the box, and paste the script from below. Scroll down for detailed instructions.

/*
    Name: Update and Re-Apply Theme
    
    Version: 1.0.1
    
    Author: https://github.com/andrewjmetzger
    
    Description: Check for and apply updates periodically if JDownloader 2 is idle, 
                 and then restart JDownloader 2 one more time to apply the dark theme properly.
                 
    Trigger Required: "Interval" (Recommended: 600000 (10 mins.) or more)
    
    Synchronous execution: Yes (checked)
*/

if (
        callAPI("update", "isUpdateAvailable") &&       // an update is available, and
        !callAPI("linkcrawler", "isCrawling") &&        // LinkCrawler is idle, and
        !callAPI("linkgrabberv2", "isCollecting") &&    // LinkGrabber is idle, and
        !callAPI("extraction", "getQueue").length &&    // nothing is being extracted, then
        isDownloadControllerIdle()                      // if no downloads are running...
) {
    callAPI("update", "restartAndUpdate");              // Check for and apply an update, then
    callAPI("system", "restartJD");                     // restart JDownloader 2 again to fix the theme
}

Headless users only -- here is the same script with no line breaks:

[ {
  "eventTrigger" : "INTERVAL",
  "enabled" : true,
  "name" : "Update: Reapply Theme",
  "script" : "/*\n    Name: Update and Re-Apply Theme\n    \n    Version: 1.0.1\n    \n    Author: https://github.com/andrewjmetzger\n    \n    Description: Check for and apply updates periodically if JDownloader 2 is idle, \n                 and then restart JDownloader 2 one more time to apply the dark theme properly.\n                 \n    Trigger Required: \"Interval\" (Recommended: 600000 (10 mins.) or more)\n    \n    Synchronous execution: Yes (checked)\n*/\n\nif (\n        callAPI(\"update\", \"isUpdateAvailable\") &&       // an update is available, and\n        !callAPI(\"linkcrawler\", \"isCrawling\") &&        // LinkCrawler is idle, and\n        !callAPI(\"linkgrabberv2\", \"isCollecting\") &&    // LinkGrabber is idle, and\n        !callAPI(\"extraction\", \"getQueue\").length &&    // nothing is being extracted, then\n        isDownloadControllerIdle()                      // if no downloads are running...\n) {\n    callAPI(\"update\", \"restartAndUpdate\");              // Check for and apply an update, then\n    callAPI(\"system\", \"restartJD\");                     // restart JDownloader 2 again to fix the theme\n}",
  "eventTriggerSettings" : {
    "lastFire" : 1616161911463,
    "interval" : 600000,
    "isSynchronous" : true
  },
  "id" : 1616156482823
} ]

Detailed Instructions

IMPORTANT: For the first time run, you must allow the script to use the Interval permission. Afterwards, the script will run automatically.

  1. In the Event Scripter settings, click Add to create a blank script
  2. Give the script a name, such as Update and Re-apply theme
  3. Change the Trigger for the script to Interval
  4. Open the blank script by clicking Edit
  5. Change the script interval to something long, like 600000 milliseconds (10 minutes)
  6. Check the box to Enable Synchronous execution
  7. Copy the first block of code above, and paste it in the Editor
  8. Save the script, then in the Event Scripter list click Edit again.
  9. Click Test Compile, and dismiss the "Success" message. (Note: If you do not see "Success", make sure to copy/paste the whole script.)
  10. Click Test Run to display a permission dialog
  11. In the permission dialog, make sure to check Don't show this again, then click Allow
  12. To apply the new permissions and close the script editor, click Save

@Vinylwalk3r if you like this script and want to include it in the repo, the JSON "headless" script can be added to ./cfg/org.jdownloader.extensions.eventscripter.EventScripterExtension.scripts.json under the JDownloader 2 installation directory. Note that this still requires the user to install and enable Event Scripter beforehand. Let me know and I'm happy to create a PR.

Hope this helps!
@andrewjmetzger


Changelog:

Version 1.0.1 - 2021-03-19:

  • Updated informational comments
  • Added top-level heading ("Why this exists")

Version 1.0.0 - 2021-03-19:

  • Initial release

JDownloader Team offers help!

Hi, Jiaz here from JDownloader Team.
Just recently discovered your custom theme and it's great! THUMBS UP! GREAT WORK!

We would like to offer help to
1.) sort out remaining issues
2.) make installation easier
Would be great if you can contact us via [email protected]

best regards
jiaz

How do I get a title bar like that?

In this screenshot you have a title bar that doesn't match the rest of the screenshots.

I tried enabling 'LAFSettings: Window Decoration' but that didn't give me the same titlebar, plus it puts an ugly white outline around the entire window. (Though honestly it's still better than the default one.)

100% Animation

First of all, thank you so much for this. It works perfectly for me. Real easy on the eyes.

But there is one thing that annoys me... this.

I already have animations disabled in the advanced settings but it does it anyway, I guess it's something separate. Can you do something about it?

Every odd numbered entry blends in with the dark background

So I like the theme so far, it looks really nice.

One hang up is i I have a big list, then every first entry has black text (so 1-3-5-7), while every other entry has the white text. This makes it really hard to see it unless I specifically hover over it, I'm not sure if there is a fix or if there's a weird configuration I need to edit, I'm poking around the backup and advanced settings just in case.

Add support for "Flat Look And Feel"

This can be done simply by renaming the custom SyntheticaBlackEyeLookAndFeel.json to FlatDarkLaf.json and choosing the FLATLAF_DARK theme. Instead of BLACK_EYE.

Black Fonts Unless Hovered Over

The fonts in "Downloads" and "Link Grabber" are black on dark background in "JDownloaderDarkOnly.jd2backup" unless it's hovered over.

Black Font

Solution how to install theme on Windows, with some other tweaks

I tried to make JDownloader v2.0 as dark as possible and usefull for a long time.
I was able to tweak some color settings but I was all time looking for a better way.

I was probably on this page few times and it never worked.
Until now, when I need to reinstall JDownloader because it became unstable with many graphical glitches.

I was never able to install any theme downloaded from Internet, but now I found a way to make it with JDownloader-2-Dark-Theme-master and here comes how-to.

It was made on Windows 10, and it should work on Windows 8 also, and probably other Windows also.

  1. Backup your JDownloader settings: Menu File->Backup-> Backup all settings.

  2. Install JDownloader v2.0.

  3. Make automatic update, and start download something from youtube, this way you can download ffmpeg, because later it can broke theme.

  4. Next set Look and Fell BlackEye theme, it will download and install Synthetica I think.

  5. Restart JDownloader, check if the BlackEye is set and there should be some changes to darker color but not all is nice.

  6. Close Downloader and now is the moment to change few things in the install folder.
    Copy syntheticaBlackEye.jar from JDownloader-2-Dark-Theme-master\ to libs\laf, first you can alter it to make green progress bar (recompress file with new pictures from
    JDownloader-2-Dark-Theme-master\themeNameHere.jar).

This is optional, but it helps me:
-in themes\standard\org\jdownloader\images\ there are popDownLarge.png and popUpLarge.png, wide black arrows, first I made them white, and copied over popDownSmall.png and popUpSmall.png, it makes some elements of interface more visible.
-in themes\standard\org\jdownloader\images\exttable\ there are two files, sortAsc.png and sortDesc.png, they are two little black arrows, I changed them to white arrows which you can later see when you sort columns (very small, too small).
-you can also edit pictures from themes\standard\org\jdownloader\images\logo, PNGs with the word "logo" in the names are JDownloader icon used as the icon of program on Taskbar, it can also be (dark) B&W.

  1. Restore your backup, if you have one, set BlackEye theme, restart and check if it is set and then backup this settings to file, example backup.jd2backup

  2. backup.jd2backup is a zip file, unpack it and you get cfg\ folder, to this folder you need to copy two files:

-to cfg\laf\ copy SyntheticaBlackEyeLookAndFeel.json from
JDownloader-2-Dark-Theme-master\jd2backups\JDownloaderDarkOnly, lenght 1032 bytes. Because when the theme is set all changes to Advanced Settings colors don't work, and there were problems with proposed settings so I changed three lines in the file to:
"colorfortablepackagerowforeground" : "#ffeeeeee",
"colorfortablemouseoverrowbackground" : "#ff333388",
"colorfortablealternaterowbackground" : "#ff444444",

-to cfg\ copy SyntheticaBlackEyeLookAndFeel.json from
JDownloader-2-Dark-Theme-master\jd2backups\JDownloaderDarkOnly\cfg, length 4204 bytes.

  1. Compress altered cfg\ folder to new zip with the name like newsettings.jd2backup

  2. Restore settings from newsettings.jd2backup, there should be dark theme, your settings and B&W icon on Taskbar if you changed it.

Thank you Vinylwalk3r very much!

Final effect:

mail2

Button "Download Selected" in LinkGrabber is missing.

Hi,
I would love to use this Theme. Thanks for doing it.
Is it a conscious design decision to remove that button? This is my most used sub-button in LinkGrabber.
Thank you very much.

EDIT:
Well, I was able to add the "Start all downloads" item, but it's flat and does not contain the sub-items from the vanilla UI.
Also, I am able to add the raw entry "Force Start"... but this is all ugly. The vanilla structure is so neat, and it's sad this is missing here.

image

How to modify Backup?

Instruction says "copy the content of the config folder into the open backup".
I don't understand this instruction. The config folder is a directory, whereas the backup-file is a file. Where to copy the config folder in common?

Buttons uncomfortably glossy

Thank you so much for doing this. It's much easier on the eyes. One bit of feedback I have though is the buttons can be really glossy, especially when they are vertically 'short'

Flatter buttons, or completely flat buttons, would be heavenly.

Theme disappearing after JD2 restart

I installed the theme using the backup method, the custom theme method and by copying the file to my JD2 folder. When I start the program the first time all gets applied fine with no problems.
But when I close the program and open it again everything is gone again and its back to the delivered BLACK_EYE theme. Even the white arrows get replaced with "DUMMY" images. Also the custom toolbar at the bottom is gone.

I tried to apply the theme several times now but it never stays.

Simplifying suggestions

Hello,

I have a few suggestions in order to simplify and/or extend this project.

1. Provide patched .jd2backup file with default settings

The whole installation process consists in creating a settings backup, patching the backup file, then importing the backup file.
This process is identical for all installations.
Therefore, it is possible to directly provide the patched .jd2backup file so that people can import it directly.
Of course, this implies that eventually changed settings will be reset.

2. Provide automated patch script

In order to keep simplifying the process without forcibly resetting the user's settings, why not creating a patch script that will automatically call JDownloader's export function, then automatically patch the generated backup file, and finally automatically call JDownloader's import function.

3. Create a custom patch generator

In order to extend the project's capabilities, we could create a customization software which could automatically generate patched .jd2backup, allowing the user to graphically (without manual file manipulation) change whatever it is easy and non-risky to change (for example : progress bar color).

Thanks

Tray: Tool Tip is not legible

When you mouse over the tray icon, this is what you see.

If this is unfixable, in the configuration for the config settings provided on this github, this should be disabled like so:

Not completely dark

Hi,

this didn't work for me.
Somehow it is partially dark and now even bright in some parts.
Any advice? :)

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.