vitejs/vite-ecosystem-ci

Vite Ecosystem CI

vite-ecosystem-ci's Issues

override rollup in tests to use vite's rollup version

We still battle with type inconsistencies between rollup versions, to solve them and see where downstream project might get problems from new rollup versions used by vite, override it to match vite always.

move to pnpm7

pnpm7 has a few breaking changes and a new lockfile version.

Right now our ci uses pnpm@6 and that causes errors when running on ecosystem projects already on 7.
The same can be true if we switch to pnpm7 and projects are still on 6.

Once vite main branch is on pnpm7 make that move here too. Once moved, disable projects still on pnpm6 until they also migrated.

Allow additional comments when triggering ecosystem-ci in a PR

See failed run here vitejs/vite#12079 (comment) because I included some context of the re-run

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: .github/renovate.json5
Error type: The renovate configuration file contains some invalid settings
Message: Invalid configuration option: node

--help shadowed by tsm

looks like tsm is greedy with --help lukeed/tsm#22

enhancement: custom discord integration

Current webhook doesn't log all details needed to figure out what was executed and isn't configurable. Use a custom github action or some other way to show custom messages on vite discord

marko test fail with vite 2.9 alpha

pnpm test -- marko --release 2.8.6 passes but pnpm test -- marko fails with

> @marko/[email protected] mocha
> NODE_ENV=test mocha 'src/**/__tests__/*.test.ts'



  browser-basic
    ✔ dev (1314ms)
    ✔ build (1097ms)

  isomorphic-basic
    ✔ dev (1134ms)
    1) build


  3 passing (4s)
  1 failing

  1) isomorphic-basic
       build:
     /home/dominikg/develop/vite-ecosystem-ci/workspace/marko/marko/src/__tests__/fixtures/isomorphic-basic/dist/index.js:240
window.addEventListener("message", function(ev) {
^

ReferenceError: window is not defined
      at Module.<anonymous> (src/__tests__/fixtures/isomorphic-basic/dist/index.js:240:1)
      at Module._compile (node:internal/modules/cjs/loader:1101:14)
      at Module._compile (node_modules/esbuild-register/dist/node.js:2258:26)
      at Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
      at Object.newLoader (node_modules/esbuild-register/dist/node.js:2262:9)
      at Object.extensions..js (node_modules/esbuild-register/dist/node.js:4801:24)
      at Module.load (node:internal/modules/cjs/loader:981:32)
      at Function.Module._load (node:internal/modules/cjs/loader:822:12)
      at Module.require (node:internal/modules/cjs/loader:1005:19)
      at require (node:internal/modules/cjs/helpers:102:18)
      at Object.<anonymous> (src/__tests__/fixtures/isomorphic-basic/server.js:4:21)
      at Module._compile (node:internal/modules/cjs/loader:1101:14)
      at Module._compile (node_modules/esbuild-register/dist/node.js:2258:26)
      at Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
      at Object.newLoader (node_modules/esbuild-register/dist/node.js:2262:9)
      at Object.extensions..js (node_modules/esbuild-register/dist/node.js:4801:24)
      at Module.load (node:internal/modules/cjs/loader:981:32)
      at Function.Module._load (node:internal/modules/cjs/loader:822:12)
      at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:190:29)
      at ModuleJob.run (node:internal/modules/esm/module_job:185:25)
      at async Promise.all (index 0)
      at async ESMLoader.import (node:internal/modules/esm/loader:281:24)
      at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
      at Context.<anonymous> (src/__tests__/main.test.ts:133:12)

vite ref: b0c0efe009c4234c8915a649dc9b1568d1d8a07f

fix storybook

storybook changed the repository layout for vite-builder and package.json no longer is in root of the repo but in packages/vite-builder

causing an error in the test https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3202468586/jobs/5231480918#step:7:269

Possible fixes:

1. add support for custom package.json paths in vite-ecosystem-ci
2. switch to storybook 7 monorepo

abstraction/generalization to allow using it for other ecosystems

#33 focuses on using it for forks of vite (PR), but the general pattern of executing downstream ci's is interesting for a lot of ecosystems.

eg. svelte, nuxt, vue

• make the base repository configurable
• find a way to distribute this (npm package?)

enhacement: Discord webhook to report results for a selected project

For example, we would be getting Ladle specific results posted into our Ladle discord server. Ideally, it would report only failed runs.

enhancement: add input parameters to select different node and os version

reasons:

node16 and node18 have differences in network stack defaults
windows file system is a bitch

on windows some shell commands might not work as expected, so either force shell to bash or look into using generic commands/node scripts to replace them

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all non-major dependencies (@types/node, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, pnpm, tsx, typescript)
• chore(deps): update dependency eslint to v9
• chore(deps): update dependency eslint-plugin-n to v17
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/ci.yml

• actions/checkout v4
• actions/setup-node v4
• actions/setup-node v4

.github/workflows/ecosystem-ci-from-pr.yml

• tibdex/github-app-token v2
• actions/github-script v7
• actions/checkout v4
• actions/setup-node v4
• actions/checkout v4
• actions/setup-node v4
• tibdex/github-app-token v2
• actions/github-script v7

.github/workflows/ecosystem-ci-selected.yml

• actions/checkout v4
• actions/setup-node v4

.github/workflows/ecosystem-ci.yml

• actions/checkout v4
• actions/setup-node v4

npm

package.json

• @actions/core ^1.10.1
• cac ^6.7.14
• execa ^8.0.1
• node-fetch ^3.3.2
• @antfu/ni ^0.21.12
• @types/node ^20.11.30
• @types/semver ^7.5.8
• @typescript-eslint/eslint-plugin ^7.4.0
• @typescript-eslint/parser ^7.4.0
• eslint ^8.57.0
• eslint-define-config ^2.1.0
• eslint-plugin-n ^16.6.2
• lint-staged ^15.2.2
• prettier ^3.2.5
• semver ^7.6.0
• simple-git-hooks ^2.11.1
• tsx ^4.7.1
• typescript ^5.4.3
• pnpm 8.15.5

---

• Check this box to trigger a request for Renovate to run again on this repository

feat: allow arbitrary commands instead of just pkg scripts

to allow more flexibility with custom ci scripts, eg. Installation of playwright.

Idea: check pkg script existence and omit nr if not a script.

vite-ecosystem-ci/utils.ts

Line 101 in d7ddfed

await (typeof task === 'string' ? $`nr ${task}` : task?.())

enhancement: add viteRepo option

To be able to run PRs from forks

switch to node20

After node20 is promoted to active lts status by the end of october, switch to it

• change ci scripts to use setup node action with v20
• update our own engine field
• reenable ladle test

hydrogen - yarn1 install error

running pnpm test -- hydrogen results in the following error:

error An unexpected error occurred: "ENOENT: no such file or directory, stat '/home/dominikg/develop/vite-ecosystem-ci/workspace/hydrogen/hydrogen/node_modules/vite/node_modules/resolve'".
yarn install v1.22.17
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
info If you think this is a bug, please open a bug report with the information provided in "/home/dominikg/develop/vite-ecosystem-ci/workspace/hydrogen/hydrogen/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
    at makeError (file:///home/dominikg/develop/vite-ecosystem-ci/node_modules/.pnpm/[email protected]/node_modules/execa/lib/error.js:59:11)
    at handlePromise (file:///home/dominikg/develop/vite-ecosystem-ci/node_modules/.pnpm/[email protected]/node_modules/execa/index.js:119:26)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async $ (file:///home/dominikg/develop/vite-ecosystem-ci/utils.ts:42:18)
    at async applyPackageOverrides (file:///home/dominikg/develop/vite-ecosystem-ci/utils.ts:239:5)
    at async runInRepo (file:///home/dominikg/develop/vite-ecosystem-ci/utils.ts:142:3)
    at async test (file:///home/dominikg/develop/vite-ecosystem-ci/tests/hydrogen.ts:22:3)
    at async run (file:///home/dominikg/develop/vite-ecosystem-ci/ecosystem-ci.ts:103:3)
    at async CAC.<anonymous> (file:///home/dominikg/develop/vite-ecosystem-ci/ecosystem-ci.ts:42:5) {
  shortMessage: 'Command failed with exit code 1: yarn install',

if you look closely, you'll notice that vite is inside hydrogen/node_modules and not our local one.
this seems to be caused by the fact that yarn1 silently refuses to use absolute paths in resolutions.

prefixing the resolution path with link: fixes that, but then other errors crop up because yarn tries to hoist dependencies and that fails.

Already tried rewriting hydrogens workspaces declaration in package.json to

  "workspaces": {
    "packages": [
      "examples/*",
      "packages/*",
      "packages/playground/*"
    ],
    "nohoist": [
      "vite/**"
    ]
  },

but that failed with

  Error: ENOENT: no such file or directory, lstat '/home/dominikg/develop/vite-ecosystem-ci/workspace/vite/packages/vite/node_modules/esbuild-linux-64'

tbh i'm out of ideas and not familiar with yarn1 or hydrogens project setup.

@frandiox: is there a way to to provide a local vite package to hydrogen so that yarn install works without using yarn link on the cli?