vitstradal/redmine_remote_user_auth

Auth by Remote-User-Email HTTP header (with apache conf can allow auth ssl certificates)

redmine_remote_user_auth's Issues

skip_before_filter is deprecated

Hi,
as mentioned here, the usage of skip_before_filter is deprecated and should be avoided. So the following call doesn't work with the current Rails version.

redmine_remote_user_auth/app/controllers/account_remote_user_controller.rb

Line 9 in 6eaf1e7

skip_before_filter :check_if_login_required

Regarding this, I have a related question. Is this call necessary at all? The class AccountRemoteUserController is derived from AccountController where (its successor skip_before_action) is called, too:

https://github.com/redmine/redmine/blob/3aef7783423fc47a987bad6df060ad69a06221dc/app/controllers/account_controller.rb#L27

Sorry, I'm just using this plugin but don't have any Ruby skills...

nil user

I needed these changes in app/controllers/account_remote_user_controller.rb for the plugin to work. Otherwise I get

NoMethodError (undefined method `name' for nil:NilClass)

I also needed the 'l(...)'.

    unless user && user.active?
      flash.now[:error] = l(:notice_account_unknown_email)
      return
    end
    unless  user.auth_source.nil? || user.auth_source.name != 'RemoteUser'
      successful_authentication(user)
      return
    end
    flash.now[:error] = l(:user_auth_source_not_remote_user);
  end
end

Using redmine 2.2.4.

SSL_CLIENT_S_DN_Email is specific to Apache

The env var "SSL_CLIENT_S_DN_Email" is specific to Apache (which parses SSL_CLIENT_S_DN), so this plugin can't be used by other httpds like nginx. There should be a generic way to use this plugin (for instance, if Remote-User-Email field is not found, parse X-SSL-Client-DN header).
The parsing can be done easily, take a look at this plugin:
https://github.com/koke/redmine_ssl_auth/blob/master/lib/redmine_ssl_auth/monkey_patches.rb#L28