vkay94/tmdb-kotlin

TheMovieDatabase API wrapper for Kotlin

tmdb-kotlin's Issues

Providing `OkHttpClient`

Hi,
This is more of a question. I'm trying to understand the process of providing a different instance of OkHttpClient without interfering with library's functionality.

As stated in documentation, it is possible to add certain modifications to TMDbInterceptor and then assign the new Interceptor to TMDb.tmdbInterceptor before calling init. However it seems that TMDb.tmdbInterceptor is immediately overwritten in defaultOkHttpClient() function:

TMDb-Kotlin/src/main/java/de/vkay/api/tmdb/TMDb.kt

Lines 159 to 162 in 5feaa37

	private fun defaultOkHttpClient(): OkHttpClient {
	tmdbInterceptor = TMDbInterceptor(apiKey, bearerToken)
	return OkHttpClient.Builder().addInterceptor(tmdbInterceptor).build()
	}

Furthermore, if we provide our own instance of OkHttpClient, no TMDbInterceptor is attached to it, unless we add it to OkHttpClient ourselves and also set the TMDb.tmdbInterceptor, as it seems that it only gets instantiated in defaultOkHttpClient() function, and several functionalities of the library depend on TMDb.tmdbInterceptor not being null.

I'm not sure about all these and it would be great if you could shed some light on this matter.

If I'm right though, it seems that if the defaultOkHttpClient() get called anyway, regardless of user providing OkHttpClient or not, could be the solution. Of course it needs to instantiate a new OkHttpClient if user has not provided one, and then modify it (add Interceptor) and also instantiate the TMDb.tmdbInterceptor.

`JsonDataException` on `aggregateCrew method

Method: TvService.aggregateCrew()
Response: UnknownError(error=com.squareup.moshi.JsonDataException: Expected END_OBJECT but was NAME at path $.crew[0].jobs[0].credit_id, code=null, headers=null)

It seems that this is related to parsing jobs object which is present only in /tv/{tv_id}/aggregate_credits endpoint, as it happens in every TV Show with crew array not being empty.

`note` field should be nullable or have a default value

TMDB API: release_dates
Sample Request: https://api.themoviedb.org/3/movie/240/release_dates

{
    "iso_3166_1": "PT",
    "release_dates": [
    {
        "certification": "M/16",
        "iso_639_1": "en",
        "release_date": "1977-10-14T00:00:00.000Z",
        "type": 3
    }
    ]
}

As shown in the example response, note field is not always present in the JSON Object.

TMDb-Kotlin/src/main/java/de/vkay/api/tmdb/models/TmdbReleaseDate.kt

Line 11 in f3c9ad9

val note: String,