vladiliescu/woofy

A webcomic downloader with a (crazy) powerful download engine. Will download comics for offline reading, including metadata such as the title and description.

woofy's Issues

WARNING: The request was aborted: Could not create SSL/TLS secure channel.

on some comics I get a "WARNING: The request was aborted: Could not create SSL/TLS secure channel." error and it doesn't download anything. one example is below.

steps to reproduce:

• put attached def file in the woofy definitions folder
• start Woofy
• Add Comic
• select "Deviants"
• download will say complete without downloading anything and the above mentioned error will be in the log file.

Attached files:

• Log file when I try to do it
  Deviants.txt
• definition file I used to download the webcomic. (zipped since Github doesn't let me upload a .def file)
  Deviants.zip

[BUG] Woofy crashes if the file it's trying to save has an invalid character in it's name

Bug Description:
I have a def file I just created that, when added to Woofy 1.25, causes it to crash. I'm pretty sure it's because the file name of the file has a Semi-colon : in the file name (which is not allowed in windows), causing the IO stream to fail, and therefore Woofy crashes.

Desired Behavior:
While ultimately up to you, I'd recommend having Woofy replace illegal characters with an Underscore _ thereby allowing it to continue processing instead of crashing.
Alternatively you could add some sort of option for custom file names.

Additional Information:
Once it crashes it continues to crash on startup due to the comic being in the list still. To get Woofy working for the other comics again I had to go into the Comics.json file and remove the entry for the problematic comic (Mala Tinta in this case).

Error.txt content:
08/01/2020 23:36:44 System.NotSupportedException: The given path's format is not supported.
at System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)
at System.Security.Permissions.FileIOPermission.QuickDemand(FileIOPermissionAccess access, String fullPath, Boolean checkForDuplicates, Boolean needFullPath)
at System.IO.File.InternalMove(String sourceFileName, String destFileName, Boolean checkHost)
at Woofy.Core.SystemProxies.FileProxy.Move(String sourceFileName, String destFileName)
at Woofy.Core.Engine.Expressions.DownloadExpression.Download(IEnumerable`1 links, Context context)
at Woofy.Core.Engine.Expressions.DownloadExpression.Invoke(Object argument, Context context)
at _MalaTinta.RunImpl(Context context) in C:\Users\Home\AppData\Roaming\Woofy\bin\MalaTinta:line 5
at Woofy.Core.Engine.Definition.Run()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()

Comic Log File:
[8/1/2020 11:36:43 PM][MalaTinta visit] starting at http://malatinta.com/0000/
[8/1/2020 11:36:44 PM][MalaTinta download] found 1 images
[8/1/2020 11:36:44 PM][MalaTinta download] downloading http://malatinta.com/strips/.0000QW4gaW50/00:00 to C:\Users\Home\Documents\My Comics\MalaTinta\0001_00:00

I attached a zip file containing the def file that reproduces the error as well as the logs quoted above.
MalaTinta Error.zip

Please let me know if there is anything I can do to help/any information I can get you.

If I get some time in the next few days I may try to figure out how to fix it myself if you don't by then, but I'm not as familiar with the code as you are so it will take me longer to find where in the code the fix needs to go.

[BUG] Woofy doesn't download files if they have the same name but are in different directories.

once fixing the previous issue I found, I have a new issue with the Mala Tinta comic, all the comic pages have the same file name but are in different directories. This results in Woofy having thought that it already downloaded a particular comic page and moving on instead of downloading each page.

Current Behavior:
(Assuming Issue #3 is fixed, otherwise hits Issue #3 before getting this far)
downloads the first comic page and then does not download any others with the warning "already downloaded http://malatinta.com/strips/.0002V2hlcmUg/00:00."

Expected Behavior:
Downloads all the strips in the given comic.

Zip with def file and log:
MalaTinta.zip