vmcilwain/myrails

A ruby gem to help quickly spin up a rails app and start coding

myrails's Issues

router.rb template needs tweaking

Code should be:

  config.before :each, type: :controller do
    @request.host = 'localhost:3000'
  end
end

Add byebug debug server config

if Rails.env.development?
  require 'byebug/core'
  Byebug.start_server 'localhost', ENV["BYEBUGPORT"].to_i
end

Add material

Just as with the bootstrap layout, there should be a material layout to choose from as well.

add api authorization code

Add api authorization code. figure out a way to categorize it like what was don with the install code.

monit start causes an error.

Need to move reload invocation from the monit task.

namespaced controller template has a trailing erb tag in the finder method

  def note
      @note = Note.find(params[:id]) %>
    end

Add additional capybara configs

Capybara.app_host = "http://localhost:3000"
Capybara.server_host = "localhost"
Capybara.server_port = "3000"

Update rspec templates

Actions should only require the object not object.id
All specs should have a subject that points to the assigns object
All specs should use is_expected.to where possible
All specs should have flash specs already filled out

add additional headers to nginx config

proxy_pass        http://myapp;
proxy_set_header  Host $host;
proxy_set_header  X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header  X-Forwarded-Proto $scheme;
proxy_set_header  X-Forwarded-Ssl on; # Optional
proxy_set_header  X-Forwarded-Port $server_port;
proxy_set_header  X-Forwarded-Host $host;

Address issue with nested controllers

myrails controller --name admin/articles generates code like:

let(:admin/articles) {[]}
let(:admin/article) {create :admin/article}

describe 'GET index' do
before do
3.times {admin/articles << create(:admin/article)}
get :index
end

it 'sets @admin/articles' do
  expect(assigns[:admin/articles]).to eq admin/articles
end

end

Add capistrano setup

Add action to generate capistrano setup including rake tasks, templates and notification.

Fix controller template

It is reference Object instead of the passed in value in the find method.

make sure devise authentication is after forgery protection

This causes issues with authentication. Also remove any options that are set on the protect from forgery line in application controller.

Add record identifier to rails helper

config.include ActionView::RecordIdentifier, type: :feature

Adding the above line will allow use of record identifiers such as dom_id to be used in the feature spec.

update capistrano to support maintenance page

capistrano should support a maintenance page when deploying.

Controller generation contains erb tags in the find method

Random set of erb tags show up after generating a controller.

Model not inheriting from application_record class

This was a rails 5 change that needs to be added.

add figaro

Add option to install figaro instead of dotenv. Be sure to check if one or the other has been installed before installing.

css import statement is nested

When choosing a css style the import statement in the application.css.sass file is nested.

@import animate
  @import spacelab
@import will_paginate

Upgrade activesupport version

Upgrade activesupport gems get and get rid of deprecation warnings

Change devise support file documentation

Logout should be changed to sign_out for controller tests.

Switch global variables task to using dotenv

Dotenv is a better solution than rolling out your own at this point.

update fill in trix editor code to use css

xpath has been problematic. Change it to use css instead.

base install description does not match task name

Not able to rely on task description to execute task.

create a shared examples generator

It will be helpful to generate rspec shared example boiler plate code.

all install scripts should be a switch statement

something like

myrails install rspec

Add rspec feature creation

There should be an action to generate a generic rspec feature file. Something like:

myrails feature --name=directory/filename

Action should add the file with _.spec.rb to the end of it in the sub directory specified in the spec/features directory.

controller template not handling snake case well

If model is defined with snake case, The finder method should constanize the full word and not just the first word before the underscore.

ui_install generated an error

$ myrails ui_install
create app/controllers/ui_controller.rb
create app/views/ui/index.html.haml
/Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor/actions.rb:90:in action': wrong number of arguments (given 0, expected 1) (ArgumentError) from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/myrails-1.0.0/lib/myrails.rb:65:inblock in ui_install'
from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor/actions/inject_into_file.rb:46:in initialize' from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor/actions/inject_into_file.rb:30:innew'
from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor/actions/inject_into_file.rb:30:in insert_into_file' from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/myrails-1.0.0/lib/myrails.rb:61:inui_install'
from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor/command.rb:27:in run' from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:ininvoke_command'

    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/myrails-1.0.0/lib/myrails.rb:399:in `<top (required)>'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/myrails-1.0.0/bin/myrails:3:in `require_relative'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/gems/myrails-1.0.0/bin/myrails:3:in `<top (required)>'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/bin/myrails:23:in `load'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/bin/myrails:23:in `<main>'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `eval'
    from /Users/lovell.m/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `<main>'

Pundit updates

The pundit rescue clause should be added above protect

Including pundit should happen just after the class declaration.

Add custom flash types

add_flash_types :..., :...

rspec commands should be sub commands under rspec

Do the same thing with rspec commands that you did with install commands. example:

myrails rspec feature directory/specfile

This makes for a cleaner experience.

fix ui path in navigation

path for ui is set to /ui when it should be set to /ui/index

controller generator should create asset files as well

For .coffee files:

# Place all the behaviors and hooks related to the matching controller here.
# All this logic will automatically be available in application.js.
# You can use CoffeeScript in this file: http://coffeescript.org/

For .scss files:

// Place all the styles related to the organizations controller here.
// They will automatically be included in application.css.
// You can use Sass (SCSS) here: http://sass-lang.com/

Updating factory girl to factory bot

Factory girl is being deprecated so its time to change it

rspec_install should install the rspec rails gem on the fly

This action should not rely on the gems_install action being ran first.

Application controller callback :configure_permitted_parameters missing.

The following should be added to the application controller when the registration override option is used.
before_action :configure_permitted_parameters, if: :devise_controller?

Footer should be optional

Layout assumes a footer is created. Most likely css as well.

Change code to only insert footer render code if a footer is actually generated

add request generator

Add code to generate rspec request file with boilerplate code

pundit include not in application controller

pundit install doesn't include pundit in the application controller.

Update default url options in config_env

Set them to ENV['DEFAULT_HOST']. this should be set as a figaro/dotenv setting.

Add capybara config to rspec setup

Capybara.app_host = "http://localhost:3000"
Capybara.server_host = "localhost"
Capybara.server_port = "3000"

Combine related tasks

Combine related tasks based on initial install order:

install gems
install application helper
combine:
install assets
install layout
install css
install footer
install ui
install pundit
combine:
install rspec
install rails_helper
install footnotes
git_init

add namespace option to controllers action

Initial thought is to have option called nspace that takes a path from app to handle nesting controllers when needed.

The namespace option should take of adding a top level controller for named controller to inherit from.

if namespace is admin with a controller of users then the following:
app

• controllers
  -- admin
  --- admin controller (which inherits from application controller)
  --- user controller (which inherits from admin controller)

This should also be mimicked in the rspec file structure as well.

install_gems action should read a gem settings file

List of gems should not be hardcoded in the gem. The list should be moved to a separate file. Use the same format as whats in the code but read the file in place of the hard coded content.

Remove devise version on installation

There isn't a need to install a locked version of devise or any other gem.

config_env needs to be in the auto install

Add config_env action to auto_install action.

Add api authentication

After creating an api authentication setup, it should be added to this so that the setup can be automated.