Comments (12)
Just curious - are you using micro front-end architecture?
from core.
Not in this bug report. Just Vite + react/vue
from core.
Can you create a repo with a reproduction? That would save us a lot of time
from core.
Yes, you can use this branch "issue/clarity" https://github.com/wghglory/vmware-vite-react-seed/tree/issue/clarity. In this branch, clarity version is 6.0.1. npm run build
will see the build error. Only when downgrading to 5.6.4, the error disappears.
from core.
I'm not able to reproduce the issue using vite+react+core in stackblitz (using the official vite+react stackblitz starter).
https://stackblitz.com/edit/vitejs-vite-xcjfsz?file=package.json,src%2FApp.jsx,package-lock.json&terminal=dev
Your repo is also way too big and has way too many dependencies for me to debug this. I can look further if you can product a minimum-repro case, without all of the other dependencies (tailwind, etc).
from core.
I downloaded your stackbitz repo and npm run build
, which reproduced the issue. Did you try to build?
from core.
Ah sorry, I was only running npm run dev
Ok, I figured it out. You need to add the @rollup/plugin-node-resolve
package to your vite config: https://stackblitz.com/edit/vitejs-vite-xcjfsz?file=package.json,vite.config.js&terminal=build
from core.
Thanks, @ashleyryan! But I wonder why v.5.6.4 doesn't need this package? What changes does clarity make in v6 to make this plugin necessary?
from core.
There are a lot of changes in v6 and a lot of internal refactoring - most of those changes were made before my time. I can't say for sure, but as the error message indicates, that file (and similar ones) uses an import from the package instead of a relative file import. That may be new in v6
from core.
In v5.6.4, there's no need for @rollup/plugin-node-resolve
to make a successful build. And I checked the file used an import from the package just like v6. So that's why I wonder what underneath causes the failure. I just didn't figure out the differences, and why the same format outputs the different results.
from core.
In v5.7.2, the build error can be reproduced.
from core.
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.
from core.
Related Issues (20)
- `CdsButton` and `CdsControlAction` not receiving `keydown` events in tests HOT 1
- Selection in multiple "select" is invisible when out of focus HOT 2
- Clicking on the resizing handle triggers click on the column header
- Update ramda dependency to ^0.29.0 HOT 2
- Angular app won't compile with Clarity HOT 4
- Missing content in icon documentation
- Empty .svg file HOT 10
- [pdfFileIcon] unclear where to import the pdf file icon from HOT 2
- Breadcrumb not updated when children are deleted
- Local `npm install` errors out on Node.js v20
- Reset cds-file input
- cds-file custom buttonLabel resets to "Browse" on clearing files
- cds-select + Vitest + React Testing Library + jsdom: `TypeError: 'set' on proxy: trap returned falsish for property 'disabled'` HOT 2
- cds-layout styles are not applied to cds-grid-footer
- Failed to execute 'define' on 'CustomElementRegistry': the name "clr-icon" has already been used with this registry HOT 3
- ```cds-dropdown``` should scroll with parent viewport HOT 1
- `cds-dropdown` storybook stories do not show sample code to implement HOT 3
- Allow more CSS custom properties on `cds-accordion-header` HOT 2
- Icon display issue when adding custom css HOT 1
- Setting `cds-motion="off"` in `CdsSelect` doesn't turn off `cds-button-expand` animation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.