Comments (4)
Thanks @hippee-lee , I noticed this a week or so ago too, but didn't have a chance to investigate.
from core.
Ok digging into this some more. Open UI has proposed adding a new popup attribute: https://open-ui.org/components/popup.research.explainer#html-content-attribute which is what chromium is implementing. The attribute would go on the element that is actually the popup (instead of the anchor in our case), and it would only have specific values. So I think we're going to have to rename this attribute, which would be a breaking change. However, the dropdown component is still in beta, so I think it's okay - or we can keep both and log a deprecation warning if you use popup
...
According to the documentation, it sounds like you can put it on any element that is the anchor element and it will apply aria attributes for you. This would make me learn towards calling it cds-popup.
In practice, you can only put it on elements that have the reactive controller, so any clarity component that extends CdsButton elements. In that case something less specific, like popup-element
could work. But if we're going to change popup to popup-element
, then perhaps we should also change trigger
to trigger-element
for consistency...
https://github.com/vmware-clarity/core/blob/main/projects/core/src/internal/controllers/aria-popup-trigger.controller.ts
https://github.com/vmware-clarity/core/blob/main/projects/core/src/internal/controllers/aria-popup.controller.ts
from core.
🎉 This issue has been resolved in version 6.2.0 🎉
The release is available on:
- GitHub release
v6.2.0
Your semantic-release bot 📦🚀
from core.
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.
from core.
Related Issues (20)
- `CdsButton` and `CdsControlAction` not receiving `keydown` events in tests HOT 1
- Selection in multiple "select" is invisible when out of focus HOT 2
- Clicking on the resizing handle triggers click on the column header
- Update ramda dependency to ^0.29.0 HOT 2
- Angular app won't compile with Clarity HOT 4
- Missing content in icon documentation
- Empty .svg file HOT 10
- [pdfFileIcon] unclear where to import the pdf file icon from HOT 2
- Breadcrumb not updated when children are deleted
- Local `npm install` errors out on Node.js v20
- Reset cds-file input
- cds-file custom buttonLabel resets to "Browse" on clearing files
- cds-select + Vitest + React Testing Library + jsdom: `TypeError: 'set' on proxy: trap returned falsish for property 'disabled'` HOT 2
- cds-layout styles are not applied to cds-grid-footer
- Failed to execute 'define' on 'CustomElementRegistry': the name "clr-icon" has already been used with this registry HOT 3
- ```cds-dropdown``` should scroll with parent viewport HOT 1
- `cds-dropdown` storybook stories do not show sample code to implement HOT 3
- Allow more CSS custom properties on `cds-accordion-header` HOT 2
- Icon display issue when adding custom css HOT 1
- Setting `cds-motion="off"` in `CdsSelect` doesn't turn off `cds-button-expand` animation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.