volcano-sh/apis

The API (CRD) of Volcano

apis's Issues

Create v1.3.0 and v1.4.0 tag for volcano api

Is your feature request related to a problem? Please describe.
I am drafting a PR to add volcano support for kubernets client, unfortunately, there were no official tag, like v1.3.0 and v1.4.0 in here.

Describe the solution you'd like
Create v1.3.0 and v1.4.0 tag in volcano github repo.

Describe alternatives you've considered
We could use v1.X.0-k8sXXX as alternative but it's a little bit wired, and looks like unofficial.

Additional context
This is a part of volcano-sh/volcano#1704 .

cleanup useless tags

There is too much tags for the same version. Please clean the useless tags.

Remove `pkg` directory

Let's remove pkg, refer to https://github.com/kubernetes/api .

Please provide crd yamls for thoses crds

Is your feature request related to a problem? Please describe.

There is no cooresponding yaml defined with those crds when need, please see issue volcano-sh/volcano#2867

Describe the solution you'd like

a folder to put those crd yamls, like training-operator(tf,pytorch,mpi,etc): https://github.com/kubeflow/training-operator/tree/master/manifests/base/crds

Describe alternatives you've considered

It is avaiable at anytime

Additional context
none

Why are there two definition files of Queue and PodGroup in the apis/scheduling directory?

There are two definition files of Queue and PodGroup in the apis/scheduling directory, such as apis/scheduling/types.go and apis/scheduling/v1beta1/types.go. Both files are used in the code. Are there any design considerations？

If there are running jobs in the Volcano queue, is it permissible to directly delete the queue?

If the queue is deleted while there are still jobs in it, what issues will arise, and what kind of prompts or messages can be expected?

add label key `volcano.sh/task-index`

Is your feature request related to a problem? Please describe.
current, volcano task pod has label:

volcano.sh/job-name
volcano.sh/task-spec=worker

but missed task-index

task-index is important:

• get task-index from pod object label, instead of parsing pod name
• add a service by selector job-name task-spec task-index if someone need a k8s Service for a target task Pod
• mount env from labels as a TASK_INDEX; the env plugin provide env key VC_TASK_INDEX which user cannot custom the name.

Describe the solution you'd like

add a volcano.sh/task-index to pod label

Describe alternatives you've considered

I want to know the reason why task-index not set to pod annotation

Additional context

the kubeflow training-operator project provider those labels in the task pod:

training.kubeflow.org/job-name
training.kubeflow.org/replica-type=chief
training.kubeflow.org/replica-index=0

client can not get allocated filed of queue

Describe the bug
The queue has a filed allocated in CRD

but allocated is not defined in QueueStatus, So the field cannot be obtained through the client。

Expected behavior
Get allocated filed through client.

seperate the api and client

Describe the solution you'd like
move the client to another repo, and make the apis repo to be a pure api defination which does not depends k8s version.
users can generate the client themselves or use our client repo directly.

Move ClientSet and utilities to another repo

Is your feature request related to a problem? Please describe.
I don't want to add unused dependencies such as client-go and etc when I use controller-runtime to develop operators.

Describe the solution you'd like
I think it would be a good idea to move pkg/clientset and pkg/apis/helpers to another repo such as volcano/client-go like what istio/client-go did.

Additional context
There is no need to add replace statement in go.mod

create repo and update vendor

@Saba1119, where can i find the restful api?

          @Saba1119

• If you are using golang, you might want to use https://github.com/volcano-sh/apis
• If you are using java/scala, you might want to use https://github.com/fabric8io/kubernetes-client/tree/master/extensions/volcano/examples
• If you are using others, you might want to requet the restfull api directly

Originally posted by @Yikun in #60 (comment)

Why require 0.19.6, and then replace it with 0.18.3?

rt

Command and CommandList missing method DeepCopyObject

# volcano.sh/apis/pkg/apis/bus/v1alpha1
../../../pkg/mod/volcano.sh/[email protected]/pkg/apis/bus/v1alpha1/register.go:46:3: cannot use &Command{} (value of type *Command) as "k8s.io/apimachinery/pkg/runtime".Object value in argument to scheme.AddKnownTypes: *Command does not implement "k8s.io/apimachinery/pkg/runtime".Object (missing method DeepCopyObject)
../../../pkg/mod/volcano.sh/[email protected]/pkg/apis/bus/v1alpha1/register.go:47:3: cannot use &CommandList{} (value of type *CommandList) as "k8s.io/apimachinery/pkg/runtime".Object value in argument to scheme.AddKnownTypes: *CommandList does not implement "k8s.io/apimachinery/pkg/runtime".Object (missing method DeepCopyObject)