voxeet/voxeet-io-web

voxeet-io-web's Issues

Problem with automatically recognized meeting room name

We have requested several environments of the app and some of them require a trailing environment such as https://dev.voxeet.trydcc.com/staging/. It seems that when this link is used, the join form mistakenly takes /staging/ as the meeting room name, this is unexpected and should be fixed.

The join meeting form should take the last part of the URL without trailing slash as the intended meeting room name, if it didn't detect that name, it should present the user to manually enter the meeting room name.

Basically this problem prevents us from testing against the non-production Voxeet environment.

Suggestion: Prettier

I notice much of the code formatting is internally inconsistent. It would be great to adopt Prettier to auto-format the code.

Example: /backend/src/app.js

app.get("/api/invalidate", (req, res, next) => {
  let request = Object.assign({}, requests.invalidate);
  request.data = {
    'access_token': accessToken
  }

  return axios(request)
           .then(r => {
             return res.json("OK");
           })
           .catch(next);
});

app.get("/api/finished/:conferenceId", (req, res) => {
  console.log("received finished for: ", req.params.conferenceId);
  let request = Object.assign({}, requests.url);
  request.url = request.url.replace(/%conferenceId%/g, req.params.conferenceId);

  axios(request)
    .then((res) => console.log(res))
    .catch(e => console.error(e));

  return res.end();
});

This could be done by adding the following script in package.json:

  "scripts": {
    "prettier": "prettier --single-quote --write 'src/**/*.js'",
  },

Would this be a welcome change?

Typo in documentation

There is a typo in the VideoPresentationService documentation

VoxeetSDK.filePresentation.on("started", (e: FilePresentation) => {
  /* The video presentation has started. */
})

should be

const res = VoxeetSDK.videoPresentation.on("started", (e) => {
    /* The video presentation has started. */
  })
```

Remove Video Constraint to let WebSDK manage it

We need to remove video Constraint (videoRatio) by default to let the WebSDK handle the default Values.

unchecking "connect using default settings" in safari gives error

In safari and Voxeet.io, if you uncheck "connect using default settings", you get the loading page with the following error:
No audio device detected. Please make sure to plug at least one microphone to access this conference.

Document the environment variables available on both frontend and backend images

As a developer, I would like to know which environment variables should I configure on backend and frontend containers to make them work.
This documentation should be written in the readme.me files, and the environment variables available should appear in the Dockerfile with "ENV" instructions : a developer could know how to configure the container quickly just opening the Dockerfile.

Removed reference to /oauth2/refresh API call

As we have deprecated the /oauth2/refresh API call, we should remove the reference in the backend sample code as well.
https://github.com/voxeet/voxeet-io-web/blob/master/backend/src/app.js#L56

Yarn.lock file references private NPM repository

During a Docker build from scratch, I faced the following problem :

Sending build context to Docker daemon  4.995MB
Step 1/9 : FROM node:12 as build
 ---> b31738bd2a38
Step 2/9 : WORKDIR /app
 ---> Using cache
 ---> cd17ed078c2a
Step 3/9 : COPY . .
 ---> 13a5b22e6d31
Step 4/9 : RUN yarn install
 ---> Running in b59aaf52fc30
yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://stg-gke-eu.voxeet.net/nexus/repository/npm-group/react/-/react-16.9.0.tgz: Request failed \"401 Unauthorized\"".
info If you think this is a bug, please open a bug report with the information provided in "/app/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
The command '/bin/sh -c yarn install' returned a non-zero code: 1

This caused by the presence of some dependencies in yarn.lock file which are resolved from private repository : for instance "https://stg-gke-eu.voxeet.net/nexus/repository/npm-group/@babel/compat-data/-/compat-data-7.9.6.tgz#3f604c40e420131affe6f2c8052e9a275ae2049b"
"yarn.lock" file should only contain public dependencies and repositories in order that developers can build and run Voxeet.io on their own.

Is there any way to apply auto-join only to a list of users and the rest need to take permission from admin?

I wanted to auto join a list of trusted users but at the same time I need to allow any guest if the admin allows them via join prompt. I tried auto-join='true' for admin and auto-join='false' for participants but it didn't work.