vpavkin/gorefactor

refactoring tool for Go Programming Language

Hi, I'm Vladimir Pavkin!

I'm a Scala Developer and Functional Programming enthusiast.

Latest Blog Posts

• Aecor — Purely functional event sourcing in Scala. Part 6
• Aecor — Purely functional event sourcing in Scala. Part 5
• Aecor — Purely functional event sourcing in Scala. Part 4

➡️ More blog posts

Latest Talks

ZIO Inception. Journey through layers and intersection types (FunctionalWorld, 2020)

Aecor: Purely functional eventsourcing in Scala (Scalar, Warsaw, 2019)

➡️ More talks

gorefactor's Issues

support for inlining multiple returns

check method for correctness if inlined call is used as expression

method must contain one return statement

add extracted method name checking

name can already exist in current scope

unresolved symbols when type appears in other types declarations few times before it's parsed

add multiple args support to extractInterface refactoring

check for type assertions .(*FunctionTypeSymbol)

function can also have alias type symbol

"static" calls to types methods

http://golang.org/doc/go_spec.html#Expressions

section "Method Expressions"

bad globals parsing

fix parsing selectors at globals assignment

global variables during extract/inline method

don't treat them as parameters and warn user

Alias symbols have access to base type fields recursively.

function results

map does not assure correct order of results

fix package name renaming

when there is an import with a default name like:

import "st"

when renaming it, import decl must change to

import "st" newName

extern sources support

somehow allow user to define extern source folders.
for now goref.cfg file is the best option

typeSwitch variable search

now it is marked by Obj.Kind == -1.

what to do with exported fields which have private type

Example - package unicode:

type CaseRange struct {
        Lo    int
        Hi    int
        Delta d
}

for now types like d stay unresolved

go compiler message when calling an alias's method

package main

type T struct {
    X P
}
type P *T

func (p T) Meth(){
    p.X = new(T)
}

func Method2() {
    var ttt P = P(new(T));
    ttt.Meth();
    ttt.X = ttt;
}

compiler says following:
ttt.Meth undefined (type T has no field Meth)
but ttt has type P

extract method scope issue

1. when extracted code declares a symbol and not uses it (symbol is used later), compiler throws an error for the extracted method: symbol declared and not used.
2. when extracted code declares a symbol, and it is used later in non-extracted code, compiler throws error for this usage(s): undefined symbol_name

Objects

program sould set all objects manually

add ParenExpr and pointer type support for method expressions

like (*T).Method(...)

sym.Obj.Name

get rid of such gets. replace with sym.Name()

Ellipsis

in the function that has parameter ...T, this parameter has type []T

add reciever support

add support for -vl and -vc flags, to add reciever to extracted method

Imports support

program must locate imported packages, parse them and use to resolve names