vprtwn/bzgformviewcontroller

Forms with validation

bzgformviewcontroller's Issues

Either re-add the floating label field cell or remove the JVFloatLabeledTextField pod spec

Since you've dropped the floating label field cell, maybe pull the JVFloatLabeledTextField pod requirement

keyboard controls don't resize with device rotation

Add BOOL optional to BZGFormCell

A form should be valid when:

• all non-optional cells are valid
  and
• all optional cells are either valid or empty

Add numericText to BZGPhoneTextField

• numericText should return the textfield's text with non-numeric characters stripped.

BZGFormViewController arm64 compatibility

This controller crash at compile in iPad Air but no in iPad Simulator. The external libraries crash with errors:

libffi/ios/include/ffi_common.h:77:1: Unknown type name 'ffi_status'

any solution?

Importing BZGFormViewController.h should import cell headers

Problem with libPhoneNumber-iOS

I have this issue when I ran a "pod install" with both pod 'BZGFormViewController' 'BZGMailgunEmailValidation' inside.
Now, each time I try to build the application, compiler give me this error.
suggestions?
thanks a lot,
Dario

Text field should begin editing when user taps anywhere in a cell

i.e. tapping the "Email" label should begin editing the email text field.

Add checkmark tint support

Instead of using a cell accessory type, use a custom asset, drawn over the textfield's clear button

Add submit button footer view

Apply keyboard content offset when keyboard appears

Add showsValidationWhileEditing to BZGFormFieldCell

showsValidationStateWhileEditing should default to NO.
if YES, the field should display its validation state while the user is editing the textfield, i.e.

• red text when the field is invalid
• checkmark when the field is valid

A nice to have:
The infoCell should appear while the user is editing the field if shouldShowInfoCell is true and the user pauses for >1 sec. The info cell should disappear if the user starts typing again.

Add phone text field cell

Should autoformat input with ()-, maybe add a text property that returns the numeric phone number?

The layout doesn't fit to the iPad screen

Auto-update to latest Minor+Patch versions of Reactive Cocoa

In order to avoid

[!] Unable to satisfy the following requirements:
- `ReactiveCocoa (~> 2.2.4)` required by `BZGFormViewController (2.4.3)`
- `ReactiveCocoa (~> 2.3)` required by `Podfile`

when a project updates to a newer version of the Reactive Cocoa pod

`initWithCoder` not handled

Hi, and thanks for that component !

Btw, the initWithCoder method of BZGFormViewController isn't implemented.
That creates an infinite loop when its initializer is called.

As you can implement it or simply move style and formCellsBySection properties in the header file (and let developer initialize these values), I let you do the change :)

Remove ReactiveCocoa dependency

ReactiveCocoa isn't worth the extra dependency, since I'm only using it in BZGTextFieldCell.

Use isKindOfClass: instead of isMemberOfClass:

https://github.com/benzguo/BZGFormViewController/blob/master/BZGFormViewController/BZGFormViewController.m#l253

Always-valid field with disabled checkmark does not work

I have an optional field in my form (surname prefix 'von Damme' -> 'von' and 'Damme', very common in the Netherlands). I don't want to show a checkmark when no input is given, but the validation state must always be Valid so that an empty field is also accepted.

Sounds easy enough:

_prefixCell.validationState = BZGValidationStateValid;
_prefixCell.showsCheckmarkWhenValid = NO;

I do not use any validation block. It is however rendered incorrectly: it is indeed valid, but even before typing anything, it shows the checkmark.

Could you look into this?

Consider pulling in a validation framework like US2FormValidator?

I'm really liking this form controller you've built. I haven't ever worked with ReactiveCocoa before so it's a little unusual, but I think it could revolutionize the logic in view controllers.

I was curious if you've ever looked into integrating a beefier validation framework? I'll likely try to wire this into the US2FormValidator library since that's what we use internally already.

ScrollView Insets wrong calculation when change first responder

When I change the first responder between cells in the same section the scrollview edge insets are wrong and the scroll view pulls up.

How to disable login or sign up cell

I am able to change the state of login/ sign up cell to invalid. But how do I make it so that in function tableView:didSelectRowAtIndexPath I do not call the backend method if both are empty ?

How do I check the state of the cell there ?

It gives me '-[UITableViewCell validationState:]: unrecognized selector sent to instance 0x15cd2ad30'

Add BZGEmailTextFieldCell

Add showsCheckmark to BZGFormFieldCell

showsCheckmark should default to NO.
if YES, the cell shouldn't show a checkmark accessory view when the field is valid.

Add keyboard controls

See https://github.com/dasmer/BSKeyboardControls/

Migrate tests to Specta

Remove shouldShowInfoCell -> 2.0

shouldShowInfoCell supports an unnecessary use case (showing an info cell when the field is valid) and should be removed.

Better support for transparent nav bar

In general, try to achieve better parity with UITableViewController behavior

BZGFormFieldCell needs to remove itself from NSNotificationCenter upon dealloc

Be sure to invoke removeObserver: or removeObserver:name:object: before notificationObserver or any object specified in addObserver:selector:name:object: is deallocated.