vrcmarcos/python-deprecated

Python @deprecated decorator to deprecate old python functions

python-deprecated's Issues

Missing git tag

Your library should be tagged.

Could you, please, add the tag "v1.0.0" ?

TypeError: function() argument 1 must be code, not str

Expected Behavior

Subclass a class that is marked as deprecated shouldn't raises an error.

Actual Behavior

Subclassing a class that's deprecated raises a TypeError

>>> from deprecated import deprecated
>>> @deprecated
... class MyClass: pass
...
>>> class MyOtherClass(MyClass): pass
...
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: function() argument 1 must be code, not str
>>>

Environment

• Python version: 3.6

https://stackoverflow.com/questions/15155466/decorator-and-error-function-argument-1-must-be-code-not-str

Solution: use a class decorator when applied to a class ?

python-deprecated vs deprecated

Hi, I was exploring available options for a deprecation decorator in Python and found these (among others):

• "Python-Deprecated": https://github.com/vrcmarcos/python-deprecated (Pypi: https://pypi.org/project/Python-Deprecated/)
• "Deprecated": https://github.com/tantale/deprecated (Pypi: https://pypi.org/project/Deprecated/)

It seems both are pretty much the same.
As far as I understand "Deprecated" started as copy-paste of the code of "Python-Deprecated" in a new git repo (around Nov 2017).

If that is the case: wouldn't it be better to explicitly mark "Python-Deprecated" as deprecated (lol) and forward potential users to "Deprecated", both on github (e.g. in README) and on Pypi?

Release v1.1.0 on PyPi

Hi Marcos,

Could you release the v1.1.0 on PyPi?

First, update your local repository:

git fetch origin master
git reset --hard v1.1.0

Release and push to PyPi

python setup.py release upload