Compilation in progress feedback

[ncannasse]

Compilation in progress feedback

[Simn]

Alright, that did it. Thank you for the instructions!

[Simn]

I still see "Building Cache":

I'm not sure what a generic "Building" actually is/was.

[ncannasse]

When you Shift+Ctrl+B to compile

[Simn]

Ah yes, that I can confirm. Will have to check what changed here.

[ncannasse]

Ty if you can fix this, it's very hard now to tell if the build is ongoing or not

[Simn]

I'm not seeing that anymore when building Haxe itself either, so this might be some general VS Code thing. But I agree it's quite confusing to not have a clear indicator anywhere.

[kLabz]

When upgrading to Haxe development

But this implies it still works with earlier Haxe versions?
Will try to repro tonight

[Simn]

I can't see how this would be related to Haxe versions unless vshaxe has some if (haxeVersion == 5) doSomethingDifferent() code somewhere...

[kLabz]

Adding startProgress("Building"); before that line seems to do the trick; not sure what changed / what was doing that before.

Edit:
Could be linked to microsoft/vscode#192925 or microsoft/vscode#190987
Might need to update our tasks

[ncannasse]

I confirm btw that this is related to Haxe version, as if I switch between our Shiro branch (somewhere around ~4.2.5) and development the Building... disappear. Would be be great to have it fixed and pushed to a vshaxe release as we're planning to upgrade Haxe at Shiro very soon.

[kLabz]

Ok I know what's going on: vscode only shows the indicator if a task has problem matchers, and vshaxe doesn't use those with Haxe >= 4.3.

[Simn]

Keeping this open as a reminder to look into it again at some point, because the current solution doesn't seem quite right.

[ncannasse]

When can we expect a VSHaxe release @Simn @kLabz ? :)

[Simn]

I don't think I have the required access for making releases. IIRC the right person to ping here is @AlexHaxe.

[AlexHaxe]

Github actions will automatically release a new version when you tag a version number to a commit (obviously the new version number should already be in package.json at that point).

there is a chance our marketplace token expired, so we might need nadako to update it and then rerun the failed Publish task.

[ncannasse]

Up :) @nadako

[nadako]

Hm, I'm pretty sure I was renewing the token recently, can you guys try?

[Simn]

Oh I somehow thought Alex said it wasn't working. I just made a tag, let's see!

[Simn]

Well, looks like that wasn't it...

[publish](https://github.com/vshaxe/vshaxe/actions/runs/7253264612/job/19759499365#step:4:151)
Error: nadako.vshaxe v2.30.0 already exists.
    at _publish (/home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:3630:27)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async publish (/home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:3568:13)

[AlexHaxe]

sorry, was out sick the last few days.

for a new version version field in package(-lock).json needs to match and potentially submodule(s) need to be updated and maybe patch notes. then it should work (my read from the rejection message is that the token should still be valid)