vvanghelue/digits-server-client

Node.js alternative to Digits web "SDK"

digits-server-client's Issues

[Bug]: error is undefined when invalid verifyCode is submitted for verification

In order to find why error is undefined i viewed index.js and found that your are assigning

if (jsonBody.errors) {
   resolve({success: false, phone: token.phoneNumber, errors: errors});
}

errros:errors instead of errors:jsonBody.errors.

You can find above code over here

digits-server-client/index.js

Lines 198 to 200 in cde9d57

	if (jsonBody.errors) {
	resolve({success: false, phone: token.phoneNumber, errors: errors});
	}

UnhandledPromiseRejectionWarning

Hello,

I am receiving the warning below although the sendVerificationCode function is working properly and I am receiving the registrationToken, any idea?

(node:54611) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): ValidationError

logout

Hey @vvanghelue ,

thanks for reverse engineering the digits sdk ;) This looks quite nice. Did you find a way to logout from digits?

some error?

hello,i use it in my express server,then receive this error message
i don't what's problem with my server.

var express = require('express');
var router = express.Router();
var digitsClient = require('digits-server-client');
var digits = new digitsClient({
    digitsConsumerKey: '6r0jJn986AbE54Qgog4FBId8t',
    digitsHost: "http://www.webhunt.cn"
});
/* GET home page. */
router.get('/', function(req, res, next) {
	digits.sendVerificationCode({
	    phoneNumber: '1363264XXXX',
	    countryCode: 'CN'
	}).then(function (registrationToken) {
	    //eyJsb2dpblZlcmlmaWNhdGlvblJlcXVlc3RJZCI6InV... 
	    console.log(registrationToken);
	}).then(null, function (error) {
	    //error 
	    console.log(error);
	});
	// res.redirect("/users")
  res.render('index', { title: 'Express' });
});

module.exports = router;

receive this message

Unable to parse Digits cookies or authenticityToken in html.

Check for given arguments for sendVerificationCode

Hi,

Currently, when this method is called, it doesn't check for arguments validity. For example, if one omits the header field, an error will be raised (can't read property accept-languages of undefined) and the program will crash. Also, this doesn't make much sense if the phoneNumber field is omitted too.

I would be glad to open a PR for this but how do you want to handle this ? Return a rejected Promise with an error describing the troubles or directly throw into the method ?

Digits was shutdown on September 30, 2017

You have some idea to continue using this library?