vvo/concat-files

[DEPRECATED] Concatenate files asynchronously with node.js

Hi there 👋

Maker

• TurnShift: Automate Your Team Schedule
• Tweets @vvoyer: JavaScript, React, Next.js, Building In Public
• Next.js News: The Next.js Monthly Newsletter (sold)
• Source Karma: Discover how people react to you on GitHub 👍 (archived)

concat-files's Issues

Can we use a parameter to choice a delimiter?

I used this library to join js files. Works but does not apply a kind of separator or delimiter.
In my case I need a simple \n, because without that I have this error:

In this case, If I could use \n as delimiter, this will be the expected result:

/*file1*/
!function(t){"use strict";"function"==

/* file2
 Copyright (C) Federico Zivolo 2018
 Distributed under the MIT License (license terms are at http://opensource.org/licenses/MIT).
 */(function(e,t){'obje

Thanks for your time

Carriage returns in output on Linux

I loaded up the resulting file inside vim, and I see ^M after every line, original file does not have this.
Somehow \r\n is being added after every new line.
Cant see this character in Windows text editors.

WTF is this

Final size

Hey!

Would you accept a PR to show the final file size? We could use maxmin.

Handle files without trailing newline

If you append to files where the first doesn't have a newline at the end of the file, the last line of the first file and the first line of the second file will be on the same line. It would be nice to have an option to handle EOF as a newline.

For example

file1

test
test2

file2

test3

Will result in

test
test2test3

Unless a newline is added at the end of the first file. I would like an option to get the result

test
test2
test3

Without having to change the first file.

Max buffer size issues

I'm running into issues where the max buffer size is only ~2.1GB, so if the files I'm trying to concat end up being larger than 2.1GB it blows up with a max buffer size error. Anyway the code could be refactored to use streams, which I assume would be the solution then in that case?