vyleung/logseq-helium-plugin

a Logseq plugin to float items (e.g. videos) for an improved note-taking experience

logseq-helium-plugin's Issues

Increasing video width and diagonal makes balloon jump around

When pressing + to increase the video height and width, the balloon and controls move to the right as much as the video becomes larger.

When wanting to increase the video size multiple "clicks", it's not possible to double or triple click a few fimes as the controls will have moved after each click.

To prevent this behaviour, perhaps it is possible to fix the position of the controls relative to the right side of the screen instead of relative to the video?

Feature request: add the picture in picture function for video

This is useful for taking video notes

Change the size of Youtube video

l use Logseq 0.7.0 now and l find that l can't change the size of Youtube video.
Here is the youtube video link:https://www.youtube.com/watch?v=6Af6b_wyiwI
Here is my code to use it in the Logseq{{video https://www.youtube.com/watch?v=6Af6b_wyiwI}}
l hope the plugin can be updated to suit the latest version of Logseq. Thanks!

Daniel

Hi！ Can it be used with obsidian?

Hi！ Can it be used with obsidian?

Start Float Shortcut and Slash Command Doesn't Work.

I am using Helium in Logseq 0.9.10. I am able to Start Float using Right Click.

However other two methods like /Start Float and Shortcut after Selecting Block are not working for me.

However Stopping Float using same Shortcut Works Fine.

v 1.1.1 and v 1.0.1difference

Hello, the effect of the plugin is very nice, but there is a small problem. In the latest version of v.1.1.1, the video on my side can't be floated. I can use v1.0.1.Besides,my computer is win11. I really like this one you developed. plugin

Increasing the width shows a scroll bar

First of all, thank you @vyleung for this plugin, it's really useful!

I noticed a little issue today as shown in the following video:

2022-05-20.21-56-14.mp4

As you can see, whenever I try to increase the width, the video div seems to have a css property of overflow: scroll; or something like that. And the H button doesn't work and doesnt affect the height of the video.

I'm using logseq version 0.6.8 on my linux machine.

Remebering Height/Width across Video Sessions.

Is it possible to Remember Video Size across Various Float Sessions ?

I have a large Screen and it involves me resizing Video after every start to make it right Size. If Plugin could remember last Width or allow it to be Configured in Setting that would be of Great Help.

Trying to disable shortcuts conflicting with Vim Shortcuts extension

Vim Shortcuts plug Helium, trigger conflicts on shortcuts.

I tried to make some "empty" field in settings and now I am getting instead following error every time I open / refresh(re-index) Logseq Graph:

:plugin.logseq-helium-plugin/helium-skip-controls-R Cannot read properties of undefined (reading 'forEach')

Make keyboard shortcut optional

Hi, first of all, I want to say that this is a very useful plugin for video note taking!

But, I don't want to use a keybinding in this case so, can you make it optional?

Support for timestamps for other video sources (local, vimeo, LBRY, etc)

Currently [Ctrl]+[Shift]+[y] makes youtube-timestamps only working for yt.

• What about making it also for video files drag&droped / from local files (fro assets directory usually) ?

• What about making it also for other sites (e.g. vimeo, odysee / LBRY , BitChute, PeerTube, Internet Archive ... https://en.wikipedia.org/wiki/Comparison_of_video_hosting_services)

(simmilar but not exactly issue on Logseq feature requests: https://discuss.logseq.com/t/timestamping-of-all-kinds-of-videos-local-and-from-many-sites/14123 )

Some ideas

Could you insert :

• Checkpoint option (last minute played in a video)
• shortcut for speed accelleration

Pls 👀

Sometimes the plugin doesn't work

Like in this video:
https://github.com/vyleung/logseq-helium-plugin/assets/151181585/6026266a-b25c-42d3-b715-e513e1679f9d

Also can it work while having a pdf open?

Change the size of the windows of local video

Hope this function can be added!

Start float doesn't work and balloon does not appear since 0.9.11

I have a block like this:

- {{video https://youtu.be/ZRtdQ81jPUQ}}

The video doesn't have a balloon like it used to, and If I try to use the /Start Float slash command I get the following error in the development view:

caught (in promise) TypeError: Cannot read properties of null (reading 'id')
    at index.fca72f42.js:1:94513

Feature request: Enlarge or narrow with Proportion.

The helium-plugin is wonderful, which solve the problem with write video notes in logseq 🎉.
Any plan to add the function: Enlarge or narrow with Proportion?
This will improve efficiency, currently I need to increase the height then increase the width 🥲.

include fwd/rwd and speed buttons

hi!
would it be possible to add rewind and forward buttons? so when i play a video and i want to go back 10 seconds to listen to the same passage, i'd click the rewind button. also, setting the playback speed could be interesting!

thanks!

Plugin not functioning on 0.8.12

After the 0.8.12 update, my helium plugin has not been functioning. On the developer console, output reads "logseq-helium-plugin - ERROR: start float"

Problems when floating the video

My logseq version is 0.6.9 , it seems that after select the whole part of code of the video. l choose the start floating , but nothing happens. Can you give some more specific steps on how to float the video. Thanks!

My operating system is windows10 pro.

Helium seems do not work in 0.8.12

Is there a shortcut for speed controls? Can I open the video in the sidebar instead? Change the video size?

Hi , this is a great plugin thank you so much for your work.
I was wondering if these 3 things are possible? if not can you please add this feature?

Not works on 0.8.16

WIndows 10
logseq version: 0.8.16
Helium version: 2.1.1

Video does not remain visible in v2.1.2

Hi,

I can activate float-mode and the red balloon shows next to the video, however the video does not remain visible when I'm writing notes. The video simply scrolls out of view.
In the developer tools I see following error when I enable float-mode.

index.2869ea90.js:2 Uncaught TypeError: F.getPlayerState is not a function
    at index.2869ea90.js:2:89330
    at fn (index.2869ea90.js:2:71088)
    at index.2869ea90.js:2:72525
(anonymous) @ index.2869ea90.js:2
fn @ index.2869ea90.js:2
(anonymous) @ index.2869ea90.js:2
setTimeout (async)
o.DEFAULT_SET_TIMEOUT @ index.2869ea90.js:2
y @ index.2869ea90.js:2
(anonymous) @ index.2869ea90.js:2
setTimeout (async)
o.DEFAULT_SET_TIMEOUT @ index.2869ea90.js:2
y @ index.2869ea90.js:2
(anonymous) @ index.2869ea90.js:2
setTimeout (async)
o.DEFAULT_SET_TIMEOUT @ index.2869ea90.js:2
y @ index.2869ea90.js:2
v.setDriftlessSpyable @ index.2869ea90.js:2
v @ index.2869ea90.js:2
o.setDriftlessTimeout @ index.2869ea90.js:2
(anonymous) @ index.2869ea90.js:2
Promise.then (async)
V @ index.2869ea90.js:2
(anonymous) @ index.2869ea90.js:2
Promise.then (async)
(anonymous) @ index.2869ea90.js:2
Promise.then (async)
(anonymous) @ index.2869ea90.js:2
a.emit @ index.2869ea90.js:2
#lspmsg# @ index.2869ea90.js:2
(anonymous) @ index.2869ea90.js:2
postMessage (async)
call @ lsplugin.core.js:2
_callUserModel @ lsplugin.core.js:2
callUserModel @ lsplugin.core.js:2
a @ lsplugin.core.js:2
_hook @ lsplugin.core.js:2
hookEditor @ lsplugin.core.js:2
$cljs$core$js_invoke$$.$cljs$core$IFn$_invoke$arity$variadic$ @ core.cljs:534
$frontend$handler$plugin$hook_plugin$$ @ plugin.cljs:493
(anonymous) @ commands.cljs:477
$APP.$JSCompiler_prototypeAlias$$.$cljs$core$IFn$_invoke$arity$2$ @ core.cljs:11351
$frontend$commands$handle_steps$$ @ commands.cljs:680
$frontend$commands$exec_plugin_simple_command_BANG_$$ @ block.cljs:17
(anonymous) @ events.cljs:464
$APP.$JSCompiler_prototypeAlias$$.$cljs$core$IFn$_invoke$arity$1$ @ core.cljs:11345
$switch__29909__auto__$jscomp$179$$ @ events.cljs:958
$frontend$handler$events$run_BANG__$_state_machine__29910__auto____1$$ @ events.cljs:958
$cljs$core$async$impl$ioc_helpers$run_state_machine_wrapped$$ @ ioc_helpers.cljs:46
(anonymous) @ ioc_helpers.cljs:53
(anonymous) @ channels.cljs:65
$cljs$core$async$impl$dispatch$process_messages$$ @ dispatch.cljs:29
$channel$jscomp$1$$.port1.onmessage @ nexttick.js:190

Expected behaviour

With float-mode enabled, the video would remain visible at the top of the window as I'm adding more notes.

I'm using LogSeq v0.9.2 with Helium v2.1.2 on MacOSX Ventura v13.2.1.

Can the translation be added?

In order to improve the practicability of this plugin, l really hope a translation can be added. However ,since l am not a front engineer and l am not familiar with the js syntax and your code structure , it's hard for me to add the translation code. One of the logseq developers have made a lib for translation and here is the lib . Would you please integrate this to your plugin , and translate the English into Chinese? If you don't want to translate it, l can translate it too! Thank you very much!

Cursor exits the block when navigating through the video making it difficult to type

bandicam.2024-01-21.06-18-09-320.mp4

it works fine with the time stamp & pausing but whenever I navigate forward or backward through the video , I have to click in the block with the mouse again to be able to type