Giter Site home page Giter Site logo

Comments (17)

w0lfschild avatar w0lfschild commented on August 15, 2024 1

Fix should be live now. Version 2.0.3

from colorfulsidebar.

w0lfschild avatar w0lfschild commented on August 15, 2024

What version of macOS?

It does look like the icon is being themed, just not correctly, since that's the default Document icon.

from colorfulsidebar.

frac89 avatar frac89 commented on August 15, 2024

I use Mojave. I tried to add some paths to iCloud Drive (Like the one of MobileDocuments) to no avail.

from colorfulsidebar.

w0lfschild avatar w0lfschild commented on August 15, 2024

In icons14.plist edit the array

/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/iDiskGenericIcon.icns

and add the string

iCloud Drive

Screen Shot 2020-03-26 at 12 41 46 PM

from colorfulsidebar.

frac89 avatar frac89 commented on August 15, 2024

Still nothing, that's strange because before version 2 it used to work flawlessly.

from colorfulsidebar.

w0lfschild avatar w0lfschild commented on August 15, 2024

Did you restart Finder after making the changes?

from colorfulsidebar.

frac89 avatar frac89 commented on August 15, 2024

Yes I did.

from colorfulsidebar.

QrchackOfficial avatar QrchackOfficial commented on August 15, 2024

I can confirm this on 10.14.6 Mojave as well. I suspect the "address" with the x-applefinder-vnode part is not being picked up for some reason, so there's a generic icon instead. Same goes for Tags, how do we address those?

See here (Favourites are set to black on purpose, I'm using colorfulSidebar to change symlinks on ~/Movies and ~/Music from generic folder icons to the proper ones). Tags and iCloud Drive are not set. For iCloud Drive, I have:

  • cmdGoToICloud
  • x-applefinder-vnode:iCloud%20Drive
  • x-applefinder-vnode:iCloud

x-applefinder-vnode:iCloud Drive also wouldn't work. Moving the icon in Finder to Favourites also didn't change anything.

image

Is this a problem with the string in .plist, or do we need to update code to get that to work?

from colorfulsidebar.

QrchackOfficial avatar QrchackOfficial commented on August 15, 2024

This might be due to AMFI enabled, I'm on a Hackintosh here, so a bit nervous about adding nvram boot-args, but I'll test if I can get Clover to disable AMFI

from colorfulsidebar.

frac89 avatar frac89 commented on August 15, 2024

I tried to disable AMFI, but it still remains blank. Also disabling AMFI makes it so I can't give permissions to apps to use my camera/microphone or other apps for reasons unknown to me.

from colorfulsidebar.

w0lfschild avatar w0lfschild commented on August 15, 2024

It doesn't have to do with AMFI. PS if you have AMFI off read this > https://www.reddit.com/r/OSXTweaks/comments/fpes5q/unable_to_launch_xtrafinder_in_mojave/flksmhi?utm_source=share&utm_medium=web2x

If you delete this from the .plist does the issue persist?

<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/GenericDocumentIcon.icns</key>
<array>
	<string>SidebarGenericFile</string>
</array>

from colorfulsidebar.

QrchackOfficial avatar QrchackOfficial commented on August 15, 2024

It wasn't there from the beginning. I have cleared the plist out, so the only overrides are set explicitly by me. Therefore, no generic/smart folder/NS* entries.

from colorfulsidebar.

QrchackOfficial avatar QrchackOfficial commented on August 15, 2024

My current plist looks like so:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/iDiskGenericIcon.icns</key>
	<array>
		<string>iCloud Drive</string>
		<string>cmdGoToICloud</string>
		<string>x-applefinder-vnode:iCloud%20Drive</string>
		<string>x-applefinder-vnode:CloudDocs%20libraries</string>
		<string>x-applefinder-vnode:iCloud</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarMoviesFolder.icns</key>
	<array>
		<string>~/Movies</string>
		<string>/Volumes/Data/Movies</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarHomeFolder.icns</key>
	<array>
		<string>~/</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarPicturesFolder.icns</key>
	<array>
		<string>~/Pictures</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarMusicFolder.icns</key>
	<array>
		<string>~/Music</string>
		<string>/Volumes/Data/Music</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarDocumentsFolder.icns</key>
	<array>
		<string>~/Documents</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarDesktopFolder.icns</key>
	<array>
		<string>~/Desktop</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarDownloadsFolder.icns</key>
	<array>
		<string>~/Downloads</string>
	</array>
	<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/SidebarApplicationsFolder.icns</key>
	<array>
		<string>/Applications</string>
	</array>
</dict>
</plist>

from colorfulsidebar.

frac89 avatar frac89 commented on August 15, 2024

It doesn't have to do with AMFI. PS if you have AMFI off read this > https://www.reddit.com/r/OSXTweaks/comments/fpes5q/unable_to_launch_xtrafinder_in_mojave/flksmhi?utm_source=share&utm_medium=web2x

If you delete this from the .plist does the issue persist?

<key>/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/GenericDocumentIcon.icns</key>
<array>
	<string>SidebarGenericFile</string>
</array>

Thanks for the AMFI tip, I'll make sure to try it.

Anyway, the iCloud icon still stays blank.

from colorfulsidebar.

qkdreyer avatar qkdreyer commented on August 15, 2024

Not having any issues with iCloud Drive using macOS Catalina 10.15 (19A582a) here.
Thanks for the 2.0.1 update @w0lfschild btw, the previous NSLog were frustrating :)

from colorfulsidebar.

cryo-kronos avatar cryo-kronos commented on August 15, 2024

iCloud icon is blank for me on macOS Mojave 10.14.6.

from colorfulsidebar.

w0lfschild avatar w0lfschild commented on August 15, 2024

Okay think I've got a fix for this ready to go out soon.

from colorfulsidebar.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.