Giter Site home page Giter Site logo

Comments (6)

r12a avatar r12a commented on May 23, 2024

I believe it's because you set the example class on the pre element as well as the div element that contains it. It seems that this redundancy is generated by respec. I would certainly think that one example class should be sufficient.

from tr-design.

iherman avatar iherman commented on May 23, 2024

The original, respec code is:

      <pre class="example highlight">
{
  "name": "inventory_date",
  "titles": "Inventory Date",
  "dc:description": "The date of the operation that was performed.",
  "datatype": {
    "base": "date",
    "format": "M/d/yyyy"
  }
}
      </pre>

Ie, it is definitely respec that adds both. But one would expect that changing the style sheet would not lead to such differences anyway...

from tr-design.

halindrome avatar halindrome commented on May 23, 2024

Hmm. We could change respec so that when it wraps the example in a div
it removes the class example from the pre... but that feels weird.

On Wed, Nov 11, 2015 at 2:33 AM, Ivan Herman [email protected]
wrote:

The original, respec code is:

  <pre class="example highlight">

{
"name": "inventory_date",
"titles": "Inventory Date",
"dc:description": "The date of the operation that was performed.",
"datatype": {
"base": "date",
"format": "M/d/yyyy"
}
}

Ie, it is definitely respec that adds both. But one would expect that
changing the style sheet would not lead to such differences anyway...


Reply to this email directly or view it on GitHub
#26 (comment).

Shane McCarron
[email protected]

from tr-design.

fantasai avatar fantasai commented on May 23, 2024

While I can work around this ReSpec issue in the style sheet sort-of (by replacing all occurrences of
.example' with ':not(.example) > .example', which will catch most cases of this ReSpec output), it does seem redundant to me to have the example class on both elements. I would prefer that ReSpec remove the nested 'example' class. On the off chance you need to style PRE blocks inside examples specially, it's very easy to do with '.example pre'.

Let me know what you think.

from tr-design.

halindrome avatar halindrome commented on May 23, 2024

I addressed this in my support for your stylesheets.

On Mon, Nov 30, 2015 at 1:55 PM, fantasai [email protected] wrote:

While I can work around this ReSpec issue in the style sheet sort-of (by
replacing all occurrences of
.example' with ':not(.example) > .example', which will catch most cases of
this ReSpec output), it does seem redundant to me to have the example class
on both elements. I would prefer that ReSpec remove the nested 'example'
class. On the off chance you need to style

blocks inside examples specially, it's very easy to do with '.example pre'.

Let me know what you think.


Reply to this email directly or view it on GitHub
#26 (comment).

Shane McCarron
[email protected]

from tr-design.

fantasai avatar fantasai commented on May 23, 2024

Excellent. I'll close the issue then.

from tr-design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.