Giter Site home page Giter Site logo

Comments (18)

wagnerdelima avatar wagnerdelima commented on May 13, 2024 1

Sorry for the late reply. I will loook into this a bit later next week if I can. I am extremely busy with work right now.

from drf-social-oauth2.

ecakashjadhav avatar ecakashjadhav commented on May 13, 2024

same issue

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 13, 2024

@MidoCobra and @ecakashjadhav, did you manage to overcome this?

from drf-social-oauth2.

ecakashjadhav avatar ecakashjadhav commented on May 13, 2024

@wagnerdelima No. I used another library.
Thanks

from drf-social-oauth2.

ecakashjadhav avatar ecakashjadhav commented on May 13, 2024

@wagnerdelima Can you add documentation for signing with apple?. Because python-social-auth is not clear documentation for apple.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 13, 2024

Hi @ecakashjadhav,

I will work on this in the future, promise. However, as of now, I believe the framework needs attention in other areas. I know, python-social-auth sometimes does not support a few backends, so there is no way around that.

from drf-social-oauth2.

ecakashjadhav avatar ecakashjadhav commented on May 13, 2024

@wagnerdelima Thanks for quick response

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 13, 2024

@ecakashjadhav my pleasure.

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 13, 2024

@ecakashjadhav how exactly do I replicate this issue in my local environment?

from drf-social-oauth2.

ecakashjadhav avatar ecakashjadhav commented on May 13, 2024

Create a user with a simple email and password. Then that same email using try to sign with Facebook

from drf-social-oauth2.

MidoCobra avatar MidoCobra commented on May 13, 2024

@MidoCobra and @ecakashjadhav, did you manage to overcome this?

Sorry for being away for a long time...
Actually I did not, as the project stopped...
but it is still published .. you may try to register on it to figure the problem and test it for further improvement for your great project.. www.marchpart.com

Thanks a lot

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 13, 2024

Thank you!

from drf-social-oauth2.

fahedmahidi avatar fahedmahidi commented on May 13, 2024

Where are we on this issue ? Actually several other users (including myself) are having this issue.

Several opened tickets are mentioning it, namely : #131 and #147

in #131 you might find the beginning of an answer, or a clue about what is going wrong :

"So I went into drf_social_oauth2/views/ConvertTokenView.post() to manually remove the PS1 header from the response headers and it works fine. I know this isn't ideal so I'd like suggestions for a better way. If this is a bug on the module, please get it fixed."

All the best !

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 13, 2024

I am closing this issue. You can handle password-based authentication in your backend. It's not drf-social-oauth's responsibility to deal with it, since it already deals with multiple social backend's sign-in.

from drf-social-oauth2.

ecakashjadhav avatar ecakashjadhav commented on May 13, 2024

@wagnerdelima Thanks!

from drf-social-oauth2.

bilal-nexquery avatar bilal-nexquery commented on May 13, 2024

Same issue!! Is the issue resolved yet?
If we have a custom user of same email which we are trying to login with social accounts.
/convert-token throws an error of [Auth/convert-token returns 500 internal server error when email is already registered.]

from drf-social-oauth2.

wagnerdelima avatar wagnerdelima commented on May 13, 2024

@MidoCobra @ecakashjadhav @fahedmahidi @bilal-nexquery,

If you have a customer user you will need to handle the duplicate email address on your backend. drf-social-oauth2 does not save the email address. Here is one example:

  1. I created one user in my django admin with my personal email address.
  2. I fired a request to google and to facebook backends via /convert-token endpoint.
  3. All requests are successful.

image

As you can see, the the email field is empty:

image

Let me know if there is another way to replicate this.

from drf-social-oauth2.

bilal-nexquery avatar bilal-nexquery commented on May 13, 2024

@wagnerdelima Thanks for your time and efforts.
I believe this will still throw an error if you have (username field as email) in your CustomUser model.
This is because if you register user using an email registered with your social account first and then send a request to convert/token.
It will throw error as it will try to save the user with email address already present in your db and being unique field it will return with an error.
I am also personally looking in this issue will update if any solution is found.

from drf-social-oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.