Comments (8)
This might be fixed by 4663490, but the msvcrt locking mechanism is completely untested.
from pytmdb3.
some problems...
the code should have been:
LOCK_EX = msvcrt.LK_NBLCK
LOCK_SH = msvcrt.LK_NBLCK
from pytmdb3.
prepending /tmp/ to the start of a path isn't windows \tmp\ path friendly.. os.path.join should fix that up quick.
also there might be driveletter: or unc \ formatting for an absolute path
from pytmdb3.
Now that I have it running, I'm getting permission errors:
\cache_file.py", line 60, in enter
msvcrt.locking(self.fileobj.fileno(), self.operation, self.size)
IOError: [Errno 13] Permission denied
from pytmdb3.
Now that I'm thinking about it, those locks should probably be LK_LOCK, so it waits for dedicated access rather than outright fails.
The filename handling does need to be improved, as at current, only caches located in a user's home directory with a '~' would pass the logic. I assume Windows absolute paths would either start with ":" or "\server"?
from pytmdb3.
I would think c:, \server and \path would all be valid.. but it's going to need a default also I think /tmp/ wouldn't work.
from pytmdb3.
263d868 adds an independent chunk of logic for Windows systems, based off the module import test. Variables are replaced into the path, and anything starting with lettered drives and ':', or a UNC server are passed through. Everything else gets the %TEMP% directory prepended. That still leaves the issue as to why locking itself is not working.
from pytmdb3.
I'm still getting a bunch of permissions denied on the windows side.... didn't really have the time to look closer at it.
from pytmdb3.
Related Issues (20)
- Request params encoded using system encoding HOT 8
- Library broken with non-ascii country names in alternate titles HOT 2
- release HOT 3
- IndexError: list index out of range HOT 3
- tmdb3 + mythbuntu do not funcion HOT 1
- I can't upgrade HOT 3
- pytmdb3 will not accept my api_key HOT 2
- location support for releasedate? HOT 1
- throttling requests to tmdb backends
- freebsd package being selected from pip HOT 14
- Error on pip install (README.md not included in package) HOT 3
- /person/${id}/credits is obsolete
- Error importing tmdb3 HOT 1
- FileCacheObjects are not garbage collected
- Add missing status codes HOT 1
- search TV-series
- Get all of the TV-series
- Thread safe HOT 1
- Adult Search
- Pytmdb3 falling through to English when no Russian metadata is available HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytmdb3.