wagtail-packages/wagtail-qrcode

This package can be used to create a page in Wagtail CMS that has a corresponding QR Code.

wagtail-qrcode's Issues

Add more options around emailing

Be nice to be able to customise the email message when sending the qr-code

Other ideas

• Multiple email recipients
• Custom action rather than sending on save draft or publish

QRCode hook throws seg fault if page is not live

In lines 29 and 30 of wagtail_hooks.py,

rev = page.save_revision()
rev.publish()

will throw seg fault if page has not been published (e.g. draft status)

My workaround is

rev = page.save_revision()
if page.live:
    rev.publish()

The delete qr-code eps hook cannot find the id of the document when a proxy page is called

When deleting a page, this code is called

@hooks.register("after_delete_page")
def delete_document(request, page):
    doc = get_document_model().objects.filter(id=page.qr_code_eps.id)
    if doc:
        doc.delete()

However, when a proxy page model is called, this throws a seg fault, complaining that
"'NoneType' object has no attribute 'id'".

My money patch is to change page.qr_code_eps.id to page.specific.qr_code_eps.id.

@hooks.register("after_delete_page")
def delete_document(request, page):
    if hasattr(page, 'qr_code_eps') and page.specific.qr_code_eps:
        doc = get_document_model().objects.filter(id=page.specific.qr_code_eps.id)
        if doc:
            doc.delete()

Save as draft doesn't work

If you choose to save a page as a draft it gets published.

The workaround is to un-publish the page.

A fix will be made available soon.

Hook triggers for all pages error

https://github.com/nickmoreton/wagtail-qrcode/blob/c71a308bd683f76fd01920bf4f9586ae2df17c86/wagtail_qrcode/wagtail_hooks.py#L17

This triggers for all pages. Make sure it only triggers for pages inheriting from https://github.com/nickmoreton/wagtail-qrcode/blob/c71a308bd683f76fd01920bf4f9586ae2df17c86/wagtail_qrcode/models.py#L20

Make different Wagtail versions better

https://github.com/nickmoreton/wagtail-qrcode/blob/5f059918a9a790a9d959c0621570d336f2de9f45/wagtail_qrcode/models.py#L60

I think here it could be implemented with a Wagtail VERSION conditional and use either a DocumentChooserPanel or FieldPanel

Maybe the extra documentation about this is no longer required: #17

Config Typo

https://github.com/nickmoreton/wagtail-qrcode/blob/5d7febb5058ed5063b7f036e9caae57be01c80dd/wagtail_qrcode/cls.py#L34

This is a typo but it's not affecting the package in any way.

I suggest it's fixed in the next update. It's also shown in the docs so update that too.

Improve documentation

When using the package on a Wagtail <3 the mixin panels don't work correctly.

https://github.com/nickmoreton/wagtail-qrcode/blob/5f059918a9a790a9d959c0621570d336f2de9f45/wagtail_qrcode/models.py#L60

e.g. if this was in use on a Wagtail v2.15/2.16 site then it should be a DocumentChooserPanel

It's possible to add your own panels but it's not documented yet.

This could be fixed in #21