Giter Site home page Giter Site logo

[Bug]: Lua-Error 143 about diminish HOT 6 CLOSED

wardz avatar wardz commented on May 20, 2024 2
[Bug]: Lua-Error 143

from diminish.

Comments (6)

mattecc avatar mattecc commented on May 20, 2024 1

So I got this too and was able to debug it a bit.

Icons:AnchorPartyFrames() is now getting called before PLAYER_LOGIN_EVENT in response to the hook on EditModeManagerFrame/OnSystemSettingChange (presumably new in 10.0.5) So the Diminish db isn't yet initialized.

I was able to workaround the bug by making a small modification:

Diminish.lua around line 274...

old:
Icons:AnchorPartyFrames()

new:
if NS.db then Icons:AnchorPartyFrames() end

I don't know the code well enough to know if this is a proper fix, but if its wrong it probably only affects detection of switching between party and raid style frames without a reload.

It works for me well enough, but your mileage may very. Hope this helps...

from diminish.

Natlyz avatar Natlyz commented on May 20, 2024

Hello! I'm getting this error too. I have Diminish attached to the nameplates.

7x Diminish/core/icons.lua:143: attempt to index field 'db' (a nil value)
[string "@Diminish/core/icons.lua"]:143: in function `AnchorPartyFrames'
[string "@Diminish/Diminish.lua"]:274: in function <Diminish/Diminish.lua:272>
[string "=[C]"]: in function `OnSystemSettingChange'
[string "@FrameXML/EditModeSystemTemplates.lua"]:1914: in function `UpdateSystemSettingOrientation'
[string "@FrameXML/EditModeSystemTemplates.lua"]:1934: in function `UpdateSystemSetting'
[string "@FrameXML/EditModeSystemTemplates.lua"]:277: in function `UpdateSystem'
[string "@FrameXML/EditModeSystemTemplates.lua"]:1886: in function `UpdateSystem'
[string "@FrameXML/EditModeManager.lua"]:1039: in function `UpdateSystem'
[string "@FrameXML/EditModeManager.lua"]:1027: in function <FrameXML/EditModeManager.lua:1026>
[string "=[C]"]: in function `secureexecuterange'
[string "@FrameXML/EditModeManager.lua"]:1029: in function `UpdateSystems'
[string "@FrameXML/EditModeManager.lua"]:899: in function `UpdateLayoutInfo'
[string "@FrameXML/EditModeManager.lua"]:238: in function <FrameXML/EditModeManager.lua:235>

Locals:
self = <table> {

from diminish.

Natlyz avatar Natlyz commented on May 20, 2024

Well, that removed the error that I get when I log in, but now I'm not sure the addon will work properly. Testing required 😅

from diminish.

wardz avatar wardz commented on May 20, 2024

Should be fixed now in v2.5.9.

from diminish.

Natlyz avatar Natlyz commented on May 20, 2024

Thanks!

from diminish.

Ssesmar avatar Ssesmar commented on May 20, 2024

ty

from diminish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.