Giter Site home page Giter Site logo

diminish's Introduction

Diminish (Discontinued)

Diminish attaches icons to unit frames or nameplates, displaying time left until a diminishing returns category expires for that unit. As well as how far the category is diminished. (Green border = 50% duration, yellow = 25%, red = 0%)

Diminish can track DRs on both mobs and players if you enable PvE mode in the options.

Note: Diminish is no longer actively maintained. Feel free to fork this addon, but be wary it contains a ~10 year old codebase with lots of hacky methods added over time. Some code might rely on deprecated Blizzard functions that's marked for removal in a future patch. (The DR spell database itself has moved over to DRList-1.0 which is still updated every now and then).

Configuration

Type /diminish to open the options panel. You may also skin the icons using Masque.

DR icons for each unit frame is separately configurable. Certain unit frames are default disabled for tracking or only enabled for certain zones.

You can manually set icons used for a DR category by right clicking one of the checkboxes under "Enabled Categories" section.

Notes

  • Diminish not working with an unitframe addon? Go to options and enable "Anchor to UIParent", then position the icons wherever you want. For Party frames, try disabling "Use Raid-Style Party Frames" under WoW's interface options.
  • Supports tracking max 5 party/raid frames.

Links

Installing from source is not always guaranteed to work. You should download a packaged version here instead:

License

Copyright (C) 2023 Wardz | MIT License.

diminish's People

Contributors

jquick avatar sweepyboop avatar wardz avatar wetxius avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

diminish's Issues

[Bug]: Nameplate DRs inaccurate on WotLK Classic

What happened?

Sometimes shows incorrect DRs on WotLK classic (doesn't match Gladdy, Gladdy shows correct timers). For example, can sometimes fear into a "red" Diminish DR icon and will get a 2.5s fear, where it should be immune.

Is there any errors?

No response

Game Version

Wrath of the Lich King

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Not sure.

Any additional info?

No response

Track only our DR ?

Hi folks :)

I was wondering if it is possible to have a checkbox option that only track our own dr not our arena friend dr to ?
I mean i don't know all the class spell icon actually and when i see a dr that it not mine (without showing category) i can't even know from what school this dr come from.

It would be very cool if when a friend start the dr cycle it instantly show my own spell that is impacted by the DR not his spell.

I hope it is clear enought... :p

[Feature Request] static icons

Hey. First of all i wanna thank you for this great Addon.
But i have a problem. I use 2 Icons (Stun and Incapacitates) and since the icons always change (depends on last spell) it can be hard sometimes to know what is what. Especially if you often play with different people/classes. There are so much different icons in the game for stuns or Incapacitates.
I would LOVE if i could just use MY 2 Spells for that icons. I would use the Hex icon for Incapacitates and the Lightnin Lasso Icon for Stun.
Is it possible to add a feature, where i can chose my own icon for each DR category?

Thats how i use the addon atm:
image

I know there is an option where i can show a DR category label but my i cons are too small and i would like to keep it as clean and simple as possible.

[Bug]: Opener stuns not showing.

What happened?

Opener stun Diminishing returns aren't showing. If I use cheap shot. It doesn't appear on my nameplates on the Wotlk PTR.

Is there any errors?

No response

Game Version

The Burning Crusade Classic

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

No.

[Bug]: Lua-Error 143

What happened?

Everytime i starting the game i get this error

Is there any errors?

Message: Interface/AddOns/Diminish/core/icons.lua:143: attempt to index field 'db' (a nil value)
Time: Wed Jan 25 13:34:49 2023
Count: 1
Stack: Interface/AddOns/Diminish/core/icons.lua:143: attempt to index field 'db' (a nil value)
[string "@Interface/AddOns/Diminish/core/icons.lua"]:143: in function `AnchorPartyFrames'
[string "@Interface/AddOns/Diminish/Diminish.lua"]:274: in function <Interface/AddOns/Diminish/Diminish.lua:272>
[string "=[C]"]: in function `OnSystemSettingChange'
[string "@Interface/FrameXML/EditModeSystemTemplates.lua"]:1914: in function `UpdateSystemSettingOrientation'
[string "@Interface/FrameXML/EditModeSystemTemplates.lua"]:1934: in function `UpdateSystemSetting'
[string "@Interface/FrameXML/EditModeSystemTemplates.lua"]:277: in function `UpdateSystem'
[string "@Interface/FrameXML/EditModeSystemTemplates.lua"]:1886: in function `UpdateSystem'
[string "@Interface/FrameXML/EditModeManager.lua"]:1039: in function `UpdateSystem'
[string "@Interface/FrameXML/EditModeManager.lua"]:1027: in function <Interface/FrameXML/EditModeManager.lua:1026>
[string "=[C]"]: in function `secureexecuterange'
[string "@Interface/FrameXML/EditModeManager.lua"]:1029: in function `UpdateSystems'
[string "@Interface/FrameXML/EditModeManager.lua"]:899: in function `UpdateLayoutInfo'
[string "@Interface/FrameXML/EditModeManager.lua"]:238: in function <Interface/FrameXML/EditModeManager.lua:235>

Locals: self = <table> {
 FindCompactRaidFrameByUnit = <function> defined @Interface/AddOns/Diminish/core/icons.lua:93
 StopCooldown = <function> defined @Interface/AddOns/Diminish/core/icons.lua:695
 AnchorPartyFrames = <function> defined @Interface/AddOns/Diminish/core/icons.lua:142
 UpdatePositions = <function> defined @Interface/AddOns/Diminish/core/icons.lua:211
 StartCooldown = <function> defined @Interface/AddOns/Diminish/core/icons.lua:630
 HideAll = <function> defined @Interface/AddOns/Diminish/core/icons.lua:547
 ReleaseNameplate = <function> defined @Interface/AddOns/Diminish/core/icons.lua:535
 GetFrame = <function> defined @Interface/AddOns/Diminish/core/icons.lua:431
 ReleaseFrame = <function> defined @Interface/AddOns/Diminish/core/icons.lua:558
 CreateUIParentOffsets = <function> defined @Interface/AddOns/Diminish/core/icons.lua:288
 OnFrameConfigChanged = <function> defined @Interface/AddOns/Diminish/core/icons.lua:475
 FindPartyFrameByUnit = <function> defined @Interface/AddOns/Diminish/core/icons.lua:120
 GetAnchor = <function> defined @Interface/AddOns/Diminish/core/icons.lua:22
}
members = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'db' (a nil value)"
NS = <table> {
 DR_TIME = 18.500000
 Timers = <table> {
 }
 CleanupDB = <function> defined @Interface/AddOns/Diminish/helpers.lua:33
 IS_CLASSIC = false
 Diminish = Frame {
 }
 RemoveTable = <function> defined @Interface/AddOns/Diminish/helpers.lua:79
 NewTable = <function> defined @Interface/AddOns/Diminish/helpers.lua:72
 IS_NOT_RETAIL = false
 ReleaseTables = <function> defined @Interface/AddOns/Diminish/helpers.lua:85
 DR_STATES_COLORS = <table> {
 }
 anchors = <table> {
 }
 Icons = <table> {
 }
 iconFrames = <table> {
 }
 DEFAULT_SETTINGS = <table> {
 }
 CopyDefaults = <function> defined @Interface/AddOns/Diminish/helpers.lua:16
 GetAuraDuration = <function> defined @Interface/AddOns/Diminish/helpers.lua:53
 useCompactPartyFrames = false
 CATEGORIES = <table> {
 }
}
Icons = <table> {
 FindCompactRaidFrameByUnit = <function> defined @Interface/AddOns/Diminish/core/icons.lua:93
 StopCooldown = <function> defined @Interface/AddOns/Diminish/core/icons.lua:695
 AnchorPartyFrames = <function> defined @Interface/AddOns/Diminish/core/icons.lua:142
 UpdatePositions = <function> defined @Interface

Game Version

Retail

Game Language

German

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

No response

Tracking DR categories by default icon

Just using this for feedback since thats what the first page link for feedback sends me to.

But eh, simple request really.. can we get an option to show DR categories not by using a text but rather by using a default set of icons based on the players currently played class?

What I mean is that I don't want a paladins HoJ to show up as a HoJ icon when im playing a Rogue, I want it to show as either a Cheap Shot or Kidney Shot icon. And for any DR school the players class has no access to a general icon can be used.. as long as it is the same one everytime. Same with Sheep and Sap, or Fear and Blind. Just to show the Sap icon for a Sheep and show the Blind icon for a Fear.

It makes no difference for veteran players, but for less experienced ones I think this is a major deal

Classic Era Support

Hi,
first of all, great addon!
Can you update for the latest Classic Era Version please?
Thanks in advance!

Not tracking mortal coil and fear

Hello,

Would love to use this addon to display DRs over nameplates in area and it is working for my shadowfury but not my coil or fear.

Please advise.

Player DR not being tracked.

Hey, since BFA Diminish doesn't seem to track dimishing returns on PLAYER and TARGET - arena one works fine. Is that known issue or have I fucked something with setting it up?

[Suggestion] Sound Alert on DR expiring.

Could we please get the ability to have a sound alert attached to various types of diminishing returns expiring on ourselves/enemies? it would really help me and a lot of others have improved awareness im sure.

If possible It could be nice to have the option to have it alert us x seconds before it expires too to plan ahead. Thanks !

[Bug]: blocks GLadiusEx

What happened?

Soon as i activate the newest version of Diminish. i cant use gladiusEx any longer.
Do you have an idea whats the root-cause behind?
All other addons dont block it - just diminish. For Retail PvP thats huge.

Is there any errors?

No response

Game Version

Retail

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

No response

"Unleashed Shield" should not be a Root-DR

What happened?

There is a PvP Talent from Shaman, called "Unleashed Shield":

https://www.wowhead.com/spell=356736/unleash-shield

Its like a kick-root (when both shields are active) but actually its NOT on the root DR.
Idk why they did it but it has its own DR.

In your Addon its in the root-DR-group. Would be great if you could remove it from there, because right now its it is very irritating when i play with actual roots like Earthgrab Totem, because the DR timer is always wrong.

Is there any errors?

No response

Game Version

Retail

Game Language

German

Does the issue still occur when all other addons are temporarily disabled?

None

Any additional info?

No response

[Bug]: No longer working on WotLK classic in TOGC patch

What happened?

Addon does not appear to throw bugs (except when using the test functionality) but simply does not add DRs to nameplates or frames anymore.

Is there any errors?

1x Diminish_Options/testmode.lua:160: attempt to call method 'UseRaidStylePartyFrames' (a nil value)
[string "@Diminish_Options/testmode.lua"]:160: in function `ToggleArenaAndPartyFrames'
[string "@Diminish_Options/testmode.lua"]:376: in function `Test'
[string "@Diminish_Options/main.lua"]:274: in function <Diminish_Options/main.lua:264>

Locals:
self = Frame {
 ToggleArenaAndPartyFrames = <function> defined @Diminish_Options/testmode.lua:108
 IsTesting = <function> defined @Diminish_Options/testmode.lua:100
 pool = <table> {
 }
 IsAnchoring = <function> defined @Diminish_Options/testmode.lua:104
 IsTestingOrAnchoring = <function> defined @Diminish_Options/testmode.lua:96
 ShowAnchors = <function> defined @Diminish_Options/testmode.lua:327
 Test = <function> defined @Diminish_Options/testmode.lua:356
 0 = <userdata>
 HideAnchors = <function> defined @Diminish_Options/testmode.lua:218
 CreateDummyAnchor = <function> defined @Diminish_Options/testmode.lua:235
}
state = true
forceHide = nil
settings = <table> {
 nameplate = <table> {
 }
 player = <table> {
 }
 focus = <table> {
 }
 target = <table> {
 }
 arena = <table> {
 }
 party = <table> {
 }
}
showFlag = true
useCompact = false
(*temporary) = nil
(*temporary) = <table> {
 IsEditModeActive = <function> defined @SharedXML/Stubs.lua:7
}
(*temporary) = "attempt to call method 'UseRaidStylePartyFrames' (a nil value)"
isTesting = false
isAnchoring = false
L = <table> {
 WATCHFRIENDLY_TOOLTIP = "Toggle diminishing returns tracking for friendly players. (Cast by enemy onto friendly)

Enabling this may drastically increase memory usage in large Battlegrounds."
 ATTACH_PERSONAL_NAMEPLATE = "Anchor To Personal Nameplate"
 DEFAULT = "Default"
 SELECTBORDER_TOOLTIP = "Choose between different border textures for the icons. You may also skin the icons using Masque."
 PARTY = "Party"
 ANCHORDRAG = "%s
Grows: %s"
 RESETPOS_TOOLTIP = "Reset icon positions for this unitframe back to default values."
 COPY_TOOLTIP = "Copies settings from one existing profile into the currently active profile."
 NAMEPLATE = "Nameplates"
 RESETPROFILE = "Reset Profile"
 HEADER_CATEGORIES = "Enabled Categories"
 COMPACTFRAMES_ERROR = "Unable to test raid frames while not in a group."
 GROW_RIGHT = "Right"
 PROFILEACTIVE = "That profile is already active."
 COMBATLOCKDOWN_ERROR = "Must leave combat or battleground before doing that."
 UNLOCK = "Toggle Moving Frames"
 TRACKNPCS_TOOLTIP = "Enable diminishing returns tracking for mobs and player pets. (Target/Focus/Nameplates)

Enabling this may drastically increase memory usage in large battlefields. In classic WoW this will only enable pet tracking."
 DELETE_TOOLTIP = "Delete an existing profile. Deletes and resets to default if the profile chosen is the currently active one."
 TEST = "Toggle Test Mode"
 TIMERTEXT_TOOLTIP = "Toggles the cooldown countdown text for all timers.

(Esc -> Interface -> ActionBars -> Show Numbers for Cooldowns)"
 ATTACH_PERSONAL_NAMEPLATE_TOOLTIP = "Attaches DR icons to your own personal resource display nameplate instead of the player frame."
 TIMERSWIPE = "Show Swipe for Cooldowns"
 TARGETTIP = "Target/focus yourself to see all frames."
 HEADER_ICONS = "Icons"
 COLORBLIND_TOOLTIP = "Show DR indicator numbers next to icons. 1 = first DR, 2 = second DR, 3 = last DR. May not work with some Masque skins.
(Color Blind Mode)"
 ICONSIZE_TOOLTIP = "Set the size of the icons."
 TIMERTEXTSIZE_TOOLTIP = "Set the font size of the timer countdown text."
 SELECTPROFILE = "Select Profile"
 NAMEPLATES = "Nameplates"
 ZONE_SCENARIO = "Scenario"
 TIMEREDGE_TOOLTIP = "Sets whether a bright line should be drawn on the moving edge of the cooldown animation effect."
 NEWPROFILE = "Create New Profile"
 HEADER_UNITFRAME = "Configuration for %s frame tracking."
 ENABLED = "Enabled"
 ICONPADDING_TOOLTIP = "Set the padding between all active icons."
 TARGET = "Target"
 ZONE_ARENA = "Arena"
 ZONES_TOOLTIP = "Enable tracking for this zone."
 ZONE_RAIDS = "Raids"
 ZONE_OUTDOORS = "World"
 ZONE_DUNGEONS = "Dungeons"
 PLAYER = "Player"
 NEWPROFILE_TOOLTIP = "Create a new profile with current active settings as a starting point."
 COPY = "Copy"
 RESETPOS = "Reset Position"
 TIMEREDGE = "Show Edge Effect on Swipe"
 ZONE_BATTLEGROUNDS = "Battlegrounds & Brawls"

Game Version

Wrath of the Lich King

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Not sure.

Any additional info?

I know the addon is no longer maintained. If this request is unwelcome, please feel free to ignore it, and know I very much appreciate all your work on it over the years. Cheers :)

Adding a spell cause it doesnt show?

Hello! Can we add a spell we want. Example: i play DK and the addon doesnt show me the Disorient ''Blinding Sleet''. So is there a way i add it to the disorients etc? For DKs this spell is a must so is kinda of important :) Thank you!

[Bug]: Problem with the recent update (v2.5.0)

What happened?

Hello! I'm getting these errors after the recent update:

1x Diminish\Diminish-v2.5.0.lua:203: attempt to index field 'DEFAULT_SETTINGS' (a nil value)
[string "@diminish\Diminish-v2.5.0.lua"]:203: in function 'InitDB'
[string "@diminish\Diminish-v2.5.0.lua"]:232: in function <Diminish\Diminish.lua:231>
[string "=(tail call)"]: ?

1x Diminish\core\config.lua:48: bad argument #2 to 'format' (string expected, got nil)
[string "=[C]:"]: in function 'format'
[string "@diminish\core\config.lua"]:48: in main chunk

Locals:
(*temporary) = "Error: You're currently using the %s version of Diminish on a Retail client. You need to download the Retail version instead."
(*temporary) = nil
(*temporary) = "string expected, got nil"

I've updated with the Overwolf app, then manually from WoWInterface and Curse, by downlodaing the Diminish-v2.5.0.zip but that didn't solve the problem.

Thanks!

Is there any errors?

No response

Game Version

Retail

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

Disabling all other addons doesn't help.

Request: Add option to adjust font size/position for CC categories

Is your feature request related to a problem?
I'm on zhCN client and the font is too small to be readable on screen.

Describe the solution or feature you'd like:
I'm changing the hard-coded font size/position in config.lua for now. I'd like to have a option to adjust the font size/position in-game.

Additional context:

Player DR's duplicating to party1

I'm using "anchor to UIParent" setting on party and player DR's and whenever my DR timer shows on player, it duplicates it to party1. Party1 will still track DR's actually cast on party1 and those won't duplicate to player, but anything on player will also go to party1 (and refresh as if it was applied to party1 directly). It also happens even when party1 doesn't exist.

I'm assuming this has to do with the fact that when not using "anchor to UIParent", that player is in the default raid frames. So that might be the source of the bug (unless I'm really missing something here).

Diminish

[Bug]: Party (Raid) Frames no longer work

What happened?

Hasn't worked since DF released. DR's just dont show up at all.

Is there any errors?

No response

Game Version

Retail

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

None

Any additional info?

No response

[Bug]:

What happened?

Not showing DRs on party frames (using raid frames), everything else seems to be working. Only started happening within the last week.

Is there any errors?

No response

Game Version

Retail

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

No response

Not able to see countdown text

Version - 2.4.13

What is the problem? Is there any Lua errors?
Can't see the countdown text on the icons.

Is this issue for Classic, TBC or Retail?
TBC classic

What steps will reproduce the problem?
Can't see the countdown text no matter what configuration I've changed.

Does the issue still occur when all addons except Diminish are disabled?
Yes.

Was it working in a previous version? If yes, which was the last good one?
It has not been working since I've downloaded it but I can't remember when was that. I only noticed it when checking with my teammates and he mentioned there should be countdown texts.

Any additional info? If you play on a non-english client, please include your locale type:
I've been playing the EN client. I can see the indication numbers and the categories if I enable them.
2021-10-30 10_04_42-Window

[Bug]: Stun procs not showing in PVE

What happened?

Hello there again. If you know me I told you about the riposte bug. Anyway when I play my priest and I get a blackout proc. It will not display the DR above the target nameplate. I have it enabled and it's not working.

Is there any errors?

PVE stun procs don't work.

Game Version

The Burning Crusade Classic

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

No response

Can't move frames or test feature[Bug]:

What happened?

Can't move frames or test feature

Is there any errors?

No response

Game Version

Retail

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Yes, issue still occurs.

Any additional info?

No response

[Bug]: Riposte isn't showing up.

What happened?

Whenever I am spec'd into riposte on my Rogue. It doesn't show up in the disarm DR category when it has ended.

Is there any errors?

No response

Game Version

The Burning Crusade Classic

Game Language

English

Does the issue still occur when all other addons are temporarily disabled?

Haven't tried

Any additional info?

No response

Icon Size is randomly chosen when Masque is used

What is the problem? Is there any Lua errors?
No.

Is this issue for Classic, TBC or Retail?
TBC, but when I played Retail it occurred there to.

What steps will reproduce the problem?
Activate at least 2 different units (e.g. Nameplate and Arena).
Select different icon sizes for them (e.g. Nameplate = 20, Arena = 40).
Use "Toggle Test Mode" a few times and you'll notice that the icons for both Arena and Nameplate are (seemingly) randomly chosen between 40 and 20. So, for (e.g.) Arena1 you'll have for example 2 icons that are 40, and 1 icon that is 20.

Note: The issue seems to be happening only for Nameplate and Arena, other frame icons seem unaffected (I set them to 40).

Does the issue still occur when all addons except Diminish are disabled?
No. The issue only occurs when Masque and Diminish are used together. Since Diminish is intended to support Masque I thought it was worth reporting.

Was it working in a previous version? If yes, which was the last good one?
Not to my knowledge (TBC).

Any additional info? If you play on a non-english client, please include your locale type:
English client.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.