wardz/drlist-1.0

[WoW] Library for crowd control diminishing returns categorization data.

drlist-1.0's Issues

[BUG]: DR Timers are not displaying the max value, players are getting tricked

What happened?

On Classic/TBC/WotLK:

1. Use any spell which induces DR
2. Wait for the DR tracked by this library to end.
3. Use any spell which induces the same DR category as (1)
4. DR will sometimes not have reset

Is there any errors?

No

Game Version

The Burning Crusade Classic, Wrath of the Lich King, Classic Era

Game Language

English

Any additional info?

The problem is that the DR has been set to 19 seconds (https://github.com/wardz/DRList-1.0/blob/master/DRList-1.0/DRList-1.0.lua#L154), instead of the actual max of 20 seconds.

This is causing players to get tricked, causing myths that DR is actually wrong in Classic WotLK, and isn't actually 15-20 but more like 15-21 due to errors on Blizzards part - when in fact it's at least partly due to a config choice in DRList (not saying the myth isn't true, but many "claims" are just a DR timer configured below the max threshold).

My suggestion is to set the default DR duration value in the DRList library to the actual max of 20 seconds, thereby players would never get tricked into believing the DR is over when it is in fact not, and they would instead only be able to knowingly gamble on using CC early.

This change would, for the average player who is unaware of details related to AddOns and how DR works, remove completely unexplainable randomness.

Note: Yes, I am aware that individual AddOns can go in and hi-jack the DRList lib, changing the DR duration value by themselves. However, I don't think this is an optimal solution as it will cause different combinations of loaded AddOns to show different DR timers (and they could also interfere with eachother, each trying to set the duration to something different).

Curseforge Packager embed usage is unconventional

Typically, the main embeds xml file is contained in the root of the repo, so that when an external is declared in the .pkgmeta, the usage in the .toc file ends up like Lib\DRList-1.0\DRList-1.0.xml

However, DRList nests its main folder one level down, causing that conventional format to not work, instead requiring Lib\DRList-1.0\DRList-1.0\DRList-1.0.xml.

Since restructuring the folders at this point would break anything that is already using this, my suggestion would be to instead just to add a second DRList-1.0.xml at the root of the repo that then references the nested one.

[BUG]: A little more info with the libs

What happened?

Nothing is broken. Just wondering if you could make the template show more than it does right now. Like when the timer is up it prints out Spell has come off dr's or something?

Is there any errors?

No response

Game Version

Retail, The Burning Crusade Classic, Wrath of the Lich King, Classic Era

Game Language

English

Any additional info?

No response

[BUG]: WOW_PROJECT_ID is now WOW_PROJECT_WRATH_CLASSIC for Wrath

What happened?

Blizzard just released a patch that changed WOW_PROJECT_ID for Wrath Classic from WOW_PROJECT_BURNING_CRUSADE_CLASSIC to WOW_PROJECT_WRATH_CLASSIC.

Is there any errors?

1x DRList-1.0-25\Spells-Spells.lua:477: DRList-1.0: Unsupported game expansion loaded.
<string>:"=[C]"]: in function "error"
[string "@11DRList-1.0-25\Spells-Spells.lua":477: in main chunk

Locals:
Lib = <table> {
 IsPVE = <func> @..\DRList-1.0.lua:315
 GetCategoryName = <func> @..\DRList-1.0.lua:305
 GetSpellCategory = <func> @..\DRList-1.0.lua:291
 IterateSpellsByCategory = <func> @..\DRList-1.0.lua:354
 GetNextDR = <func> @..\DRList-1.0.lua:324
 gameExpansion = "unknown"
 categoriesPvE = <table> {}
 L = <table> {}
 GetCategories = <func> @..\DRList-1.0.lua:265
 GetCategoryLocalization = <func> @..\DRList-1.0.lua:305
 GetSpells = <func> @..\DRList-1.0.lua:258
 diminishedDurations = <table> {}
 GetResetTime = <func> @..\DRList-1.0.lua:280
 GetCategoryBySpellID = <func> @..\DRList-1.0.lua:291
 IterateSpells = <func> @..\DRList-1.0.lua:354
 NextDR = <func> @..\DRList-1.0.lua:324
 resetTimes = <table> {}
 IsPvECategory = <func> @..\DRList-1.0.lua:315
 categoryNames = <table> {}
 GetPvECategories = <func> @..\DRList-1.0.lua:273
}
version = 25

Game Version

Wrath of the Lich King

Game Language

English

Any additional info?

Gethe/wow-ui-source@3eaa29b#diff-239a2f4f8604d0b3956f4ee003b618690f95fbfb2c116e0d5fdc4e5cff41cb27R1105-R1106

[BUG]: Wrong DRs TBC

What happened?

Yo @wardz, I am the author of Gladdy.

I recently tested DRs extensively on PTR. My self-maintained DR-lib is quite accurate now. You might want to take a look and find diffs

-> https://github.com/XiconQoo/Gladdy-TBC/blob/main/Libs/DRData-1.0/DRData-1.0.lua

Is there any errors?

No response

Game Version

The Burning Crusade Classic

Game Language

English, French, German, Italian, Korean, Chinese, Russian, Spanish, Brazil

Any additional info?

No response

Unmaintained for TBC? Confirming claim

In this GladdyTBC comment, the author of Gladdy-TBC claimed that DRList has incorrect categories, and therefore they will maintain their own fork of DRData for TBC Classic. This is a concerning direction, because now 2 different DRData forks are seemingly being maintained, which will cause fragmentation and duplicated development toward the same goal.

Is their claim true, or is DRList known to currently have completely correct DR categories for TBC Classic?

[BUG]: Mind Control shows up in PVE.

What happened?

Mind Control for a priest in TBC shows up in PVE when it doesn't have a DR at all.

Is there any errors?

NO

Game Version

The Burning Crusade Classic

Game Language

English

Any additional info?

No response