Giter Site home page Giter Site logo

asterr's People

Contributors

comfy-pr-bot avatar was-plailabs avatar wasasquatch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

asterr's Issues

Reroutes node can't be used as input

I can pass data from one node directly to ASTERR normally, but if I use reroute, it doesn't work:

image

  • If I try to move output of reroute to input (e.g. a), nothing will happen
  • If I try to move the other way around (e.g. drag from input a, create reroute), then I will have reroute that outputs into ASTERR, but have no input. Then if I connect reroute input to existing node's output(latent empty image for example), reroute output will disconnect from ASTERR node.

Feautre request: dbg function

I'm not sure if it's possible, but it would be nice to have simple text output for debugging, eg

image

Right now I have either to alt-tab to look print(), or do something raise Exception

sys.setrecursionlimit breaking other nodes

I was hitting a python recursion limit on other nodes and just tracked it down to ASTERR changing the system recursion limit down to 100 by default. No big deal now that I understand what's happening, but I wonder if it would be better for ASTERR the store the system recursion limit and restore it when it's done? I haven't looked at the code to see if that would cause other problems or not. For now I'm just setting it to my system default of 1000 in the config.json.

FR: Consider providing a globals namespace to exec

Inside functions, we must import our modules as they are scoped from the main script
tensor2pil() and pil2tensor() are built-in methods to help with IMAGE input

The current implementation in ASTERR calls exec() with an empty dictionary for the global namespace and the self.params dictionary as the local namespace. As these are different, "the code will be executed as if it were embedded in a class definition", and, as you mention, modules need to be imported inside function definitions. More inconveniently, our functions cannot easily call other functions defined in the code block assembled by ASTERR without having to pass around a bunch of function objects.

I assume this was done to avoid passing the real globals() in, which would allow access to various imports that are not on the whitelist, but is there any risk in providing self.params as both the local and global namespace (including via the shorthand signature for exec)? This allows the code to execute at 'module level', and would allow me to move imports out of function bodies (while still being checked by ast) wile also making my considerably more readable.

Is it possible to output image batch or image list?

According to the reference code, this node can output one processed image. If I have more than one to output, how do I accomplish this?
I tried to create a function that returns a list of pillow objects and got an error in the pil2tensor function.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.