watchyoursixx/huntersim

Hunter Classic Sim

huntersim's Issues

Dwarf Gun Racial Not Working

The extra crit from dwarf gun racial is not being applied in the sim.

Wrong location for "Carapace of Sun and Shadow"

"Carapace of Sun and Shadow" is currently configured as Location:"Sunwell", whereas it actually is a LW craftable. Because of that it is not filtered out when unchecking "Crafted" in the item selector.

HunterSim/js/data/gear.js

Line 1761 in b274546

Location: "Sunwell",

'Hunters in Raid' not properly stored in localStorage (naming mismatch)

The input field on the page has the ID 'huntersraid' and 'onchange' calls 'fightSettings()'

The 'fightSettings()' function correctly reads/parses the value, and then stores it in 'huntersraid' variable before calling 'storeData();'.

let huntinraid = document.getElementById("huntersraid").value;
huntersraid = parseInt(huntinraid);

The 'storeData()' function then attempts to save it in localStorage:

localStorage.setItem('huntraid',huntersinraid);

Issue: It reads it from the variable 'huntersinraid', but the actual value was stored in 'huntersraid' - thus it does not get updated in localStorage.

talent selection is blank on reload from a fresh cache

will need to look at. Talents after first refresh require you to re-select the talent dropdown.

custom armor values don't save correctly

custom armor values don't save correctly due to how I'm loading/saving buffs. Will need to look at later, basically changing targets doesn't trigger the save data so it doesn't keep that data unless you change another setting

can't edit player uptime, pet uptime or % fight weaved

these 3 settings can only be at 100%/don't have the updown arrows to change the number when you hover over their boxes.

debuff settings aren't loaded to the display

Race/Spec wrongly displayed after reloading

Even though in the settings I selected "Draenei" race and "BM 41/20/0" spec, whenever I reload the page it shows "Orc" and "SV 0/20/41" spec above the active gear.

Edit: Just to clarify, the settings are correctly saved/loaded, it is just not reflected on the "main page" upon reloading the page. Also, shouldn't there be a different icon for MM/SV specs?

'showSaveFilePicker' function (Export) not available in Firefox/Safari

Hi, I did some investigation on the exporting issue under Firefox and why simply nothing happens when clicking on the Export button.

The root-cause is that "showSaveFilePicker" does not exist in Firefox. It is still considered an experimental feature in general and Mozilla sees potential harmful use-cases due to which they don't want to add it (yet).
See here for browser-support: https://developer.mozilla.org/en-US/docs/Web/API/Window/showSaveFilePicker

And here for Mozilla's reasoning: https://mozilla.github.io/standards-positions/#native-file-system

Now because the function-call is inside a try-catch that has no "error-handling" (it simply sets the 'succes' variable to 'false'), it seems like nothing happens to the user:

    try {
        handle = await showSaveFilePicker(opts);
        success = true;
    } catch (e) {
        success = false;
    }

May I therefore propose an alternative solution for browsers that don't support "showSaveFilePicker" (mainly Firefox & Safari, and all mobile browsers), to instead open a new browser tab that simply shows the JSON content as plain-text so one can copy-paste it and save it manually in a file or wherever instead? This even could be done directly inside the "catch" part as a generic fallback solution.

Save set without having a loaded set throws Uncaught TypeError

Whenever you first open the simulator without having a created set loaded yet and then click the "Save set" button, the following error is thrown:

Changing an item of a loaded set, also overwrites the set in localStorage ("by reference" issue)

Steps to reproduce:

1. Load a custom set
2. Change one item
3. Load the same custom set again

Expected behavior:

"Old" item from the saved set is shown

Actual behavior:

The "new" changed item is still there

Root cause analysis:

When loading a (custom) set, in 'loadSet()' the set is read from "SavedSets" and a reference to its object is put in the 'gear' variable.

let activeset = SavedSets[val];
gear = activeset.data;

When an item is changed and 'selectItem(itemid)' is called, it overwrites the value(s) in 'gear'.

case 'shoulder':
    console.log("you selected "+ itemid);
    gear[activeslot] = { id: parseInt(itemid), gems: [], enchant: ench };
break;

Now since 'gear' is basically just a reference to the 'SavedSets[val].data' object, it is also changed there.

---

Simplified example and solution proposal:

Simple example to reproduce/understand this issue:

const myArray = [
    {
        'name': 'First Entry'
    },
    {
        'name': 'Second Entry'
    }
];

let firstObject = myArray[0]; // firstObject is just a reference to the first entry in the Array

console.log(myArray[0].name); // "First Entry"

firstObject.name = 'Changed Entry';

console.log(myArray[0].name); // "Changed Entry"

In order to fix it, you need to make a shallow/deep copy of the set when loading it. In case of above example, the following would result in a deep-copy:

const myArray = [
    {
        'name': 'First Entry'
    },
    {
        'name': 'Second Entry'
    }
];

let firstObject = JSON.parse(JSON.stringify(myArray[0])); // now an actual (deep) copy of the object is created

console.log(myArray[0].name); // "First Entry"

firstObject.name = 'Changed Entry';

console.log(myArray[0].name); // "First Entry"

custom target options are unselectable on initial load if custom is saved

Cancelling export throws Unhandled Promise Rejection

When I click on the export button at any moment, the file dialog correctly opens. But when I then cancel the dialog, the follow exception appears in an alert dialog:

Unequipping gems/enchants is not updated in localStorage['gear']

Unequipping a gem or enchant, does not trigger an update of the gear object in localStorage. It is only getting updated if a an actual gem/enchant is selected.

Thus in order to actually remove a gem/enchant from localStorage (and thus make it relevant for the DPS sim), you need to re-select a gem/enchant in another slot as this triggers a refresh of the whole localStorage['gear'].